From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71EF0C433E0 for ; Mon, 8 Feb 2021 02:01:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15A2364E28 for ; Mon, 8 Feb 2021 02:01:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15A2364E28 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N+Z14jdyjjP3hs1ZGvp368+jWWgcE0ntxwbmq5G2As4=; b=beSDpSJkVrBEhHgf428/gWctA 3/u14+Mvkf71NdG5gHuRHBZDqfpmBUTsYDoZq00z4NUNS+g2hWqTD3mrFigcdgFbPAo/YebbGgCk1 iUsVgH2m/KImDaMcFLDyHkSGYAwdnbSx9UZqd4jqZNuZ8B2mU3hPBhemhwPebpJmDx8tBjHFKoZzr ayUsiYufhY5iynrd556Fsc3IGMdSOGU+Ju0rWMSYT+ZwMOAxWuj1YY+3DwK/D40mbs4E0W/jw1xR5 WpQkLkyF6YG33Psh4U4OnZc2NY/SD6JYM7qWRHmNAFj+OnmtDPycJyCGXSiEw6rYcmfCPS16zFCVH einv8YLqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8vqn-0000Cv-Rz; Mon, 08 Feb 2021 02:00:29 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l8vqh-0000Bt-Nd for linux-arm-kernel@lists.infradead.org; Mon, 08 Feb 2021 02:00:25 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 11820AkW123340; Sun, 7 Feb 2021 20:00:10 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1612749610; bh=cUtFIfOlkE66hKZ1iSDwIL9jGzTqS4QxLAUcpT4MTbM=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=apsu4RILEZPLAGEaHnF7AHIxBXnqVsHiIrfJNRUxWE9k4p00Fibsx4Hh8JAMM5eGc MSTyzFqD8sBnIJ562Xr7lFcGOEb7I8Q/G3tid/MpGf6Iygj74Mhbofy8hM+CD7d/kW Qq2+En/2/+KkTOGFb+zks4j20TMRza3RHrWg72NM= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 11820ANp120619 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 7 Feb 2021 20:00:10 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Sun, 7 Feb 2021 20:00:09 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Sun, 7 Feb 2021 20:00:09 -0600 Received: from [10.250.232.75] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 118205jW070770; Sun, 7 Feb 2021 20:00:06 -0600 Subject: Re: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2 From: Kishon Vijay Abraham I To: Nadeem Athani , , , , , , , , References: <20201230120515.2348-1-nadeem@cadence.com> <15abdca0-d1e1-64b7-4a9a-d7549f035e01@ti.com> Message-ID: Date: Mon, 8 Feb 2021 07:30:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <15abdca0-d1e1-64b7-4a9a-d7549f035e01@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210207_210024_015360_C91381D1 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mparab@cadence.com, pthombar@cadence.com, sjakhade@cadence.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lorenzo, Rob, On 12/01/21 12:45 pm, Kishon Vijay Abraham I wrote: > > > On 30/12/20 5:35 pm, Nadeem Athani wrote: >> Cadence controller will not initiate autonomous speed change if strapped >> as Gen2. The Retrain Link bit is set as quirk to enable this speed change. >> Adding a quirk flag for defective IP. In future IP revisions this will not >> be applicable. >> >> Version history: >> Changes in v7: >> - Changing the commit title of patch 1 in this series. >> - Added a return value for function cdns_pcie_retrain(). >> Changes in v6: >> - Move the position of function cdns_pcie_host_wait_for_link to remove >> compilation error. No changes in code. Separate patch for this. >> Changes in v5: >> - Remove the compatible string based setting of quirk flag. >> - Removed additional Link Up Check >> - Removed quirk from pcie-cadence-plat.c and added in pci-j721e.c >> Changes in v4: >> - Added a quirk flag based on a new compatible string. >> - Change of api for link up: cdns_pcie_host_wait_for_link(). >> Changes in v3: >> - To set retrain link bit,checking device capability & link status. >> - 32bit read in place of 8bit. >> - Minor correction in patch comment. >> - Change in variable & macro name. >> Changes in v2: >> - 16bit read in place of 8bit. > > Could get GEN2 card enumerated in GEN2 mode in J7ES EVM. > > Tested-by: Kishon Vijay Abraham I Can this series be merged? Thanks Kishon > > Thanks > Kishon >> >> Nadeem Athani (2): >> PCI: cadence: Shifting of a function to support new code. >> PCI: cadence: Retrain Link to work around Gen2 training defect. >> >> drivers/pci/controller/cadence/pci-j721e.c | 3 + >> drivers/pci/controller/cadence/pcie-cadence-host.c | 70 ++++++++++++++++------ >> drivers/pci/controller/cadence/pcie-cadence.h | 11 +++- >> 3 files changed, 65 insertions(+), 19 deletions(-) >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel