From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ECEEC433EF for ; Mon, 3 Jan 2022 07:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OdwDvteokUdF41rDfX9wtLQtXDmrr4N7itbeqJ1ctUc=; b=bnr6ehI8bM+kvI 71/3pMi7LmDBbTKkx5Z8VkVagCUeMcY08GcIZK26/oPtAJR+c442gYBL4oRTiV6tgRAv/PAaRJ/DF Vbkm/gKv+fQOpwaoO3WlG5x/uBUaqFUfXTUfQdyb5SzDoTGmNoP2vXnA3TBVBn+GpWtvVWI4dPbck HHntii5QSRJ5gex2WPZogM1IU0iANqdRwYjIrbZvR5CP107Lx9Pwx608uV+bIvDKWpD+BVmvr1Gqj R8r/ObLGonirHEkJMzgcmKfiUSmxgAOKQiY2OILpiidiVVchZPIFvSimEb0R8kLmwAwnlyeCvM7AA 48AviThzaD/X/xoTSh0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4I9x-008XcQ-7q; Mon, 03 Jan 2022 07:53:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4I9t-008Xbp-Ao; Mon, 03 Jan 2022 07:53:35 +0000 X-UUID: f3478d42cda0437d9701b275d7fdabbf-20220103 X-UUID: f3478d42cda0437d9701b275d7fdabbf-20220103 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 438459850; Mon, 03 Jan 2022 00:53:32 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 2 Jan 2022 23:43:30 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Jan 2022 15:43:28 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Jan 2022 15:43:28 +0800 Message-ID: Subject: Re: [PATCH v16 0/7] soc: mediatek: SVS: introduce MTK SVS From: Roger Lu To: Matthias Brugger , Enric Balletbo Serra , Kevin Hilman , Rob Herring , Nicolas Boichat , Stephen Boyd , Philipp Zabel CC: Fan Chen , HenryC Chen , YT Lee , Xiaoqing Liu , Charles Yang , Angus Lin , Mark Rutland , Nishanth Menon , , , , , , Date: Mon, 3 Jan 2022 15:43:28 +0800 In-Reply-To: References: <20210428065440.3704-1-roger.lu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220102_235333_416475_B6B74AFC X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Matthias, On Thu, 2021-12-30 at 14:18 +0100, Matthias Brugger wrote: > > On 28/04/2021 08:54, Roger Lu wrote: > > 1. SVS driver uses OPP adjust event in [1] to update OPP table voltage part. > > 2. SVS driver gets thermal/GPU device by node [2][3] and CPU device by > > get_cpu_device(). > > After retrieving subsys device, SVS driver calls device_link_add() to make > > sure probe/suspend callback priority. > > 3. SVS dts refers to reset controller [4] to help reset SVS HW. > > > > #mt8183 SVS related patches > > [1] > > https://urldefense.com/v3/__https://patchwork.kernel.org/patch/11193513/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MIscKXW-$ > > > > Already mainline, please either refer to the commit, to make it clear it's > maineline or drop it. > > > [2] > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20201013102358.22588-2-michael.kao@mediatek.com/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3ML35Ale5$ > > > > Same here. > > > [3] > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20200306041345.259332-3-drinkcat@chromium.org/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MMUMr7Oh$ > > > > Same here, Thanks for the review. I'll refer to mainline or the latest reviewing patch. > > > > > #mt8192 SVS related patches > > [1] > > https://urldefense.com/v3/__https://patchwork.kernel.org/patch/11193513/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MIscKXW-$ > > > > Same here, it's actually the same link as [1]. > > > [2] > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20201223074944.2061-1-michael.kao@mediatek.com/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MEUxFEDM$ > > > > [3] > > https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1360551/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MNObUeLt$ > > > > [4] > > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20200817030324.5690-5-crystal.guo@mediatek.com/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MMx-JKoe$ > > > > There are many dependencies for that. Some patches need resubmit, others seem > to > be stale. I'd advise to concentrate on mt8183 for now and add support for > mt8192 > once dependencies have settled. Sure, let's concentrate on mt8183 patches first. Thanks for sharing the advice. > > Regards, > Matthias > > > > > changes since v15: > > - Put (*set_freqs_pct) and (*get_vops) in struct svs_bank because they are > > part of svs bank's operation > > - Add define "SVSB_INIT02_RM_DVTFIXED" and "SVSB_MON_VOLT_IGNORE" to make > > control clearly. > > - Remove unnecessary parenthesis > > > > Roger Lu (7): > > [v16,1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings > > [v16,2/7] arm64: dts: mt8183: add svs device information > > [v16,3/7] soc: mediatek: SVS: introduce MTK SVS engine > > [v16,4/7] soc: mediatek: SVS: add debug commands > > [v16,5/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings > > [v16,6/7] arm64: dts: mt8192: add svs device information > > [v16,7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver > > > > .../bindings/soc/mediatek/mtk-svs.yaml | 92 + > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 18 + > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 34 + > > drivers/soc/mediatek/Kconfig | 10 + > > drivers/soc/mediatek/Makefile | 1 + > > drivers/soc/mediatek/mtk-svs.c | 2524 +++++++++++++++++ > > 6 files changed, 2679 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk- > > svs.yaml > > create mode 100644 drivers/soc/mediatek/mtk-svs.c > > > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MIj4Pohu$ > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel