From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AD04C19F29 for ; Mon, 1 Aug 2022 11:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AwG59xco89MZ7odIp7/zQw4+XXgz8HQH9//qe+zagu8=; b=NG2rEsSEoxTxlI xx0oAaO4WupczLg+LBvDAZRL1DXZnSrZMqd/VfTKY6D+z9IEMDapEgbT2FMFwLC2jSAPd1lNsU8m0 gsUWuizazRpMpG3OZcMFd8kyPpAykcZXoBrgJ8PWUa7LW6pvxNmiF5yc7XKptxMlQHr86JYGt821S LBjJfKYOLOrSSAzmScraRED1rl6pDZfpCeHE8VSSITBO8zRAbto/UDMYYdBtF14WnU7TAAsNyDEnt bEWUNMGqDHoYG54s6UhV/kU7mh+MvCo2k8EOGquZCq3vXNu97ywK4HfVKN70e2DgW9Wkg62ZhQlti mwhEsRpsX1ZUOJbb5I4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oITj3-005b4F-3g; Mon, 01 Aug 2022 11:36:46 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oITi9-005aaN-Sa for linux-arm-kernel@lists.infradead.org; Mon, 01 Aug 2022 11:35:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1659353750; x=1690889750; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XfPbF+75kore5kYnVE6p20mKqA3CdKS2Eg+AEonRVfc=; b=rqo6H10QEOkHyXsExrEPonS9dnuOyIu3YviaTCTbfRfSW7B8C6l8WxNM Lg3e3ys8cMKfE3C/4+85t9G/DtVQMVCqbtNBkTX6u8fikGBzu0o1IRSuB J/xwtv+zU57kgjQM8rEG8E/9mtvB7niAV2ixsuUHjnLkcZOox9Zo7UuYA k62xFPwrZ3GKlL2R289wesVYymSgqA7Y+/MK3YtWGPuc8NV+mqw3XlWfD lt3TIoS37Fvsi/fgZn5pj3sBDqA73OGw87wFk4wMT5mDyBQ/clcZIrmqF Wl/je0JDz36GgzFS1+3u88to0QAZyUKUzs0cYKYlFbOiN7XS7NJMOsafG g==; X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="167257886" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Aug 2022 04:35:40 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 1 Aug 2022 04:35:39 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 1 Aug 2022 04:35:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZWhg21e2xKeWWO8vdrSHPy57KUlHRClvcxoIGRUebw0R5LvLP/GQkpvP+NnZ5FDM3ugSIGSwLqILuUW192wSY+/mXn3RqHgCuKCSjhDvK1gccz8qsBKRLf02BgQa38MMonFnaWztw27YQdTCGgaeH9at8KOyGqAAom7AgoZZOJedCs2/nfe88nvTSnO3upgQt9+uId8DTeYApqdQFYWR4ws/SLGY35qYjJylQLWujIGejL4RK1wZdeVcen9fx69VbCr3+EfcZmp0tD44c93kf2aY6bJNw4RsMD53PB8l+GAdgls4FTN3C5+U0RGXHW/miGkI2O4hKe08xBTNKP9kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XfPbF+75kore5kYnVE6p20mKqA3CdKS2Eg+AEonRVfc=; b=LH2iiG+EzBOPhwAKDxZDEWdyHXrkKaw5ORl3S+vZUNggqT7PcmMdL0jMS3aq/AeiPIS7y4/YBxAkaQ2AjbiwSGltZsdmKNvXHcNJXZDA9rv7pslVcQUgKwVvF7W1/TVrmfpGN+044Fy78T4O7rf4J6LWGNRygf2akJSBq9TAPB0EZkbWM0Vpmbqnlr+cVQGmqhuRC4Aq21g0ldPBTSF9R0s7Ljt1H3HuAOqThVfxTngNrQ/OKpscyyNsJFrb26LkgqDKKTWkc2jyPF924/d5k3mfD0JzNPAPm86uAa80rEgoR4QBfvQi0rIB1cVbJKKA3TQ/dfLZE7Pqp4rQ0NACWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XfPbF+75kore5kYnVE6p20mKqA3CdKS2Eg+AEonRVfc=; b=XOYjjb/MVhwTSdyhz+3XMHTSWyN8n9WYwqPB77GUPIUeMBIr3KGlRXPaKdRpCqZkPMGVSpMsI0swhK5I3fjYMfSjCCTZRt9YzJyFlBb8gNCfqlLyK4b/WUL9JfyOcZ4GeOjYeY6VSr6ac9LYdpnVwVz+ECwDEP3NAQycEa1lJQk= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by MWHPR11MB1584.namprd11.prod.outlook.com (2603:10b6:301:e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Mon, 1 Aug 2022 11:35:32 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5c8c:c31f:454d:824c]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5c8c:c31f:454d:824c%8]) with mapi id 15.20.5482.016; Mon, 1 Aug 2022 11:35:32 +0000 From: To: , , , , , , , CC: , , , , Subject: Re: [PATCH v2 net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support Thread-Topic: [PATCH v2 net-next 2/2] net: macb: Add zynqmp SGMII dynamic configuration support Thread-Index: AQHYpZrOVcttQx4yeE6JUFSlUeGuJQ== Date: Mon, 1 Aug 2022 11:35:32 +0000 Message-ID: References: <1659123350-10638-1-git-send-email-radhey.shyam.pandey@amd.com> <1659123350-10638-3-git-send-email-radhey.shyam.pandey@amd.com> In-Reply-To: <1659123350-10638-3-git-send-email-radhey.shyam.pandey@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 820dfe62-889b-4268-5e3e-08da73b1f160 x-ms-traffictypediagnostic: MWHPR11MB1584:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u0HkdbCU2aEptE2sgVdKo1P9L/y7yaBGSYs3JCWfQkXMnlwmibEsPBF7v4sxD9rtnHKgIYcTIcdkFONEptPL7nmYyIY2jN+edrPfvpe1LeF24BekB+cfR7X5fYWU85BeRJ62WM/e3eaj0dObbKUxJCaA2TSNmkEuNME6iXeeQgqD6hykD7u6fZPQryvSOq1Fc+UH/67MCDpGSl6wgbyjVB/9SX1iJscwtUctzG/tr1BsJ83PG8HK7U8DxaMfkT0kWW6RyaUBgAsI/PQg0z8aVfIJJW0txE8bDsbP9sDRhWWQUTx2RDqn+42JQhHh4BBE6Ybl349U4jq9kr7iLvefp1ipErLLUqLNrigLRyJFOMAuwo6UzLwKHFgd6TUyX+KY5p90/lOGBsitzgFlmxrPgU70/b3VnT7gI6nCrEmwv0sI4o8/evNfEe+wBUp/g2tc6GK8GMlJQzhq7jz3BSc3A8YkqueHl4b0vd2pPqxk68Dh/Ml5g3wZe4scIEV6AfrBiEh1kAKMzXLF3yNc0ogtS6CPZCxF2K6wUsultyMANYdVgNVYF7avNyKeA86t9jqq5I5Alj0Z1CGyGehCSa+iN5m+vPhd2b4Nc9PLeGba5BaxWHtXCeshTa27nfdCcWljGVEeimzOxL7McUpNt7vWAqiDq31JVoKhQE5VarLz+SgPlzHxcY+5lk17XVx48qHf0xsTvqud0G123SAYjcnDF6KYgmxmVQPoigqWS5S2Bwu8aa6WbiQaUwcOyfQjWOK5Jn8ObhI8NRagnpKuJeppfEdVwGElzh3FjaF8fybAeEqzg+efRwNUVal8x20Odf/SWIxKG6KQYafDMKOHiyCcW9op2l/Efrdqbm7sRLKofeg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(39860400002)(366004)(136003)(396003)(53546011)(316002)(86362001)(54906003)(38100700002)(36756003)(110136005)(6506007)(7416002)(5660300002)(31686004)(38070700005)(31696002)(8676002)(8936002)(122000001)(71200400001)(83380400001)(76116006)(91956017)(66476007)(4326008)(66556008)(64756008)(2906002)(2616005)(66446008)(66946007)(26005)(478600001)(41300700001)(186003)(6512007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eHY3R21MT3JmN2Ywd3FZaEJ4M1VvZ09YSU50SFV6dHRjaFpSRzYrOUhobUxz?= =?utf-8?B?c2ZDRi9TbHhrZW5CdDRMTW1oKzJ5bHpkTmc5djdpa0lNN0dOdllyQTNhUWRr?= =?utf-8?B?NmtBVjdRSXdGaVpUYmVSSElHZ1lUL1VteFRMNWVtNktGUHFERG9ESWtZZVlI?= =?utf-8?B?NVlnc21MOWJXVjh2S1BId1J4cElTTCt0V3hhb1BkTFVVSDkyOHc1Um1EOXpw?= =?utf-8?B?bTA2L3lMbDBOWmZ2NFdZOU5JWE45clArZlBvWW90bmt1eGIvMEo2bzJZOG9z?= =?utf-8?B?SHNtMjkxdnFiZXFlalFYSnJPOURLMG1zN2FkaDdWdjRCUDJqR1dVZnBCVXZr?= =?utf-8?B?VFAyMi8vKytiaEw2TUVyYy9oRDAwYVdmTDkxU21oOTM4S2hldXRPc04yUVBM?= =?utf-8?B?c2F5dHBiT3lBZU5YcVhtUUtqeEJMR3E4cGNOWjBBY0k0bkpwc2dsYjhQa0hx?= =?utf-8?B?SFZIK2RBZ2N1NnROWGM2NWhVQkZHemo2Z3MrWmI5TU9XMGhuS3BiMFd4ZjFz?= =?utf-8?B?Y3A5aGNmS20xUVVLQ014RDNSQVdIU1VKSDl3bnFyc083M1lzbFRUditqd2U2?= =?utf-8?B?RGw0R1pZaXloTGRDUnBSN0h2VzlTQmJZSTZtMFloU2ZVYVFubW1XQVZ3YzRx?= =?utf-8?B?Ukxqek9iVVpoNGRQdEF3OGZjdmZVRndydElQdXZ4WlF0eXpsNklSTzVHS0VQ?= =?utf-8?B?eURjbzRBR2V4dGFmVHVXM0RvUFRZRW84MVA4NmVMS1FlRlRpRU5iZGFsd2Mv?= =?utf-8?B?S3lwQ0sxK1lqYmpibE5aSTRReVo5ODJrU1BLVzBXSHBzSG9PQmNIMXpXM3o2?= =?utf-8?B?WFVGSEh6T050c25ObWhuU1Z0R0IvdHVuWmNZNTZuRFB3TVlJRy9FbWNIaXlE?= =?utf-8?B?elpuWEFndE1GancxVUZza3g5ZTFaYUczdFl5bFZGQjhIaHFRVDNST0s4VVhX?= =?utf-8?B?YkVqQVpJRGU4NndWMzhoK0VpSVVhMUg1dmlQTU5SbW9xTlJibG9qOWJKSkVt?= =?utf-8?B?SlpQQi92Tys4U0RSbEVOMTFrZHhDbVVnYWVmWjVzcWJtVGhLeDdjSWpmWmtT?= =?utf-8?B?RHErWjgyTFh0WWw4djdkbWF2VDFWM1NYRURZMTJSaytGSWQ5c1A4eXRtQVZT?= =?utf-8?B?OXVsTXQydlZETFpITVI5TGRkRWxHNGdoRDdseU1QeDNBeFJoMWo0T0NDcDN2?= =?utf-8?B?azZtZzU5MGpXWjJZZ2RpdDRlZFR6cFdXTlB1dU9sTUJFVWRDMTVQdHhyTGhZ?= =?utf-8?B?VGR0d0x3UDd6dUhKTTNOdVBJaE5yZHhLMWxtOS82cEErZmltM2Jpd2xtNXNR?= =?utf-8?B?SkdmTFozL2RKeXQrSll4Z1FGL0k2SmpkVFViUFNTNCthWGFrYUhaa1FhcGlJ?= =?utf-8?B?RmNZWU5JWTBoOWJLOHRBS29NS0JDY3J0a2Z3MlFNa3ppditpaGUyLzVKN3Q0?= =?utf-8?B?RjZ5cno5SDgxOWgySFIvQ3VnZGM4RERmclpSZ05wc2VYRHVlMG9VTmJqaTZ4?= =?utf-8?B?RDVMaGhtR3dtWVdNR1hOQkVheUluUnc5L0JrOWVlWWdlN1FhSjdxZ24wU1lJ?= =?utf-8?B?SlBpTThOZGFGV0JGdnFoOERPMFNIeDRZZ3lCWjJjUXo1VjVsNjdaemFPa1pt?= =?utf-8?B?eFUrN2lNUHVDUnlZRkU0WWxMMmVvNS9lYlZ5OFJETE5Cbnd0cEJJcTJJMDdI?= =?utf-8?B?N2VUUEErZ3V0YUNpc1NwbTRaK0t2MEVqZkRJQ3o1bkhuZzV4eUJ1Nm1tcFlt?= =?utf-8?B?WjdzRWxoaklzdFp4d1czQlVCdHY1S2xRVVRyZ0lDU25KYUJSRHVreGxmSzI3?= =?utf-8?B?S21wSU5WU3dkNDY3eEtKL1VpS1RocjRFWndkd1VOTjdySklTREpHcE5za041?= =?utf-8?B?NTRoL2dtdTNiTEhGM3hndVRpZ2hSZCtNcHI4dlNLck5EY25rMjFkRlNDNGo0?= =?utf-8?B?M1FnV3ZCeUx1UGFQTlJHZVFGZ2l5aXRJVm8zYlJaMGg2SGFpN3lVWTZWeldH?= =?utf-8?B?RTA0cHdkNmdXYlp0MTRXaHNYTnNsNE9PVGEzRjM5UlkrNHNTWGp2bjJTL1Yy?= =?utf-8?B?WE5zTE1HMjdENmVGclJSTmhkdDJvNUZyUGREcXplTTNmbDRtMCt0V0VNSG9j?= =?utf-8?B?MWs2YVhOQURyb0dEenJVTk9iOUU2Y2RkTVVOSzlNbkhGZzJiaGdBWjJwUzUx?= =?utf-8?B?VHc9PQ==?= Content-ID: <0EFC93AEBAD6BA458C545FBD8E950799@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 820dfe62-889b-4268-5e3e-08da73b1f160 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 11:35:32.1908 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 38jFyTlkKuTxr2LE6hiPGGDffF8Zwi9wNcsi9KudBskYjgTaWjlcZPsuOfuLt6UboDYXSfCWAsgSbvjT6Gsl/wwhcyQ8gkc1tXBfR/UWpNs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1584 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_043550_087536_1313FF9A X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29.07.2022 22:35, Radhey Shyam Pandey wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Add support for the dynamic configuration which takes care of configuring > the GEM secure space configuration registers using EEMI APIs. High level > sequence is to: > - Check for the PM dynamic configuration support, if no error proceed with > GEM dynamic configurations(next steps) otherwise skip the dynamic > configuration. > - Configure GEM Fixed configurations. > - Configure GEM_CLK_CTRL (gemX_sgmii_mode). > - Trigger GEM reset. > > Signed-off-by: Radhey Shyam Pandey > Reviewed-by: Andrew Lunn > Tested-by: Conor Dooley (for MPFS) > --- > Changes for v2: > - Add phy_exit() in error return paths. > --- > drivers/net/ethernet/cadence/macb_main.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 4cd4f57ca2aa..517b40ff098b 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include > #include "macb.h" > > /* This structure is only used for MACB on SiFive FU540 devices */ > @@ -4621,6 +4622,30 @@ static int init_reset_optional(struct platform_device *pdev) > "failed to init SGMII PHY\n"); > } > > + ret = zynqmp_pm_is_function_supported(PM_IOCTL, IOCTL_SET_GEM_CONFIG); > + if (!ret) { > + u32 pm_info[2]; > + > + ret = of_property_read_u32_array(pdev->dev.of_node, "power-domains", > + pm_info, ARRAY_SIZE(pm_info)); > + if (ret < 0) { > + phy_exit(bp->sgmii_phy); Could you move this to a single exit point and jump in there with goto? Same for the rest of occurencies. Also, I notice just now that phy_init() is done only if bp->phy_interface == PHY_INTERFACE_MODE_SGMII, phy_exit() should be handled only if this is true, too. > + dev_err(&pdev->dev, "Failed to read power management information\n"); > + return ret; > + } > + ret = zynqmp_pm_set_gem_config(pm_info[1], GEM_CONFIG_FIXED, 0); > + if (ret < 0) { > + phy_exit(bp->sgmii_phy); > + return ret; > + } > + > + ret = zynqmp_pm_set_gem_config(pm_info[1], GEM_CONFIG_SGMII_MODE, 1); > + if (ret < 0) { > + phy_exit(bp->sgmii_phy); > + return ret; > + } > + } > + > /* Fully reset controller at hardware level if mapped in device tree */ > ret = device_reset_optional(&pdev->dev); > if (ret) { > -- > 2.1.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel