From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D381ECAAD2 for ; Fri, 26 Aug 2022 06:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5E2i0IRLWuTvPZg3DTTW4RCg9ZLkiMEmWd0YvToVWW8=; b=tZws+M9qFHsb1k H9Paa3DK8L5qTpAk1uqkd5yr3TDsExMpPErhJXRV76h8RlLcgP9Z0ExAehaFHDObSsLV1t6HWj2gA /ZrCxEU+D7qwGNK83bnWj20zpQubh/DLOaxiVnfF9Dz7stGV6UcnMQ7ZSTHB0AbmhWZ9QXj5nzBHo nrVZrKbbmY7w5st/1/N2kkTlEamp+U/lHdZnAVYU3ajR7i558sI4StsUo6gsNvJ0dMLlWrXhdHske YmmelFD2/Iz+1q9uVJnsEdaNssl1q+g1NSm/KNQbHJ60N51P5+3/1MDdFGjq6LmirXzx9E+BvCkkd TYzay6IC3pDkQCTQrFEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRTAw-00Ev7d-Ej; Fri, 26 Aug 2022 06:50:43 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRTAs-00Ev2b-Cc for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2022 06:50:39 +0000 Received: by mail-lj1-x22e.google.com with SMTP id q18so684405ljg.12 for ; Thu, 25 Aug 2022 23:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=7ucuTjvwcIeRgdHUmyQVPcOH0rtFIB9s92k3HvPl+Lg=; b=UYyICR8Kxwxx3N+l7H9vpwbhmxjQgKuED9l4C3BW8de56rIH6/rCSVoGsirsqC/mlY HrUIIH136YrjQQs+UW8+I8ekNgXkQSZCQF4jkpaO7nwf98t8ccK4S7wUh9dHlDIR8eve UMSCAYrj8MenS4A6DSa5fgg//e/PFeYV6tXhiwRgfQLwWI1gPaITe3lGvI4a/TKiuIj1 7kfY1ByEIJDuPuNsOGqZWdmgqY2brrV/nGQoHVebnrKB1m5aAB5i65lTaPXnziflxP7D bzOrlMOKv8+8alYcPSRsVmz+amuXm6ReASHU/u+5nq7OTJtARrH2ICC/kvxGZWE9LJPL rLnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=7ucuTjvwcIeRgdHUmyQVPcOH0rtFIB9s92k3HvPl+Lg=; b=yStipv3F5Q6Xn83IBo9LFDva/nuuavmBd415cih7sn8oper2K/moHt8Dui1n3bRGoH jfZmLUes3siIPP/KgDOol0c8kNXJgE442EZ4g0sVANBFWIL3tnELuFMTVf6y8iQG8e8C eaCyrELlOp6T8R2mKsuFhH/OJzlDo0wp3zFIdBR1UeL7/oS4JN6AP85h03gTZZ9RZLw6 WQh/TJUOPlL/ZPC4Qoo8bQ2WGJicauJ2RcHlsfquYhCAnFyta5AcUYqvtfx1f3jIYxHl b9L618lBdgcuyKoC97iTMIXU4MPwrqIoShD6WqM4eD0zW4zAF9GYxzAN6oWaCsEm1Qwl Lcaw== X-Gm-Message-State: ACgBeo0KTh+FulqfoxH8ceFEii20vpkPnJaZKKnPWRdgB9Rs8aZLveWj QaySX6CPxpUqg/6X6N6sNxRtKA== X-Google-Smtp-Source: AA6agR55muQUl0EGQptKMs7t57bYTpy+EF08JVpOQGsnvB+PmIqzUrrBi05Mcf4CLakmC5vokewSKg== X-Received: by 2002:a2e:54d:0:b0:261:bbfc:23f8 with SMTP id 74-20020a2e054d000000b00261bbfc23f8mr1743546ljf.145.1661496636932; Thu, 25 Aug 2022 23:50:36 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id w27-20020ac2443b000000b00492faa68260sm258539lfl.229.2022.08.25.23.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 23:50:36 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 09:50:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v5 5/5] arm64: dts: rockchip: Add PCIe v3 nodes to BPI-R2-Pro Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Philipp Zabel , Yifeng Zhao , Johan Jonker , Peter Geis , Simon Xue , Liang Chen , Shawn Lin , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220825193836.54262-1-linux@fw-web.de> <20220825193836.54262-6-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220825193836.54262-6-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220825_235038_510048_970D6DF4 X-CRM114-Status: GOOD ( 21.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/08/2022 22:38, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add Nodes to Bananapi-R2-Pro board to support PCIe v3 and > set PCIe related regulators to always on. > > Suggested-by: Peter Geis > Signed-off-by: Frank Wunderlich > --- > v5: > - rebase on 6.0-rc1 > - add pinctrl for pcie > - fix ngff pwr_en_h gpio for hw ref 1.1 > > v4: > - change u8 lane-map to u32 data-lanes > > v3: > - squash lane-map over bifurcation property > - add comment which slot is M2 and which one if mPCIe > - fixes from Peter: > - drop regulator-always-on/regulator-boot-on from regulators > - increase startup-delay-us for regulators > - set phy-mode on PCIe3-phy > - add num-lanes to PCIe overrides > - add usb node for to PCIe/m2 > - move lane-map from PCIe controller to PCIe-phy > > v2: > - underscores in nodenames > - rockchip,bifurcation to vendor unspecific bifurcation > - fix trailing space > --- > .../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 117 ++++++++++++++++++ > 1 file changed, 117 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > index 93d383b8be87..40b90c052634 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts > @@ -86,6 +86,66 @@ vcc5v0_sys: vcc5v0-sys { > vin-supply = <&dc_12v>; > }; > > + pcie30_avdd0v9: pcie30-avdd0v9 { Use consistent naming, so if other nodes have "regulator" suffix, use it here as well. > + compatible = "regulator-fixed"; > + regulator-name = "pcie30_avdd0v9"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <900000>; > + vin-supply = <&vcc3v3_sys>; > + }; > + > + pcie30_avdd1v8: pcie30-avdd1v8 { Ditto. > + compatible = "regulator-fixed"; > + regulator-name = "pcie30_avdd1v8"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc3v3_sys>; > + }; > + > + /* pi6c pcie clock generator feeds both ports */ > + vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_pcie"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + enable-active-high; > + gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <200000>; > + vin-supply = <&vcc5v0_sys>; > + }; > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel