From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3508CC4363D for ; Fri, 25 Sep 2020 09:33:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A47C420678 for ; Fri, 25 Sep 2020 09:33:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KszbJQpD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="LSXChYe0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A47C420678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MTHyb/Yoc/JSmyDHJimRvpQhugidEIcooIeBqIA4v6I=; b=KszbJQpD/jfISWBMrlKngOsS7 YF6Tu4YK0pAaT4000Mds0LRzcnQY8yeC19ctkCgKcOezViVE52aSSucc72e1/l3vmPYzIvff5WsG7 L4Cl+pHkE0MlSClfqz/g9AwNnbDxVQOnPq9QrdJM80ghb0vzF3qLzi/lq6uMWSGaJ3VK2GdblB+me BSt24oCc2RbIfDUR0DxI0BPFqMjbALKPABr0/YICezTLRkgKHfF18dvA6JENtoahf2iLTES8p9thS qs2QP/7D/3wrMNzwvgqptBdYCmbX2Emj5WgtmF2uVhJv/PvZDB4oqQh3BwxU38/sc406svy2EI3d8 6ZMkdcGZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLk59-0005Gi-4Z; Fri, 25 Sep 2020 09:31:59 +0000 Received: from ssl.serverraum.org ([176.9.125.105]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLk55-0005FC-Rt for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 09:31:56 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 12DA622ED5; Fri, 25 Sep 2020 11:31:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1601026310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uLL/4PRlCphLUVIwMp3bEigo2LIKHqcXNDfV6nTtgZo=; b=LSXChYe0kWNHjGg7/AndycHtLLqVD7I0by/kWa6LC0RzaKZKCMBA76kPbpHy8Oppl2RVBc gUc+A+UtkJcSNamnHztPd6VrmQ2077GYyI1G5rKyKkBUr5alVlcS3L4Ij1EvVrtibBhwKY 9DcVdsGlqU5zhG2wvva0aFof3MNY+98= MIME-Version: 1.0 Date: Fri, 25 Sep 2020 11:31:50 +0200 From: Michael Walle To: Leo Li Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes In-Reply-To: References: <20200923095711.11355-1-michael@walle.cc> <20200923095711.11355-2-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_053156_004185_71BE84C6 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joakim Zhang , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, Rob Herring , Marc Kleine-Budde , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 2020-09-24 17:53, schrieb Leo Li: >> -----Original Message----- >> From: Michael Walle >> Sent: Thursday, September 24, 2020 6:31 AM >> To: Leo Li >> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; >> linux- >> kernel@vger.kernel.org; linux-can@vger.kernel.org; Shawn Guo >> ; Rob Herring ; Marc Kleine- >> Budde ; Joakim Zhang >> Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes >> >> Am 2020-09-24 02:35, schrieb Leo Li: >> >> -----Original Message----- >> >> From: Michael Walle >> >> Sent: Wednesday, September 23, 2020 4:57 AM >> >> To: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; >> >> linux- >> >> kernel@vger.kernel.org; linux-can@vger.kernel.org >> >> Cc: Shawn Guo ; Leo Li ; >> Rob >> >> Herring ; Marc Kleine-Budde >> ; >> >> Joakim Zhang ; Michael Walle >> >> >> >> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes >> >> >> >> The LS1028A has two FlexCAN controller. These are compatible with the >> >> ones >> >> from the LX2160A. Add the nodes. >> >> >> >> The first controller was tested on the Kontron sl28 board. >> >> >> >> Signed-off-by: Michael Walle >> >> --- >> >> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 >> >> ++++++++++++++++++ >> >> 1 file changed, 18 insertions(+) >> >> >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> index 0efeb8fa773e..807ee921ec12 100644 >> >> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> >> @@ -386,6 +386,24 @@ >> >> status = "disabled"; >> >> }; >> >> >> >> + can0: can@2180000 { >> >> + compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1- >> >> flexcan"; >> > >> > The explicit compatible strings cannot be found in the binding, but >> > matched by the "fsl,-flexcan" pattern in the binding. Is >> > this considered to be acceptable now? >> >> What is the consequence if it is not acceptable? replacing the pattern >> with individual compatible strings? > > There is a recommendation in the kernel documentation quoted below: > > 7) The wildcard "" may be used in compatible strings, as in > the following example: > > - compatible: Must contain '"nvidia,-pcie", > "nvidia,tegra20-pcie"' where is tegra30, tegra132, > ... > > As in the above example, the known values of "" should be > documented if it is used. > > But I am not sure if this is still a hard requirement. If so, we > should list the processors in the binding. Marc, I'd convert this to yaml format, may I put your name as the maintainer in the binding? -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel