From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59042C2B9F4 for ; Thu, 17 Jun 2021 09:59:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D71061410 for ; Thu, 17 Jun 2021 09:59:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D71061410 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8+xq4rHQQz4YHmY1suxlR+aWRN9a+I9jqDfFHWEtzxE=; b=WxDE+w+c8cEZObqGTszS5o7Zhz ePFugCA0Eo/9DAScnmv2wkW6hS2gc6xlr+WvgbsfWZnWkPU0XI0JCSZ8D7O+vfV0DNoW0sMjMCPXV AF1heK6Gvv696mBPEH1hxmVwiESl49AkQi2uSwScMtDQ+1TZUtNKgZzZkpSPl1GBnVXs2l+WkIpbb CzPnRriwkqFZVAyo+XrPQ09ivho717Pro7jXP6UuSLCRl2NuVMzGmzoMrRxllgA3U0cJLSwaELE4C hxEoQU14JZyBF4GEAOmOBPQAaEqnXaFbpUnOXW03puN7KEB6mPXIRYTa+KEvU8hz+XCpXuHYIL4Gy UMiegS+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltomJ-009kvA-PS; Thu, 17 Jun 2021 09:57:40 +0000 Received: from lb2-smtp-cloud8.xs4all.net ([194.109.24.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltomF-009ksR-DE for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 09:57:37 +0000 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud8.xs4all.net with ESMTPA id tom9l2lerhqlttomCl03mC; Thu, 17 Jun 2021 11:57:33 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1623923853; bh=mNLOxBASZ1Rj1Q0TCJlnQtfYaEmFKt0BCfAy0LhPKmM=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=X3Fqw3pUXTbnpQY0zLgjBH2dv22Uiwlmucwp0069twdAiX4EnNQfVRT5mNVOEDXu8 +CGFjB5/26tnLe+UokrbNVsaL9FQp8SxfCLA20/aZjPjpy3HcFfd/msRxF9dJRHzA5 8Lx9YFiY3/jxd8QqFV5V5LTczjtEP3UZSnBjGXoVrjxQVRc1hgYveHp5+Gk4H4Ai24 hoAD6XQMJHlBJ6rnQTAQC5nONwme634ivzc9RQbpkcOsZ7lPhxgEStktUxFcGLnb+A y/OBHoVeYxPv6kGT26PA4u1ikryeMH+Lss2PDOLuCOhV4zbtBEkJg0LVts/zmpw4Ne hPvUGsMJNNEjA== Subject: Re: [PATCH 3/7] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup To: dillon.minfei@gmail.com, mchehab@kernel.org, mchehab+huawei@kernel.org, ezequiel@collabora.com, gnurou@gmail.com, pihsun@chromium.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org Cc: patrice.chotard@foss.st.com, hugues.fruchet@foss.st.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <1621508727-24486-1-git-send-email-dillon.minfei@gmail.com> <1621508727-24486-4-git-send-email-dillon.minfei@gmail.com> From: Hans Verkuil Message-ID: Date: Thu, 17 Jun 2021 11:57:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <1621508727-24486-4-git-send-email-dillon.minfei@gmail.com> Content-Language: en-US X-CMAE-Envelope: MS4xfM4WVfO1x/QqHFAjsJ8BftwtBgjz6mLzYtrj42sOhjPILBFsr8uTR1/QInmrEYs6LtL65IyoLiqZF1Ze8j5tEXKulzVUXbtsQhrCONE4BhUw2qc9Lgy5 E/vjz1Za/62HatPFYewZMmgIsGNz2NWTuQDZF8xHiZekQmZ1/FrXgOD7YKYpWOvQdVJa90xFcEcEWqsMJNmbddPQMvoeFkS1rMi+QSYxpIY0twSnsbEon8Dm A4CNXM2fqNGK1uCA4WRFhM5CkxlaZIVZUXml+OrBHt/E9JrPoq8AIXd8Bwfoq8dxD4JH3Y2gHm83nQoiAA0k+lCEZp/bngfkiXRG2swQRoHByBZGqqhptVyq WwWCfsgXR8owQWYEV1bFMh8zAx3+ZKnjR3aiK2iVEFYxkZVhxsFXhbUDiTiiF77sIjY8cE/GVux2kuPcfs2T5uoqOeUBj6Ics0wpx1ToDxU7Ro7UoNVbo7iN yaC35coKnh40XhnPZTj5irJDniM9ehFAa4D6SB3aX3D85B4o1to2Pvz8+vyjTy0vbQzI4f6yf5GtA3tTaS+fFUMYoff/XIgnhic3Uhi2SUwkE2Hvfcb/eBFX IENsSsWz/qH7z7CbmYi6ciSEaup9bMcxSSjE2AcSrO6pzw8yvl5/h2QXHFq97WygBjhxElW5d0XwYxqTPL7Sr/TaP7jNH/lCmLTH3FPXFFdgGLGskip43Z4C fIJZ+fGKn6RbqmiOtB4aCN4va+pUn2CMW0YvNgYzMdzrELFaSl1hZiiHaV2B5NitLKIaruwD/AUzpPRoxycRJqDtvGNHNv++dwGkAA4zHHDbdtfYh0o0e5U8 n7Ykin3FHrCisDQPuL7Xpw3zHj4gLjRiSVVjkiQDLklxuA7TX2oJ7uJmYAhJcA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_025735_650625_04D89FCC X-CRM114-Status: GOOD ( 18.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/05/2021 13:05, dillon.minfei@gmail.com wrote: > From: Dillon Min > > stm32's clk driver register two ltdc gate clk to clk core by > clk_hw_register_gate() and clk_hw_register_composite() > > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver > > both of them point to the same offset of stm32's RCC register. after > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. > > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") > Signed-off-by: Dillon Min > Acked-by: Stephen Boyd > Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ For my understanding: this patch is going/has already gone in via a different subsystem, right? And I should skip it when adding this driver to the media subsystem? Regards, Hans > --- > > This patch was submitted in > https://lore.kernel.org/lkml/1620990152-19255-1-git-send-email-dillon.minfei@gmail.com/ > > drivers/clk/clk-stm32f4.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c > index 18117ce5ff85..b6ab8c3a7994 100644 > --- a/drivers/clk/clk-stm32f4.c > +++ b/drivers/clk/clk-stm32f4.c > @@ -211,7 +211,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = { > { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" }, > { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" }, > { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" }, > - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" }, > }; > > static const struct stm32f4_gate_data stm32f746_gates[] __initconst = { > @@ -557,13 +556,13 @@ static const struct clk_div_table post_divr_table[] = { > > #define MAX_POST_DIV 3 > static const struct stm32f4_pll_post_div_data post_div_data[MAX_POST_DIV] = { > - { CLK_I2SQ_PDIV, PLL_I2S, "plli2s-q-div", "plli2s-q", > + { CLK_I2SQ_PDIV, PLL_VCO_I2S, "plli2s-q-div", "plli2s-q", > CLK_SET_RATE_PARENT, STM32F4_RCC_DCKCFGR, 0, 5, 0, NULL}, > > - { CLK_SAIQ_PDIV, PLL_SAI, "pllsai-q-div", "pllsai-q", > + { CLK_SAIQ_PDIV, PLL_VCO_SAI, "pllsai-q-div", "pllsai-q", > CLK_SET_RATE_PARENT, STM32F4_RCC_DCKCFGR, 8, 5, 0, NULL }, > > - { NO_IDX, PLL_SAI, "pllsai-r-div", "pllsai-r", CLK_SET_RATE_PARENT, > + { NO_IDX, PLL_VCO_SAI, "pllsai-r-div", "pllsai-r", CLK_SET_RATE_PARENT, > STM32F4_RCC_DCKCFGR, 16, 2, 0, post_divr_table }, > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel