From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0327C43381 for ; Mon, 1 Apr 2019 12:46:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D261206B7 for ; Mon, 1 Apr 2019 12:46:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ccv7INF3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="rn5leY0C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D261206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=myMciIF2U0puOIufi60CuosFCIBZql/Yuoic6KPK1OU=; b=Ccv7INF33wcp4ZIyB4B7juY7O QHVsqww+6Jk9Kg9K2I3a020P2LoksLCqaJHK6wOgNhl8XJd68eWhEoc84TooGpA3peBiwMWwWB2d7 XH9vCT1j/2q46jWSgKvZT+UF2Yjpy/9g5hpj6r4zddnbmVP4ZO72o249jr33Z1+lRr0OHMtPn3iHs iX3sIJCIBa5Q6MEbCDmpmS4DlYyPuQS/JIFZsGcFfUFWiCKBUkv8eRNnqTRFO7814qNB15w0+6Gao SRsKn30fiWLIHifbzh8btUK0S2ue9Cr9IvoH8XPws0jCFJgHhgxc62sAyojUTjIpbddiWehFh+GWy FLjicF7zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAwKK-0006LM-4Q; Mon, 01 Apr 2019 12:46:12 +0000 Received: from hqemgate14.nvidia.com ([216.228.121.143]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAwKG-0006Kq-Aw for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 12:46:09 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 01 Apr 2019 05:46:11 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 01 Apr 2019 05:46:07 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 01 Apr 2019 05:46:07 -0700 Received: from [192.168.1.18] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Apr 2019 12:45:57 +0000 Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig To: Jisheng Zhang , Jon Hunter References: <1553613207-3988-1-git-send-email-vidyas@nvidia.com> <1553613207-3988-11-git-send-email-vidyas@nvidia.com> <44d7ff1d-c317-6ba2-86c0-981a6356ee9e@nvidia.com> <20190328161138.1b37d232@xhacker.debian> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: Date: Mon, 1 Apr 2019 18:15:54 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190328161138.1b37d232@xhacker.debian> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1554122771; bh=/banbzlPn4kQ4FAJWCLU9veT8yROk/uMQioS8iU7c4w=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=rn5leY0CavhJ6hchW7bFyGam8W3g5zDd6hfmyDmpDXwkGiruu6RBm1R/KKtB8iD/r 4LxF9LrbRZbyMw/78RGPalGyf8RiIIzVOvKe5QBS1eD6vvuxmzWwkYhgmZM3VyTriB TLCni/DqsZJB0wJ4LESveykfBaGL/0GGONC+JgNKrBgzkGc93Hfqoz8vlWmDt/xerA vvzuV6ZzbMgvkWHbsOs1JzgElL/SwmcPNnJXtSarAFrQDcLNNk4kCzeTAVX1FP2Ko+ CHulqV76aOaZ87W4lyhCVl6O9Gky9w1PvCUGqVReEkCJhnWnh+0tBVzNynFT+vhE4+ mKV9awDdbhOOw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_054608_391846_79E4C9EC X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "heiko@sntech.de" , "hayashi.kunihiko@socionext.com" , "tiwai@suse.de" , "catalin.marinas@arm.com" , "spujar@nvidia.com" , "will.deacon@arm.com" , "kthota@nvidia.com" , "mperttunen@nvidia.com" , "linux-tegra@vger.kernel.org" , "thierry.reding@gmail.com" , "stefan.wahren@i2se.com" , "lorenzo.pieralisi@arm.com" , "krzk@kernel.org" , "kishon@ti.com" , "maxime.ripard@bootlin.com" , "jagan@amarulasolutions.com" , "linux-pci@vger.kernel.org" , "andy.gross@linaro.org" , "shawn.lin@rock-chips.com" , "devicetree@vger.kernel.org" , "mmaddireddy@nvidia.com" , "marc.w.gonzalez@free.fr" , "liviu.dudau@arm.com" , "yue.wang@amlogic.com" , "enric.balletbo@collabora.com" , "robh+dt@kernel.org" , Bjorn Helgaas , "horms+renesas@verge.net.au" , "bjorn.andersson@linaro.org" , "ezequiel@collabora.com" , "linux-arm-kernel@lists.infradead.org" , "xiaowei.bao@nxp.com" , "jingoohan1@gmail.com" , "linux-kernel@vger.kernel.org" , "skomatineni@nvidia.com" , "gustavo.pimentel@synopsys.com" , "olof@lixom.net" , "tpiepho@impinj.com" , "l.stach@pengutronix.de" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/28/2019 1:49 PM, Jisheng Zhang wrote: > On Wed, 27 Mar 2019 12:26:49 +0000 Jon Hunter wrote: > >> >> >> On 27/03/2019 10:12, Vidya Sagar wrote: >>> On 3/27/2019 3:38 PM, Jon Hunter wrote: >>>> >>>> On 26/03/2019 15:13, Vidya Sagar wrote: >>>>> Add PCIe host controller driver for DesignWare core based >>>>> PCIe controller IP present in Tegra194. >>>>> >>>>> Signed-off-by: Vidya Sagar >>>>> --- >>>>> arch/arm64/configs/defconfig | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>> index 2d9c39033c1a..2ddea5c4e87d 100644 >>>>> --- a/arch/arm64/configs/defconfig >>>>> +++ b/arch/arm64/configs/defconfig >>>>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=y >>>>> CONFIG_PCIE_ARMADA_8K=y >>>>> CONFIG_PCIE_KIRIN=y >>>>> CONFIG_PCIE_HISI_STB=y >>>>> +CONFIG_PCIE_TEGRA194=y >>>>> CONFIG_ARM64_VA_BITS_48=y >>>>> CONFIG_SCHED_MC=y >>>>> CONFIG_NUMA=y >>>> >>>> Maybe building as a module is more appropriate here as I am not sure >>>> that anyone else will want this built-in and it is not critical to >>>> booting AFAIK. >>> Since the DesignWare core framework doesn't yet have support for making >>> this >>> as a module, I added it as a built-in driver. I'll switch it to a module >>> once support is available. >> >> Ah I see. We often get reports/patches if a driver has a removal >> function but is defined in the Kconfig to only support being built-in. >> >> Does the designware core just need to export some symbols to support it >> being a module? If so it maybe worth adding these as part of the series >> to see if it is acceptable, otherwise it might not get done and there is >> no point us supporting it as a module. > > After https://lkml.org/lkml/2019/3/18/363 > > we could implement the "remove" > > Thanks > Thanks Jisheng for the link. I'll verify my code with your patch set and update the result. @Jonathan, once Jisheng's patch set gets accepted, I'll make PCIE_TEGRA194 as a module. Thanks, Vidya Sagar _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel