From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95FB1C00144 for ; Mon, 1 Aug 2022 15:07:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4HNNXPnr1B+JHkFWCLulQQNo7TTWq72YiFzfPZLoNaw=; b=2Tt3sjggfoyHS4 MZHG4nCrnITBB5jUmjH8Ol69WPojnMfJAwZqoLIvuPH3s920E6e9ZsVzn5N7PgYGqkoPW25ONkteh g8O19YJ4DsMrn3+Km/Y0czzZ/hzhNFsnevaPjigrO5B88YwZBY7wUIXksu3m4KD+3AQpNMneB0VBY hqEHoSv+oPZNZvAZ8o22pmLshowga3B+XGURQiVaMPhb+cDn83tyqOx/tnYSy1qZAr3RsVMrkWdBe Ia9usTLsttF5cn0zQRBgNZhuHuH7LxBQye5Z02WHLvNuuzwZcy6NYbU0/eVt6h8GZJKKP32C8qaYM Z+IBn+XBVx8gIyb5GisA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIX09-007JZt-MF; Mon, 01 Aug 2022 15:06:37 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIX04-007JWo-O9 for linux-arm-kernel@lists.infradead.org; Mon, 01 Aug 2022 15:06:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1659366392; x=1690902392; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SiAxZQ5vOw9twLsqV6Zb16Pp4hAr59sc+3nDJzukkYw=; b=ug4bEvbZ9fdY2VpGF8IbZ5IcszGwjj0bqjTGjWg3nW49uD5kCLQmDqUW xho5iKJ5toKoQZKkbTRSSLPD9Dq1sVSQSKigtmhu4g2wAXIrViyJNBBBX 06R1+OGBICLAxK1+IbRD3oS/m6p5G/Hr52Y7bF+0TOD31rG5R/PuPgejp OuPQI9Uey/nzkvqDs4E6Bvz1cKlIBya8qNwvpmWVWrhMTYUr7EaQ0BXYT sVScU1kSIwq3kCE/BgRr/z5TU4p1zpZzvw3LJIY0XzI0B+KusO6W/rISr yg7sfkp4BidOa/giQcUoQWHOqD4vpVHZjTJXLMY50hG96+2eHDG0B2ATM g==; X-IronPort-AV: E=Sophos;i="5.93,208,1654585200"; d="scan'208";a="107043835" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Aug 2022 08:06:26 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 1 Aug 2022 08:06:26 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 1 Aug 2022 08:06:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtCctnQXFWphJyUBIIxuVxAA2qFYYnC0RzdjtJfyqdM6w9blOlyNfnQpCH/lYi7wHytGrTGHkiDIHTmWvkUmPOUbncR/qR5eevWDsWut1YpjTn3bGflKVCUONbtkfS/j0BPd+f8mc09BiA7nsWDx0VNgM2xe3R1jfgT24Cd4pDtFi24V+xna9TDcEq6xx25F05OD5lZb9azcRX8bLUrZ9kTHQ/8gNv1+digRkXemg6W0zYuDPIgJCwLsrGzVy9C92DMqa/t0hLP5Jhm/+1u/mKc35Tq3a3kO8T9evcyHTlEgGKkau2TYA0J6rWtmTdh9yiu/dhICxVExNLobPNktIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SiAxZQ5vOw9twLsqV6Zb16Pp4hAr59sc+3nDJzukkYw=; b=FvucWQnNyAwK3+L/WJUjLGpG0yjbPV9k/42/MQ6dbKMLWQZomowewEitqeAh6InrYc7WX90TWjOIlXWvrjq/QQOOg41efmsGgbBdDPqWHe9u5vUU7R47Ne0Z7kssJss6Ig4n3Gt7g0ggtgrm32dMvyFynmNk7xVKYxr9RTp21QSFQWurvzlz3Xb0KA1yoiGKnRsy17T38pc2c8FkixVt4BLhG44KXFAfsmeCqFnH/E9AZarKwlHtlFcBd7ewEJc1TyS8TMLDBrSdc/SzFdZCFrgvVlf//m8SIhocg2ja57bEnnijBLcY6BBTHhDV1VuqpWBO4R8a5/KOFjVzj3HBpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SiAxZQ5vOw9twLsqV6Zb16Pp4hAr59sc+3nDJzukkYw=; b=Z3OZkcb/lH7z1+hUoVhGO54yRMj7d/45hhVAaGM3FWhH77aGgJA3gdQ4BJwDX7PCml5n+hdvP4F7sZNuk0i9twYAMVcatPHM6FnUKFU7151LjYt13nBFQwlsXx4/KX1Xw1O+ypE1cP5XPp03gKHXffP8T2aZ7L/asLvlKpsPgic= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by DM4PR11MB6528.namprd11.prod.outlook.com (2603:10b6:8:8f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.16; Mon, 1 Aug 2022 15:06:24 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5c8c:c31f:454d:824c]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5c8c:c31f:454d:824c%8]) with mapi id 15.20.5482.016; Mon, 1 Aug 2022 15:06:23 +0000 From: To: Subject: Re: [PATCH v2 net-next 1/2] firmware: xilinx: add support for sd/gem config Thread-Topic: [PATCH v2 net-next 1/2] firmware: xilinx: add support for sd/gem config Thread-Index: AQHYpYz/w4ja8yXDQUmz9HznJF0suw== Date: Mon, 1 Aug 2022 15:06:23 +0000 Message-ID: References: <1659123350-10638-1-git-send-email-radhey.shyam.pandey@amd.com> <1659123350-10638-2-git-send-email-radhey.shyam.pandey@amd.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 292bd4ad-9952-4cbd-e95d-08da73cf664f x-ms-traffictypediagnostic: DM4PR11MB6528:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SHY9xzFEV4ztT4XGFmG3ev+ZZnEWBB8rZm03W2Bd73Q0NVoZbj8NnjP6Ny+TOJeFjYlmTMLu2CbbRIlwmuAI6Lv2i4HrgOxFjVTR6rbzkG2d3oy+XiZJ31FZvISUkki5XUc0cK18XHh3ahbRKis3DdEM798QQft+qj/feT4gQ2dXiiSncqUErYbMJglU4N4LpAkzX0coQgffaQ6uptn19xoPLCjvdWl2ZZey9ihQuQ8m4O20cFVv6f257bUp7lijOuUZPhILRNJ0mFNzdSTUzMzDJaQubpwTrtwf09T5R5nfjpbzzFC07so5sJ+5lbnIpWVoNGjoIxWEZM2cL5Zwy8A+wQByMVwNLyoSPJqytCJFGc6lnc2bg1tx+lzWm99XakmmVxmW8MQKLpG6LfnMPXb2jlFrVcHVMsINvbMqI/ArSRe831pvrERgaLyRW2kgQMosZolcUHwloW20SmhnjbM9Ky6pgJwKHnIhrSeyAEsFSKvo2huq2+NENpvIzH9fJb/9y9kO+LuqIM72+XQcEMMXyZjPmSB3MouwdG6qtLx7PWoE81p/Hute/oQobp7Kxeu0xOFFGUN521yi169Z6F1CgXsvoFVxmyRAqIR8jvBgLx+x2r9tbGeOcavbAdudUsK1ro7kHBENr3b1mcc2VHZ6znS61PiNc4cw4z3VXN48cXRgI7c1jcWF3jB3v03EZZV0/4YFAfDA6uTpr5OGL2lLY3rTQCDth8j+YE/3T4olj0mVztm7gILQ1b4JSFseNJsDjxdfIaV4c+9FSqHdMJfi4bj29W4K5PkI9aBV9oLAEBIKmv7Ux/3UzKeXzkLZqO9/X3jJioGzOJZamum6JTGT2x+Z+W/OVRS+zZPi17alF3aKy+Xo/QpemAAkMM3adsXBaAAWkNJG/Xxfg9RriA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(136003)(366004)(396003)(376002)(31696002)(31686004)(54906003)(38100700002)(83380400001)(71200400001)(2906002)(316002)(86362001)(6506007)(4326008)(2616005)(8676002)(36756003)(66556008)(76116006)(186003)(122000001)(6512007)(26005)(5660300002)(6862004)(41300700001)(64756008)(66476007)(66946007)(966005)(478600001)(6486002)(91956017)(53546011)(8936002)(38070700005)(7416002)(66446008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dytSWVBMNXhJZnRtOHJEL2JXSVlsUVpnS3dRNGQzSG5Nb2lka1ZiaVlSSDFa?= =?utf-8?B?aWE2MGJnRnphbmx4S3RvTnl5eVl3SEZ3MTRiWDVzMmJsWnpVUXhvVGsvL3hw?= =?utf-8?B?NzA5Qm95YkdKYlRwUllXNlpVRDVDb1Q1U0V1QWNJZHc1dkZaaTBFSGoyRnRQ?= =?utf-8?B?YWwvaktvNjk5cnZYOU5WSHNsc0EwWGU3SlpvaXI4dGh1ZElVRS80c1FpRTFi?= =?utf-8?B?aXZLbDlhZnhGQklkTDB3S0FrR013OFdFTXdTaDFoQ2RxbnhZa1VLcmpDQi9J?= =?utf-8?B?WGNiaTl2T093SEZDZVJ5TFAxOVp5Mm5VYzZrNjYvRUxIMnpwcThIUW1KYUEz?= =?utf-8?B?YjQ5UmY3MlhjSkRmMk5na05pKzQyZThLM280MlZkR3ZnbkN5bUwvdkRaRkxt?= =?utf-8?B?emdoQzd6RW85VEptdXEwcS92RVRzcmFnTk1YQldjcUpOMVpQRGp0cm1ISzNU?= =?utf-8?B?NWpienUxMTF0SDZCM24rVWgvY09DbHZWV3lXdld5Z1FqQlZUNUR4cEVXZzF6?= =?utf-8?B?a2RKa3U5djgyb252NEpmbENadTZPN0puTmhjRFZsM1FDZnhwYS9JQUt1aitp?= =?utf-8?B?bG8rb1pwREFIK3JFeWdRNnAxRkxaSlY3cUJxMm1OZGswUzdPZG9PMWJuSFpB?= =?utf-8?B?SnloQUE1TXY4WTN1Ny9MZjdRQlZzRitoemZtZWMxQW1QbkdyMGJCd1NPOGJ3?= =?utf-8?B?NnpGajhnR1lVbXg0a3hxOGlENVppWE5YWG9VVmNEeUxQSEFwWEs1YS9NWjRC?= =?utf-8?B?bTFlYWhYM2pkZ1BEWGNIWU9rNTFMK0JvbkdFN3p0MEF6dDFXUUMvZzFOcy9G?= =?utf-8?B?OXBrOUI4L2M5OCsrWFE2NFlzNFVKaDBTS0x1UjlTSkVMUjE2UlFUYi9YdUw4?= =?utf-8?B?ZGcwTWd3d3RSOFpVSXNhOGlPd295TDhyRVpqOWI3SlcwZ25lZjdWdUhDSTdO?= =?utf-8?B?djM4RGJSUXFzd2prN3k3WTVYTlJHTStreEVxQ0czczNxdGR4ZzVYRDB2NU5h?= =?utf-8?B?cDVwTmlLVzlUdkEzNXJOZG8wTVZucjBuSzJHWnlDV2hxTnJ3Q1h0N2VTTENN?= =?utf-8?B?dmtoRmpvVTZqRlI1VXc0U1laRmVpbnpHSTRaQ3ZKNHZjTmUvbFZwc0VjZE5u?= =?utf-8?B?WGoxNGxlSkYvaE9CMXpxOERLSHBPQVp1c3JWNS8xRFNtVnJydHRaMDUzYXVN?= =?utf-8?B?ZEpGR0J0emdkb2lYbFluVEc0UWdaMTV5Zk9aRnFheFhWS2RkQ2pFeGxORE5h?= =?utf-8?B?YkRmSVpKbVYyS3R4N3FJL1IyRWZjcHppcHFRS0JmekE4YnBPS01QTk91SjVp?= =?utf-8?B?MlVxOEw4WlBGTHc5MDN1akxOR2VLcHRrUGVJZnE4Qzd1K1BQeTFZVWpYaExk?= =?utf-8?B?VWk1WU01VGVlR3FLbFJ1b3lsZUJpOVp0OWp1UFJQMk9QdGpRU092MmtKbXFZ?= =?utf-8?B?NlZHRUZiN01LYXlTU0dJdCtab1lIQ3JoTEtQbkJHMzd0dVZCRVhNSzM1b1dE?= =?utf-8?B?ejdMMmNUWDdVWXcyUjNrb0NYT3hBWllOM3ZZZk8wTy9NK3NQQURVSC9uUVFl?= =?utf-8?B?blN3UDhGZHNUbjdieTdxVjBQQkZQanhEa0hudUFyR291ZTdxUk9vb2VLMzVl?= =?utf-8?B?citMM1IyckovdUV2UG8yUjhtS241Y2NLYy9FUzBCaFRoVytabG1ZcG94L2dF?= =?utf-8?B?LzAybU9vaFZuUTFHWFFGeVJvcW9lYXZYVUVhb0V4eWEveWR4Zy9Bazhhemtl?= =?utf-8?B?SDRzRDcyUm5nU1ZDMDUvLy9FSnRPbUhqdFBIamtnaEZEb2hxRGIrMEpWSE0v?= =?utf-8?B?SldnU25adUpQOWMyZzkybEtERHN0NVNtYzVMWjZyRFpveHF2cXFwUnZoeDR4?= =?utf-8?B?ODh0d3pLRWw3bjRIYnAzUVB6a1dzaFhka2Q2c1VvcWlMWkF6NFBqL1l6T0ZU?= =?utf-8?B?R05FQ0s5Yy9SQmcvQVo5QlhpNVdPby9HdDZOV1hEWmVadFU4SVMxQmlJZVNN?= =?utf-8?B?YWt3YkQrNy9SU0pwdlNSdHV6TStNSzNpZ2lLRTlHZ3JMa1lpZjZock5HODlu?= =?utf-8?B?NTc5Z2FqS0NwYXBiL2c1cVBEN0FoUWJIZUZMVmllT3I0OVdvNEpLZWRabXFM?= =?utf-8?B?VmpwMFVmLzZJNEhEWmlOaHl1QjRSM1BjdEtwek9rQjl0S0YranoyWmpvSUZH?= =?utf-8?B?Znc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 292bd4ad-9952-4cbd-e95d-08da73cf664f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 15:06:23.7815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cwUHOlkVsy6B8Q9yRTZ2e0IS6mE98rh153ul6lbWvE4MGlBeIDiSKvMZdjEWjE5yd6269H6cWsSZZdsn2czjcWUWILBhz7AoHZqqvOeimzg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6528 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_080633_323461_869F1B10 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: git@amd.com, michal.simek@xilinx.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, ronak.jain@xilinx.com, git@xilinx.com, gregkh@linuxfoundation.org, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01.08.2022 15:52, Pandey, Radhey Shyam wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> -----Original Message----- >> From: Claudiu.Beznea@microchip.com >> Sent: Monday, August 1, 2022 3:27 PM >> To: Pandey, Radhey Shyam ; >> michal.simek@xilinx.com; Nicolas.Ferre@microchip.com; >> davem@davemloft.net; edumazet@google.com; kuba@kernel.org; >> pabeni@redhat.com; gregkh@linuxfoundation.org >> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >> netdev@vger.kernel.org; git (AMD-Xilinx) ; git@xilinx.com; >> ronak.jain@xilinx.com >> Subject: Re: [PATCH v2 net-next 1/2] firmware: xilinx: add support for >> sd/gem config >> >> On 29.07.2022 22:35, Radhey Shyam Pandey wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>> the content is safe >>> >>> From: Ronak Jain >>> >>> Add new APIs in firmware to configure SD/GEM registers. Internally it >>> calls PM IOCTL for below SD/GEM register configuration: >>> - SD/EMMC select >>> - SD slot type >>> - SD base clock >>> - SD 8 bit support >>> - SD fixed config >>> - GEM SGMII Mode >>> - GEM fixed config >>> >>> Signed-off-by: Ronak Jain >>> Signed-off-by: Radhey Shyam Pandey >>> --- >>> Changes for v2: >>> - Use tab indent for zynqmp_pm_set_sd/gem_config return >> documentation. >>> --- >>> drivers/firmware/xilinx/zynqmp.c | 31 >> +++++++++++++++++++++++++++++++ >>> include/linux/firmware/xlnx-zynqmp.h | 33 >>> +++++++++++++++++++++++++++++++++ >>> 2 files changed, 64 insertions(+) >>> >>> diff --git a/drivers/firmware/xilinx/zynqmp.c >>> b/drivers/firmware/xilinx/zynqmp.c >>> index 7977a494a651..44c44077dfc5 100644 >>> --- a/drivers/firmware/xilinx/zynqmp.c >>> +++ b/drivers/firmware/xilinx/zynqmp.c >>> @@ -1298,6 +1298,37 @@ int zynqmp_pm_get_feature_config(enum >>> pm_feature_config_id id, } >>> >>> /** >>> + * zynqmp_pm_set_sd_config - PM call to set value of SD config registers >>> + * @node: SD node ID >>> + * @config: The config type of SD registers >>> + * @value: Value to be set >>> + * >>> + * Return: Returns 0 on success or error value on failure. >>> + */ >>> +int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type >> config, >>> +u32 value) { >>> + return zynqmp_pm_invoke_fn(PM_IOCTL, node, >> IOCTL_SET_SD_CONFIG, >>> + config, value, NULL); } >>> +EXPORT_SYMBOL_GPL(zynqmp_pm_set_sd_config); >>> + >>> +/** >>> + * zynqmp_pm_set_gem_config - PM call to set value of GEM config >> registers >>> + * @node: GEM node ID >>> + * @config: The config type of GEM registers >>> + * @value: Value to be set >>> + * >>> + * Return: Returns 0 on success or error value on failure. >>> + */ >>> +int zynqmp_pm_set_gem_config(u32 node, enum pm_gem_config_type >> config, >>> + u32 value) { >>> + return zynqmp_pm_invoke_fn(PM_IOCTL, node, >> IOCTL_SET_GEM_CONFIG, >>> + config, value, NULL); } >>> +EXPORT_SYMBOL_GPL(zynqmp_pm_set_gem_config); >>> + >>> +/** >>> * struct zynqmp_pm_shutdown_scope - Struct for shutdown scope >>> * @subtype: Shutdown subtype >>> * @name: Matching string for scope argument >>> diff --git a/include/linux/firmware/xlnx-zynqmp.h >>> b/include/linux/firmware/xlnx-zynqmp.h >>> index 1ec73d5352c3..063a93c133f1 100644 >>> --- a/include/linux/firmware/xlnx-zynqmp.h >>> +++ b/include/linux/firmware/xlnx-zynqmp.h >>> @@ -152,6 +152,9 @@ enum pm_ioctl_id { >>> /* Runtime feature configuration */ >>> IOCTL_SET_FEATURE_CONFIG = 26, >>> IOCTL_GET_FEATURE_CONFIG = 27, >>> + /* Dynamic SD/GEM configuration */ >>> + IOCTL_SET_SD_CONFIG = 30, >>> + IOCTL_SET_GEM_CONFIG = 31, >>> }; >>> >>> enum pm_query_id { >>> @@ -393,6 +396,18 @@ enum pm_feature_config_id { >>> PM_FEATURE_EXTWDT_VALUE = 4, >>> }; >>> >>> +enum pm_sd_config_type { >>> + SD_CONFIG_EMMC_SEL = 1, /* To set SD_EMMC_SEL in CTRL_REG_SD >> and SD_SLOTTYPE */ >>> + SD_CONFIG_BASECLK = 2, /* To set SD_BASECLK in SD_CONFIG_REG1 >> */ >>> + SD_CONFIG_8BIT = 3, /* To set SD_8BIT in SD_CONFIG_REG2 */ >>> + SD_CONFIG_FIXED = 4, /* To set fixed config registers */ }; >>> + >>> +enum pm_gem_config_type { >>> + GEM_CONFIG_SGMII_MODE = 1, /* To set GEM_SGMII_MODE in >> GEM_CLK_CTRL register */ >>> + GEM_CONFIG_FIXED = 2, /* To set fixed config registers */ }; >> >> As you adapted kernel style documentation for the rest of code added in this >> patch you can follow this rules for enums, too. > > Which particular style issue you are mentioning here? I'm talking about: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/doc-guide/kernel-doc.rst#n169 There is a tab > before GEM_CONFIG_* enum member and also checkpatch --strict > report no issues. You have this for functions: +/** + * zynqmp_pm_set_gem_config - PM call to set value of GEM config registers + * @node: GEM node ID + * @config: The config type of GEM registers + * @value: Value to be set + * + * Return: Returns 0 on success or error value on failure. + */ And some structures in the file are using it, e.g.: /** * struct zynqmp_pm_query_data - PM query data * @qid: query ID * @arg1: Argument 1 of query data * @arg2: Argument 2 of query data * @arg3: Argument 3 of query data */ > >> >>> + >>> /** >>> * struct zynqmp_pm_query_data - PM query data >>> * @qid: query ID >>> @@ -468,6 +483,9 @@ int zynqmp_pm_feature(const u32 api_id); int >>> zynqmp_pm_is_function_supported(const u32 api_id, const u32 id); int >>> zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 >> value); >>> int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, u32 >>> *payload); >>> +int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type >> config, >>> +u32 value); int zynqmp_pm_set_gem_config(u32 node, enum >> pm_gem_config_type config, >>> + u32 value); >>> #else >>> static inline int zynqmp_pm_get_api_version(u32 *version) { @@ >>> -733,6 +751,21 @@ static inline int zynqmp_pm_get_feature_config(enum >>> pm_feature_config_id id, { >>> return -ENODEV; >>> } >>> + >>> +static inline int zynqmp_pm_set_sd_config(u32 node, >>> + enum pm_sd_config_type config, >>> + u32 value) { >>> + return -ENODEV; >>> +} >>> + >>> +static inline int zynqmp_pm_set_gem_config(u32 node, >>> + enum pm_gem_config_type config, >>> + u32 value) { >>> + return -ENODEV; >>> +} >>> + >>> #endif >>> >>> #endif /* __FIRMWARE_ZYNQMP_H__ */ >>> -- >>> 2.1.1 >>> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel