From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70630C433DB for ; Fri, 5 Mar 2021 10:32:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8DA764F52 for ; Fri, 5 Mar 2021 10:32:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8DA764F52 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0bABRLk+kN3tAonBLrBMRwbPcGerLfRJTqcREvi1bzg=; b=WHn6/4nMDkVCjrlEGebsQeB8h HUEvci+JZI0UDnFRfRaCIYFDVmT1BKyvGjACvgWKpy/DjlsXsfpNttJLlZxOfQJZ26U3Fd5tlmTKe JUg2ydP4Gu++F0o2vJ5dmA9UntnJPkJEXk6rcL5WsNSDTx14kj06yemQEuikiOUZmkr4BmgI2o6Hi 3HnyszfH6QdkdrU31r0deeYPgq/5yH+ZYiLnsO+s5tAog1YpSu7fEvfYhyGUgO5jU3YA4ohN2vF7o zklrHGgamR7aMPykWzwNTyzJ2p+m/10vHSMyV2k8ty89Ko3GlDD9kK0b1i50IDgRCf6idfuP62924 MEMjzhn+A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI7jK-00EZV6-41; Fri, 05 Mar 2021 10:30:48 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI7j6-00EZRI-7B for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:30:36 +0000 Received: from mail-wr1-f69.google.com ([209.85.221.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI7j4-0007Bt-VK for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:30:31 +0000 Received: by mail-wr1-f69.google.com with SMTP id p15so855171wre.13 for ; Fri, 05 Mar 2021 02:30:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kJu6iNTkK4wSmf0pqRfj82yyDdC0OqRkZT1hSBnQXr8=; b=NwfWAT1KqNOeULDkMLRlZWRAj+RPBaJ6pa6Ky0J0teN+NEeLtVPVxqyw+pp0+O0gos MpvYO7TWfHATZj906u3rubYJwNPRUlpwjr2o/rqu7RhJYgvOP3VUE4fjQ8b43rjixQWK l/ut/Ok6w24E55C1K8x1rBQ7zl9izqyFBXQehEU1nQSOj6lyhLH49BX4Gv80KaqQ0CFb w2FfoTXVC0f2ITea1SWP3xn6pVS+of7oCno+BOZ8p5MlwgVFiqcc15BdsPJ43fc5pEXt 1vdfMEG2WRRj1UbxcH3076B5xin7vfdwqNs2j+YVN3CtcNdCtdJrq9CDBgArmjFi6R2v Vhxw== X-Gm-Message-State: AOAM5314jHeouTZDHkKxWBnigEA/XKzO/8NX440J7iAxvB68J6H5E8g8 aXPsWc4ayIoR10myRBCrZ+NXGrUxi7NFqWeFZFxZkIPiukVkKEFNfrqIwBBebHDRPgGRNywVSDN xlGmqM2OCMqcys+EASfPV0hkr9Z/lL0LQN2OiaWilYboyWPaLNOjr X-Received: by 2002:a1c:7714:: with SMTP id t20mr7981733wmi.107.1614940230674; Fri, 05 Mar 2021 02:30:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJy800OFDrvV/rynegL9gdp5sOoCnfFTAFviFAiUlwZkphbdPaIzFS7W/py4nWV80SKpjFhzmQ== X-Received: by 2002:a1c:7714:: with SMTP id t20mr7981727wmi.107.1614940230567; Fri, 05 Mar 2021 02:30:30 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id 1sm3878530wmj.2.2021.03.05.02.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:30:30 -0800 (PST) Subject: Re: [RFT PATCH v3 18/27] tty: serial: samsung_tty: Separate S3C64XX ops structure To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-19-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Fri, 5 Mar 2021 11:30:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-19-marcan@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_103034_472858_D0D67E79 X-CRM114-Status: GOOD ( 17.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 22:38, Hector Martin wrote: > Instead of patching a single global ops structure depending on the port > type, use a separate s3c64xx_serial_ops for the S3C64XX type. This > allows us to mark the structures as const. > > Also split out s3c64xx_serial_shutdown into a separate function now that > we have a separate ops structure; this avoids excessive branching > control flow and mirrors s3c64xx_serial_startup. tx_claimed and > rx_claimed are only used in the S3C24XX functions. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/samsung_tty.c | 71 ++++++++++++++++++++++++-------- > 1 file changed, 54 insertions(+), 17 deletions(-) Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel