From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36FC3C433F5 for ; Mon, 18 Oct 2021 05:53:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB72260F48 for ; Mon, 18 Oct 2021 05:53:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB72260F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+gmr/1HC+iuU59INNnvNbuWkhMORQi5QQRoyJCJhO08=; b=dtgidUgV2wjWe6 xgCKN6wm67lkpfjmEa3F+voozta0M+hnMurATaRu5XUklDaZ8OyMq5qcebGZEmmkJdpWmVWrZRyxx e7rBEfTJ6fYSqpj+RvcHOIHD7R3SayJ1dwYzfMsvBC3Z1iyntBFoeNxrnZa0CemKKUHSliQs58a90 4KcjN8vEURiAT0m5rAzQ1WkP+LwJY+JfsCA8k7y+5sL7V7ofCNLmjjY/Hv6e1PPIQhX6GJdmxqJYn IEunQKSULF4kuhCGwx/6xd6BAg7AdFDQIXGA5f+lpFArHT2JY6bPGgZfdz96EW8wJqNgBReiRGjg2 yxS7YvslG9e82jnAyCEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcLYT-00EFL4-5c; Mon, 18 Oct 2021 05:51:25 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcLYP-00EFJl-2w; Mon, 18 Oct 2021 05:51:22 +0000 X-UUID: 18cbed4f62454b859ce37fd98fb364d0-20211017 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=yhPKT9JGcSipzpZ8293RvuLYovwLEGKCOAUKtozO6rM=; b=VDCSu8XB3AaWZycbk/rWljazyBCTNTGis4tbhe2qUyo1TelDUi+koYGMAfhdsFMqcgNE0+r1cRyaMpYvJOSP1jtL+sfSltce46EzVB2xVDkk1KxvOH1oS1uU7x5R8XAsxUF6MVKRVK9l4qYlUt40Rx6bg+xoSrZh8dEgtROQyGE=; X-UUID: 18cbed4f62454b859ce37fd98fb364d0-20211017 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 406945976; Sun, 17 Oct 2021 22:51:16 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 17 Oct 2021 22:51:14 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 18 Oct 2021 13:51:13 +0800 Received: from mszswglt01 (10.16.20.20) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 18 Oct 2021 13:51:12 +0800 Message-ID: Subject: Re: [PATCH] dma-buf: Add support for mapping buffers with DMA attributes From: Guangming.Cao To: Daniel Vetter CC: Sumit Semwal , Benjamin Gaignard , Liam Mark , "Laura Abbott" , Brian Starkey , "John Stultz" , Christian =?ISO-8859-1?Q?K=F6nig?= , Matthias Brugger , "open list:DMA-BUF HEAPS FRAMEWORK" , "open list:DMA-BUF HEAPS FRAMEWORK" , "moderated list:DMA-BUF HEAPS FRAMEWORK" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , , , , Date: Mon, 18 Oct 2021 13:51:15 +0800 In-Reply-To: References: <20210830023911.4410-1-guangming.cao@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211017_225121_162502_3DBDAC65 X-CRM114-Status: GOOD ( 32.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-08-31 at 14:47 +0200, Daniel Vetter wrote: > On Mon, Aug 30, 2021 at 10:39:11AM +0800, guangming.cao@mediatek.com > wrote: > > From: Guangming Cao > > > > When mapping the memory represented by a dma-buf into a device's > > address space, it might be desireable to map the memory with > > certain DMA attributes. Thus, introduce the dma_mapping_attrs > > field in the dma_buf_attachment structure so that when > > the memory is mapped with dma_buf_map_attachment, it is mapped > > with the desired DMA attributes. > > > > Signed-off-by: Isaac J. Manjarres > > Signed-off-by: Sandeep Patil > > Signed-off-by: Guangming Cao > > Can you pls include the code that's going to use this here too? > > At a glance all the attributes you might want to set are supposed to > be > under the control of the exporter, not the importer. > -Daniel > Hi Daniel, Sorry for late. Currently I couldn't upload the coding going to use this part because of some miscellaneous reasons. Just as I said in commit message, for dma_heap, users can't skip cache sync or other opetrations when map iova[dma_buf_map_attachment] by fill (struct dma_buf_attachment).dma_map_attrs, it's not dma_map_attrs expected(link: https://github.com/torvalds/linux/blob/master/Documentation/core-api/dma-attributes.rst#dma_attr_skip_cpu_sync ). Correspondingly, if they use dma_buf to map iova[dma_buf_map_attrs], they will not meet this issue. So, I think it's a design flaw for dma_heap. BRs! Guangming > > --- > > drivers/dma-buf/heaps/cma_heap.c | 6 ++++-- > > drivers/dma-buf/heaps/system_heap.c | 6 ++++-- > > include/linux/dma-buf.h | 3 +++ > > 3 files changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma- > > buf/heaps/cma_heap.c > > index 0c05b79870f9..2c9feb3bfc3e 100644 > > --- a/drivers/dma-buf/heaps/cma_heap.c > > +++ b/drivers/dma-buf/heaps/cma_heap.c > > @@ -99,9 +99,10 @@ static struct sg_table > > *cma_heap_map_dma_buf(struct dma_buf_attachment *attachme > > { > > struct dma_heap_attachment *a = attachment->priv; > > struct sg_table *table = &a->table; > > + int attrs = attachment->dma_map_attrs; > > int ret; > > > > - ret = dma_map_sgtable(attachment->dev, table, direction, 0); > > + ret = dma_map_sgtable(attachment->dev, table, direction, > > attrs); > > if (ret) > > return ERR_PTR(-ENOMEM); > > a->mapped = true; > > @@ -113,9 +114,10 @@ static void cma_heap_unmap_dma_buf(struct > > dma_buf_attachment *attachment, > > enum dma_data_direction direction) > > { > > struct dma_heap_attachment *a = attachment->priv; > > + int attrs = attachment->dma_map_attrs; > > > > a->mapped = false; > > - dma_unmap_sgtable(attachment->dev, table, direction, 0); > > + dma_unmap_sgtable(attachment->dev, table, direction, attrs); > > } > > > > static int cma_heap_dma_buf_begin_cpu_access(struct dma_buf > > *dmabuf, > > diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma- > > buf/heaps/system_heap.c > > index 23a7e74ef966..fc7b1e02988e 100644 > > --- a/drivers/dma-buf/heaps/system_heap.c > > +++ b/drivers/dma-buf/heaps/system_heap.c > > @@ -130,9 +130,10 @@ static struct sg_table > > *system_heap_map_dma_buf(struct dma_buf_attachment *attac > > { > > struct dma_heap_attachment *a = attachment->priv; > > struct sg_table *table = a->table; > > + int attrs = attachment->dma_map_attrs; > > int ret; > > > > - ret = dma_map_sgtable(attachment->dev, table, direction, 0); > > + ret = dma_map_sgtable(attachment->dev, table, direction, > > attrs); > > if (ret) > > return ERR_PTR(ret); > > > > @@ -145,9 +146,10 @@ static void system_heap_unmap_dma_buf(struct > > dma_buf_attachment *attachment, > > enum dma_data_direction > > direction) > > { > > struct dma_heap_attachment *a = attachment->priv; > > + int attrs = attachment->dma_map_attrs; > > > > a->mapped = false; > > - dma_unmap_sgtable(attachment->dev, table, direction, 0); > > + dma_unmap_sgtable(attachment->dev, table, direction, attrs); > > } > > > > static int system_heap_dma_buf_begin_cpu_access(struct dma_buf > > *dmabuf, > > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > > index efdc56b9d95f..4d650731766e 100644 > > --- a/include/linux/dma-buf.h > > +++ b/include/linux/dma-buf.h > > @@ -379,6 +379,8 @@ struct dma_buf_attach_ops { > > * @importer_ops: importer operations for this attachment, if > > provided > > * dma_buf_map/unmap_attachment() must be called with the dma_resv > > lock held. > > * @importer_priv: importer specific attachment data. > > + * @dma_map_attrs: DMA attributes to be used when the exporter > > maps the buffer > > + * through dma_buf_map_attachment. > > * > > * This structure holds the attachment information between the > > dma_buf buffer > > * and its user device(s). The list contains one attachment struct > > per device > > @@ -399,6 +401,7 @@ struct dma_buf_attachment { > > const struct dma_buf_attach_ops *importer_ops; > > void *importer_priv; > > void *priv; > > + unsigned long dma_map_attrs; > > }; > > > > /** > > -- > > 2.17.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel