From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20809C433DB for ; Mon, 22 Mar 2021 08:01:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8409B601FA for ; Mon, 22 Mar 2021 08:01:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8409B601FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pvKzjNN8CDSYJBjbA0/eAzuFuQEMQWV+/FTXzKuX7XM=; b=U9cKXTjBeeLdkPTHu/MCWUjE5 SB1AckvRF9sF1BljhGUEAYso5VfcZNPdcEeHCAGkGJIqEIafCfxdYBGhk9uogADQXzbk85z5q27CW 0kr3GMObWNrG5yquH5zSxXHYJKXAKCtEk+dmbxZ0sA6zol2LHvgmmGY8Kv6/zrxbnapP6ju+P7uoU 8hMzRM2hJaAIO3zmxWLi5j499lyoc2lI7pW9MFYV1DOoKPQI5xQC+IEu2QI++iq9AzPMJw86xHntM F+RzDkwqU1IgIkXP52yCLOTDsKa1kTL4et1b9yimW6H9PbhdhF1RI8VLYQdQyGH7Ltl8F3piotaUR QHux+gcUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOFTi-00B7dp-54; Mon, 22 Mar 2021 07:59:58 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOFTa-00B7cc-49 for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 07:59:53 +0000 Received: from [192.168.0.114] (unknown [49.207.199.95]) by linux.microsoft.com (Postfix) with ESMTPSA id AA61920B5680; Mon, 22 Mar 2021 00:59:43 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AA61920B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616399986; bh=qmuAsbc1u2WB88iRPhSwaVj6CjbmseXJCuXVFQ8QZpg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=p9KpG2ksc/qSx9hiDockcv4LQgJIpQZvBk9roB/E3wKvqaa+raY8MnJBmRtuSRQRG 4HseaVU/Cxf8JZ8ozFpiTetVljcsY3Qylhz9A0qwq+zL9T++cocS23W+QAmCQ3l4ew 4ARO+a4pHwBr9gq01jgr3iU+8wHsBo5zemzcpFC4= Subject: Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot To: Jens Wiklander Cc: Allen Pais , zajec5@gmail.com, bcm-kernel-feedback-list@broadcom.com, Linux ARM , Linux Kernel Mailing List , OP-TEE TrustedFirmware References: <20210225090610.242623-1-allen.lkml@gmail.com> <20210225090610.242623-2-allen.lkml@gmail.com> <9a6c017c-d156-f939-f907-d6dfe83c41ac@linux.microsoft.com> From: Allen Pais Message-ID: Date: Mon, 22 Mar 2021 13:29:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_075950_964111_BA458A54 X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >>>> >>>> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed >>>> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 >>>> >>>> tee_shm_release() is not invoked on dma shm buffer. >>>> >>>> Implement .shutdown() method to handle the release of the buffers >>>> correctly. >>>> >>>> More info: >>>> https://github.com/OP-TEE/optee_os/issues/3637 >>>> >>>> Signed-off-by: Allen Pais >>>> --- >>>> drivers/tee/optee/core.c | 20 ++++++++++++++++++++ >>>> 1 file changed, 20 insertions(+) >>> >>> This looks good to me. Do you have a practical way of testing this on >>> QEMU for instance? >>> >> >> Jens, >> >> I could not reproduce nor create a setup using QEMU, I could only >> do it on a real h/w. >> >> I have extensively tested the fix and I don't see any issues. > > I did a few test runs too, seems OK. Thank you very much. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel