From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2141C6FD1D for ; Wed, 15 Mar 2023 12:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OWN69V7J2/FptBjbOxYytcpnTKNyrDfBsmSEDTySpTg=; b=0kSfZ6rx4umWwN KoxFataUVZ1T52r7CQ5fs3d9lsdOdsnv23734T/KTtUCcu9Z8gGNfO0yweXxQLuQbPDUlqlYc8hO2 MPgQ0q4KDAB8tIplxbKJr0sWLL5CQaiD7T3zdHiWwzbPcWS1GEIdh+FULlDZhe8jRCrv29pftA45M VGGm9G3d/xcbm/aIliDiqMkSN7Dc16yIWYTnbcNLJZqLSnvOHxzaWmsx312Lw5+ddq1iyWUnG3e+y 3MIV5zFoaGAG17JVnWE3TnJiGoMZC+OcMcAbeCLs29++4XHRTihHga7s6aSnYzF/KKmSEyloN/xY5 xjKVBfui6MEE7O4Y9OVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcQ9G-00DKFC-2i; Wed, 15 Mar 2023 12:22:30 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcQ9D-00DKEt-1W for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 12:22:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D8833B81E02; Wed, 15 Mar 2023 12:22:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C3ABC4339B; Wed, 15 Mar 2023 12:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678882944; bh=4GJSSVGMwZD38/Ejk6Cy5qgk/cy1eMuVjzNzpQ7gzOs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TsonW231iv0jJ+vihZdxLLaHHQHIIr77MPaTTDEFCRVthe9u2jV6VIb7oTKZdtJSG RA2WhLyTjGB2NuBTVoYl/VXcOBKWf7gdd1zONoSJf7y7glKaLbP0yoogvZiw8VzsLe IR9UiUWOBRMNLLU2/GAlV/IQECXHinZcaNK9EohcRhLETsuCR/NM8tsoYcizPoaVhu Veg1JTp6tFYPRDRafKnGRlQBhA61WLHcrD691moWlnaBR/2OaChI1Ms95XGwcG+wqh aFu5ykoDA9DqXRPm9AJQx1SOWqGLHoZiv2yTotXOxmV/1hGKXkL4j79DxhAD9YArHn Bdf3J+r8ZnuwQ== Message-ID: Date: Wed, 15 Mar 2023 14:22:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Content-Language: en-US To: MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> From: Roger Quadros In-Reply-To: <20230313111127.1229187-5-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_052227_809208_BECF4490 X-CRM114-Status: GOOD ( 25.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/03/2023 13:11, MD Danish Anwar wrote: > From: Suman Anna > > The PRUSS CFG module is represented as a syscon node and is currently > managed by the PRUSS platform driver. Add easy accessor functions to set > GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable > to enable the PRUSS Ethernet usecase. These functions reuse the generic > pruss_cfg_update() API function. > > Signed-off-by: Suman Anna > Co-developed-by: Grzegorz Jaszczyk > Signed-off-by: Grzegorz Jaszczyk > Signed-off-by: Puranjay Mohan > Signed-off-by: MD Danish Anwar > --- > drivers/soc/ti/pruss.c | 60 ++++++++++++++++++++++++++++++++ > include/linux/remoteproc/pruss.h | 22 ++++++++++++ > 2 files changed, 82 insertions(+) > > diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c > index 26d8129b515c..2f04b7922ddb 100644 > --- a/drivers/soc/ti/pruss.c > +++ b/drivers/soc/ti/pruss.c > @@ -203,6 +203,66 @@ static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, > return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); > } > > +/** > + * pruss_cfg_gpimode() - set the GPI mode of the PRU > + * @pruss: the pruss instance handle > + * @pru_id: id of the PRU core within the PRUSS > + * @mode: GPI mode to set > + * > + * Sets the GPI mode for a given PRU by programming the > + * corresponding PRUSS_CFG_GPCFGx register > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode) > +{ > + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) > + return -EINVAL; > + > + if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) > + return -EINVAL; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), > + PRUSS_GPCFG_PRU_GPI_MODE_MASK, > + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_gpimode); > + > +/** > + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events > + * @pruss: the pruss instance > + * @enable: enable/disable > + * > + * Enable/disable the MII RT Events for the PRUSS. > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) > +{ > + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, > + PRUSS_MII_RT_EVENT_EN, set); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_miirt_enable); > + > +/** > + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality > + * @pruss: the pruss instance > + * @enable: enable/disable > + * @mask: Mask for PRU / RTU You should not expect the user to provide the mask but only the core type e.g. enum pru_type { PRU_TYPE_PRU = 0, PRU_TYPE_RTU, PRU_TYPE_TX_PRU, PRU_TYPE_MAX, }; Then you figure out the mask in the function. Also check for invalid pru_type and return error if so. > + * > + * Return: 0 on success, or an error code otherwise > + */ > +int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask) re-arrange so it is (struct pruss, enum pru_type, bool enable) > +{ > + u32 set = enable ? mask : 0; > + > + return pruss_cfg_update(pruss, PRUSS_CFG_SPP, mask, set); > +} > +EXPORT_SYMBOL_GPL(pruss_cfg_xfr_enable); > + > static void pruss_of_free_clk_provider(void *data) > { > struct device_node *clk_mux_np = data; > diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h > index 12ef10b9fe9a..51a3eedd2be6 100644 > --- a/include/linux/remoteproc/pruss.h > +++ b/include/linux/remoteproc/pruss.h > @@ -101,6 +101,7 @@ enum pruss_gpi_mode { > PRUSS_GPI_MODE_PARALLEL, > PRUSS_GPI_MODE_28BIT_SHIFT, > PRUSS_GPI_MODE_MII, > + PRUSS_GPI_MODE_MAX, This could have come as part of patch 3. > }; > > /** > @@ -165,6 +166,10 @@ int pruss_request_mem_region(struct pruss *pruss, enum pruss_mem mem_id, > struct pruss_mem_region *region); > int pruss_release_mem_region(struct pruss *pruss, > struct pruss_mem_region *region); > +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode); > +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable); > +int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask); > > #else > > @@ -188,6 +193,23 @@ static inline int pruss_release_mem_region(struct pruss *pruss, > return -EOPNOTSUPP; > } > > +static inline int pruss_cfg_gpimode(struct pruss *pruss, > + enum pruss_pru_id pru_id, > + enum pruss_gpi_mode mode) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > +static inline int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable, u32 mask) > +{ > + return ERR_PTR(-EOPNOTSUPP); > +} > + > #endif /* CONFIG_TI_PRUSS */ > > #if IS_ENABLED(CONFIG_PRU_REMOTEPROC) cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel