From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABB43C48BE8 for ; Mon, 14 Jun 2021 09:00:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 596B66128B for ; Mon, 14 Jun 2021 09:00:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 596B66128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=82BzLzE52G4MjKylmnLHEeyf8IqKkH37De0619BT2EQ=; b=IoYeGsB+ZyOQ3jc2VnNKcSPlN7 7qWkYx73c3hyNPykdQ/VldELrsYUIxIk14Vu7kEdhi2AXOqVOFDd21D/kg+ZAfRfGTvSCiHHHxdxg +JrRWV7+3H2KQENvqrhJ36TTnOCP1grj03QbCRghDQWW1DnrsbhPTvOmcXbfcy7Ulny9ND3NNPsFo Vtpi5sZs5zMo92hMHy04V3gTa5bRN2zdEErthGsvzPF6Fi8M9RI3X0tvhrxXZLPa8dyAzfg5M6snk XMEcYxSyiLTwWMPdUxwVbVywM8WGRpYKOmwrIszlE44NtHfaLNLuwj9IijLmhXs1AhxpuuQ1T6FKG kIwxYRxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsiRP-00DDrW-Tq; Mon, 14 Jun 2021 08:59:32 +0000 Received: from mail-wm1-f44.google.com ([209.85.128.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsiRH-00DDpa-Ak for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 08:59:25 +0000 Received: by mail-wm1-f44.google.com with SMTP id m41-20020a05600c3b29b02901b9e5d74f02so9207615wms.3 for ; Mon, 14 Jun 2021 01:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cR/6zRsaGY9YfIlwevZHCWwT2etKuhsmQ987OMG5H9c=; b=WQfk6x3x+g5q7nXr5DIsXFQI0uy7zxg11+IIyHQC+UuhY+9wnT76mv8Q7WQaHBlTk+ 5xGigLo4FutudtluCrEyzPPE1Za2bqGDdc6EIyUofpdrUBF47JSaD8Ay3NLAkMEUL9rz MFv3ARbz2iyPUln8kZBs6mAr8A37sCq15tLXEUNodCiQIyrivCoyBT9wBODaRJW8L8tZ j16tQzsBdt61sitpiCglhSdQL6nOXiAkxEXG+1IiqlRLkOErS4bmxZm/dbeFjvFQMdjd j1ji/02/y+ebNo23kQUqm8G8W0NeHTpoa4ef7PKIr792b74RyTKC63ZtliU1CZMrak4A SKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cR/6zRsaGY9YfIlwevZHCWwT2etKuhsmQ987OMG5H9c=; b=LC25YI4EaEG2a8OkqnWwQKUM88nuW7cCJdOSGBmmSvLGc9oLYmypP7fwFiuFALkgNg CXHuuuvo7Qck2nvxQr3jkywhDvqwjSrhKj7nqHADDaBO3atSaHKC9kQmU/Sj86ESgF++ t+VU+Vb2fxhNAy8b6qN3viNLaTYiiisxSMq8IYmQZDr9cQhOCSCHPxo30yWV7WmMCQxU wmDzg9vuhswFOR81X0mFZ9vkwR3fYI6NJ5VJOzc0U/10XxparU6abDkyRkLHDEQLPypR N0JrKV02vYZE2/H5YrJmTg47ks7iBztjfRW7scdEbJzJbONuc6ipS8bOxwVGcZ1907Lg 8fHw== X-Gm-Message-State: AOAM532hY3R8pIJuHm1Qlj1gMpsKyhBT3+VaxcGwA5AHZAFE98uTrcXg PoaoTZjl3/zqkdwPBIiNgoE= X-Google-Smtp-Source: ABdhPJx8/DxT3tbbludZNcJjh+Ltk70zZ4GyN5Lk/Nnu9qM3urKCytgC2pjdZYt8p1rtxp1m55E0fQ== X-Received: by 2002:a1c:a3c3:: with SMTP id m186mr15757009wme.154.1623661100653; Mon, 14 Jun 2021 01:58:20 -0700 (PDT) Received: from ziggy.stardust ([213.195.126.134]) by smtp.gmail.com with ESMTPSA id 62sm16611410wrm.1.2021.06.14.01.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 01:58:20 -0700 (PDT) Subject: Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP To: Petr Vorel Cc: Enric Balletbo i Serra , Catalin Marinas , Luo Longjun , will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sangyan@huawei.com, ningyu9@huawei.com, luchunhua@huawei.com References: <20210507182410.10515-1-luolongjun@huawei.com> <20210511172020.GB21033@arm.com> <6ef5c7a0-3596-a67c-c99d-c8e0def8a96a@collabora.com> From: Matthias Brugger Message-ID: Date: Mon, 14 Jun 2021 10:58:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_015923_458406_F20C581F X-CRM114-Status: GOOD ( 26.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Petr, On 11/06/2021 23:39, Petr Vorel wrote: > Hi, > >> Hi all, > >> On 11/05/2021 22:04, Enric Balletbo i Serra wrote: >>> Hi Catalin, > >>> Thanks for cc'ing me. > >>> On 11/5/21 19:20, Catalin Marinas wrote: >>>> On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote: >>>>> When I compile kernel in ARM64, it produces the following output: > >>>>> *** Default configuration is based on 'defconfig' >>>>> arch/arm64/configs/defconfig:1018:warning: override: reassigning to >>>>> symbol MTK_PMIC_WRAP > >>>>> After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options. > >>>>> Signed-off-by: Luo Longjun >>>>> --- >>>>> arch/arm64/configs/defconfig | 1 - >>>>> 1 file changed, 1 deletion(-) > >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>> index 08c6f769df9a..9907a431db0d 100644 >>>>> --- a/arch/arm64/configs/defconfig >>>>> +++ b/arch/arm64/configs/defconfig >>>>> @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y >>>>> CONFIG_SPI_SH_MSIOF=m >>>>> CONFIG_SPI_SUN6I=y >>>>> CONFIG_SPI_SPIDEV=m >>>>> -CONFIG_MTK_PMIC_WRAP=m >>>>> CONFIG_SPMI=y >>>>> CONFIG_PINCTRL_SINGLE=y >>>>> CONFIG_PINCTRL_MAX77620=y > >>>> Adding Matthias and Enric. This change looks fine to me but I think it >>>> should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m >>>> option while commit fbbe38309d56 introduced the =y variant. > >>>> You could add: > >>>> Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") > > Reviewed-by: Petr Vorel > > I was going to send fix myself, I'd prefer also y, but weren't 100% sure sure. > This has landed in the arm-soc tree this weekend. Anyway, thanks for looking into this as well. Regards, Matthias > For a record: > > * CONFIG_MTK_PMIC_WRAP=m committed by author in 2021-01-04, merged 2021-01-31 15:31:01 > 9fd5449e061e ("arm64: configs: Support pwrap on Mediatek MT6779 platform") > sent: 4 Jan 2021 > https://lore.kernel.org/r/1609747703-27207-3-git-send-email-argus.lin@mediatek.com > Applied to v5.11-next/defconfig 31 Jan 2021 15:32:26 by Matthias Brugger > https://lore.kernel.org/linux-devicetree/5d5a67a5-ac2d-9ef9-b20c-66cbd55ebb8f@gmail.com/ > > * CONFIG_MTK_PMIC_WRAP=y was committed by author in 2021-03-31 11:06:57, merged 2021-03-31 12:12:59 > fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") > sent: 31 Mar 2021 11:06:57 > https://lore.kernel.org/r/20210331090659.4169966-1-enric.balletbo@collabora.com > But originally sent: 9 Feb 2021 10:11:11 > https://lore.kernel.org/lkml/20210209091112.2075478-1-enric.balletbo@collabora.com/ > > Kind regards, > Petr > >>> I sent the same patch some time ago [1]. > >>> I agree, either land this patch or mine. In any case, > >>> Reviewed-by: Enric Balletbo i Serra > >>> Matthias is this something that should go through your tree? > > >> Yes, this should go through my tree. I'll take care of it. > >> Regards, >> Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel