From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9567BC43217 for ; Wed, 19 Oct 2022 10:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LctgXTl4dvYbqZYvzkoxVB7CiRfHuKDQ/IKx2n6Si6k=; b=DhwHtUWmF/EUyh hJk2WlGN0USwy2tCK4v6XmgQ1x4oOxrQyeeaQIqQehStZooN1JYb0VFH1EuWBi7jwLtoJSPQRd7xw OJFWJ2Efb269NeClud0tdO3wOiqU/xk+2jCKZdZW2mMl096JBr8544b++xAGUyKb0NDpRieolYtnB aANIUM2HFLFpi0IwM2vqz4kII5yObKHdbpnGhUDLvHTzvA1I11ufCK7h1JnSnpVNiOWwiDkk34rLZ SGcW3qApwQxJlu1OW87efc5pEts4OuU7EGA5eEWiLsomWkimq5va0L1yCbmsBXDNS5OpgTbQJcFXN Z1aExGfeVAPhgadZ5fpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol5zh-0004DK-N2; Wed, 19 Oct 2022 10:08:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol5zd-0004CS-9Z; Wed, 19 Oct 2022 10:08:10 +0000 X-UUID: 69c29fc60dde4e4e94419d92bebe3883-20221019 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=F+3N5jdI5Vdo+TGFz2Tt3Kx3wcLZK4tfh0R6kaTzfo4=; b=PjTvdmEHWiqw09J54bOAxr1dmCDvPJISe4/WmVzzTmy5hNfTZ22RP0DMYxSQunnyICJEYduLDEr+nrt+ZSLaCD+Vf+fWvG1hG+tfrEH40/aTzC9dII87b5bK3XosHeM9kzlV7tqv8JoNvMYN5T1ltkY+UGPM/C1AffgYpM0dC4o=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.12,REQID:ee7b8cdc-5354-4947-a4c1-8ffa8f0f9cb9,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:62cd327,CLOUDID:42d74ba4-ebb2-41a8-a87c-97702aaf2e20,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 69c29fc60dde4e4e94419d92bebe3883-20221019 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 23128873; Wed, 19 Oct 2022 03:08:04 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Wed, 19 Oct 2022 18:07:26 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 Oct 2022 18:07:25 +0800 Message-ID: Subject: Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile From: Irui Wang To: Hans Verkuil , Alexandre Courbot , Tiffany Lin , "Mauro Carvalho Chehab" , Rob Herring , Matthias Brugger , Hsin-Yi Wang , , CC: Maoguang Meng , Longfei Wang , Yunfei Dong , , , , , , Date: Wed, 19 Oct 2022 18:07:25 +0800 In-Reply-To: <20220926093501.26466-1-irui.wang@mediatek.com> References: <20220926093501.26466-1-irui.wang@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_030809_346496_46F04DD6 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Hans, Gently ping for this patch, could you help to review this patch? Thanks Best Regards On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote: > The encoder driver support h264 baseline, main, high encoder > profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip > the unsupported profile. > > get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L > h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4 > 0: Baseline > 2: Main > 4: High > > Signed-off-by: Irui Wang > --- > drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > index d810a78dde51..d65800a3b89d 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct > mtk_vcodec_ctx *ctx) > 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE); > v4l2_ctrl_new_std_menu(handler, ops, > V4L2_CID_MPEG_VIDEO_H264_PROFILE, > V4L2_MPEG_VIDEO_H264_PROFILE_HIGH, > - 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH); > + ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE) > | > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) | > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)), > + V4L2_MPEG_VIDEO_H264_PROFILE_HIGH); > v4l2_ctrl_new_std_menu(handler, ops, > V4L2_CID_MPEG_VIDEO_H264_LEVEL, > h264_max_level, > 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel