From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3062C433FE for ; Thu, 13 Oct 2022 19:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hJYw/ojES6wB0rozIsugJ7wp5GNgyfUnidv0nUa/b4E=; b=XxwQ59CS1Q6YHvmNX2/fqnyZQG TOZBFnM06M2E6ZE+gAo0MLdQlPnK2eUJPBcUnaGukaLxqR/RZw/q0TXYuRvR8WvES5nKs1IxLABOC y5BPhF7Es+dgFji/zAwlS8dlbIIV03nicnX85ZR6jDeBz+0O5a4zOJt+SoMMeVsA6yCjGqZ7aiBBZ wRIhtlk0YRz8y9p2GwBIozMq1SEf7G5ulYFjBKFLCKyULJXRliDUNmJ/5SsHh21phiOGmWAaDIicC 5mM9FmI9RXb3jhJewDC4BTQGeEZ97mtPBK6EVnLWQ5FdsRLQXQXeeFFqQPoCH6DliFzwU/Qf4qMO1 TgkgnGpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oj3QA-00CmOs-0z; Thu, 13 Oct 2022 18:59:06 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oj3Q6-00CmOC-LW; Thu, 13 Oct 2022 18:59:04 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id AED361884BD4; Thu, 13 Oct 2022 18:58:57 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 8569E2500015; Thu, 13 Oct 2022 18:58:57 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 7DDF49EC0005; Thu, 13 Oct 2022 18:58:57 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 13 Oct 2022 20:58:57 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v7 net-next 3/9] net: switchdev: add support for offloading of the FDB locked flag In-Reply-To: References: <20221009174052.1927483-1-netdev@kapio-technology.com> <20221009174052.1927483-4-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221013_115902_880785_71FB9717 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-13 16:06, Ido Schimmel wrote: >> diff --git a/net/dsa/port.c b/net/dsa/port.c >> index e4a0513816bb..eab32b7a945a 100644 >> --- a/net/dsa/port.c >> +++ b/net/dsa/port.c >> @@ -304,7 +304,7 @@ static int dsa_port_inherit_brport_flags(struct >> dsa_port *dp, >> struct netlink_ext_ack *extack) >> { >> const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | >> - BR_BCAST_FLOOD | BR_PORT_LOCKED; >> + BR_BCAST_FLOOD; > > Not sure how this is related to the patchset. > In general it is needed as a fix because of the way learning with locked port is handled in the driver, so as with MAB and also locked port in the future needing a non-zero Port Association Vector (PAV) for refresh etc to work, inheritance of the locked port flag is a bad idea (say bug) and shouldn't have been in the first place. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel