From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shenwei Wang <shenwei.wang@nxp.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Peng Fan <peng.fan@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [EXT] Re: [PATCH v6 5/5] arm64: dts: freescale: add support for i.MX8DXL EVK board
Date: Tue, 13 Sep 2022 10:44:48 +0200 [thread overview]
Message-ID: <d318a618-350b-22bc-13f2-586fafe038ea@linaro.org> (raw)
In-Reply-To: <PAXPR04MB9185F52BA6FEC47E6412EB3C89449@PAXPR04MB9185.eurprd04.prod.outlook.com>
On 12/09/2022 16:35, Shenwei Wang wrote:
>>>>> + gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>;
>>>>
>>>> Missing enable-active-high?
>>>
>>> No. Enabling this regulator to select the fec1 interface instead of usdhc2.
>> Pulling this GPIO pin to low is to use FEC1 interface.
>>
>> Then the polarity cell should be GPIO_ACTIVE_LOW rather than
>> GPIO_ACTIVE_HIGH?
>>
>
> That doesn't matter since any GPIO phandle flags are ignored in the node of "regulator-fixed". The final flag is only determined by the property of "enable-active-high". If there is a "enable-active-high", the GPIO line works as active high. If no such a property, it works as active low by default. Right?
No. Your flags must match hardware, even if bindings also expect
enable-active-high.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-13 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 17:52 [PATCH v6 0/5] add imx8dxl evk support Shenwei Wang
2022-08-22 17:52 ` [PATCH v6 1/5] dt-bindings: firmware: add missing resource IDs for imx8dxl Shenwei Wang
2022-08-22 17:52 ` [PATCH v6 2/5] dt-bindings: arm: imx: update fsl.yaml " Shenwei Wang
2022-08-22 17:52 ` [PATCH v6 3/5] arm64: dts: imx8: add a node label to ddr-pmu Shenwei Wang
2022-08-22 17:52 ` [PATCH v6 4/5] arm64: dts: freescale: add i.MX8DXL SoC support Shenwei Wang
2022-08-22 17:52 ` [PATCH v6 5/5] arm64: dts: freescale: add support for i.MX8DXL EVK board Shenwei Wang
2022-09-03 3:48 ` Shawn Guo
2022-09-06 13:15 ` [EXT] " Shenwei Wang
2022-09-12 8:16 ` Shawn Guo
2022-09-12 14:35 ` Shenwei Wang
2022-09-13 2:07 ` Shawn Guo
2022-09-13 12:39 ` Shenwei Wang
2022-09-13 13:53 ` Krzysztof Kozlowski
2022-09-13 8:44 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d318a618-350b-22bc-13f2-586fafe038ea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).