From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99C7AC43334 for ; Thu, 16 Jun 2022 13:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1ORQvBtevTHj+p3dSvLpb4NsOJLecs9PbUNSUWJjLqg=; b=kgz7SIVcDtjmrE rXRknYRZ/GvCJKdtpcrwAzTl6FNr/aTZioC2VGKTQtRXzzXfLYU+K3TxOA8JlaXmGVed9ttoHnKtU YcNcjV5/PSH/lunKYLnkJF9Z0QFRB7C3LfDC86Z6LV/L+gInkZHltjZ3RgHR4+vJlBNploFIEWExx Qag513FphxV0Xr7MCdEmiKDZ/pbgvv0x3yTiN8TcvS8dhTAN0HWXV8TzqKDXtU4MMae825FB9764t KbU96Cwb1GCc8HxAO4lUUWWIV0asCYOwqk5NoJTvvxSeUMTD20xl+STo8F1ArMfacmVlQQ3UVm4kA rMCuDWwfkY/XGqI5Ye6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1piG-002Utw-TZ; Thu, 16 Jun 2022 13:39:09 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1piB-002Uql-1Y for linux-arm-kernel@lists.infradead.org; Thu, 16 Jun 2022 13:39:04 +0000 Received: by mail-pf1-x42e.google.com with SMTP id 187so1537478pfu.9 for ; Thu, 16 Jun 2022 06:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tZJ0udOOwaCxWMXlTkBG0pv6kYWe5fFc5cXr8AFWGxw=; b=IwB4vF+O7bkw0gmnipzROvuYX3jurvUS9fS3KCU/sdTK5DVzRyzIRSso7yMWQoR4XB +Ly595kBXCxhOfpHUDyAuLED/Td18kNYUEs6tzy2QG/BQb9uh5ederuqiMvkM0hVkDPx SfKvDeJfQDtbX0O0Mt57c/vkA5TO+7QYEtpRHBUcqW8tNQ9p0cgQt7NNm69X5UgNvq0b ZqK7E7hlY9kvnStImocycSZF3pBAgUAqcgarP02SUIQS3uM4BQFX8Jg7sBxjf8W53zxB YCPn7MuPyS4SMinubCY6953K6Qe+2cYsTo6UuP4BkvGxHlfxc9stUYIJFUq72+T/2o0Y TFKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tZJ0udOOwaCxWMXlTkBG0pv6kYWe5fFc5cXr8AFWGxw=; b=xuiXUbOetKR/aVAzMGWRkV3zgb09aqCVr80feHdbStyAKKStTxPfatSUXEzdl4JmCi JeOfhQ/iZ96N7w16Oj3udppXd+sUZkGrBmA0/FFuuVGn+K1mNQnCzbCdyqBCpF41ZHGa jcV+sl1HhG0ZCjKMEJBvIX5wWQA1CuLrsDIiJirCNyK8/NAPrt91Qo+IzSQYBYLadHhc RudGzI+U7u95Iakayj027uMKW6rA0nTc4mnUaTfMN/Q7I0vkPvVs1s2ZXDH+TJsO5U1I dMcdnHnbVZ4p0Kga/bP6zheAiFS58P6Irn6V/CI7lvWqMlQF5FgXPyA8DgIGacvur6oQ DE9Q== X-Gm-Message-State: AJIora/vqsGLmuJsNSvCxYmhPwcm51bgTCbjxo1JcEXr1KEOs4qK8+XS nx4XuVsINLhXcID2xkjZ0brr3Q== X-Google-Smtp-Source: AGRyM1s1cA2evr96a50L5BABFDORqGyFaQ17SBTfpLNuKCJK5lJgbJW8qW9c08KC/QyKvvh+ZdCv8w== X-Received: by 2002:a63:3e0b:0:b0:40c:42db:6601 with SMTP id l11-20020a633e0b000000b0040c42db6601mr161415pga.586.1655386740360; Thu, 16 Jun 2022 06:39:00 -0700 (PDT) Received: from [172.20.0.255] ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id x16-20020a17090a165000b001e667f932cdsm3822017pje.53.2022.06.16.06.38.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jun 2022 06:39:00 -0700 (PDT) Message-ID: Date: Thu, 16 Jun 2022 06:38:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 12/20] dt-bindings: reset: npcm: Add support for NPCM8XX Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-13-tmaimon77@gmail.com> <381ff739-e898-8812-d549-df7101f0eaa2@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_063903_136606_1741F92D X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/06/2022 06:24, Tomer Maimon wrote: > Hi Krzysztof, > > On Wed, 15 Jun 2022 at 20:03, Krzysztof Kozlowski > wrote: >> >> On 13/06/2022 02:25, Tomer Maimon wrote: >>> Hi Krzysztof, >>> >>> Thanks for your clarification. >>> >>> We can remove the dt-binding file and use numbers in the DTS, >>> appreciate if you can answer few additional questions: >>> 1. Do you suggest adding all NPCM reset values to the NPCM reset >>> document or the reset values should describe in the module >>> documentation that uses it? >> >> What is "NPCM reset document"? Are these reset values anyhow different >> than interrupts or pins? > No, they represent the same values. We do not document in the bindings actual pin or interrupt numbers... >> >>> 2. Some of the NPCM7XX document modules describe the reset value they >>> use from the dt-binding for example: >>> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/adc/nuvoton%2Cnpcm750-adc.yaml#L61 >> >> This is NPCM750 >> >>> If we remove the NPCM8XX dt-binding file should we describe the >>> NPCM8XX values in the NPCM-ADC document file? >> >> What is NPCM-ADC document file? What do you want to describe there? >> Again - how is it different than interrupts? > It is not different from the interrupts. > I will remove the dt-binding reset include file, the reset property > will use numbers and not macro's. I have no clue what are you referring now... This is NPCM8xx and it has no binding header with reset values. What to remove then? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel