From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Vincent Donnefort <vincent.donnefort@arm.com>,
Quentin Perret <qperret@google.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 9/9] cpufreq: scmi: Use .register_em() to register with energy model
Date: Tue, 31 Aug 2021 17:17:52 +0100 [thread overview]
Message-ID: <d454df8e-9adb-ea97-727e-f182e95707ef@arm.com> (raw)
In-Reply-To: <8158488baa1ea1aebd09c8d256db7420051d05ac.1628742634.git.viresh.kumar@linaro.org>
Hi Viresh,
My apologies for delay I was on holidays. I've seen the pull requests,
so it's too late, but just for history...
I have tested this new callback with hacked juno FW which works in
the per-cpu perf requests. There are no issues.
Some debug prints:
[ 3.110072] cpu cpu0: cpumask weight(opp_shared_cpus)=4 weight
policy->cpus=1
[ 3.117666] cpu cpu0: Empty OPP table
[ 3.121418] cpu cpu0: OPP table empty
[ 3.131367] cpu cpu0: EM: created perf domain
[ 3.137848] cpu cpu1: cpumask weight(opp_shared_cpus)=2 weight
policy->cpus=1
[ 3.145220] cpu cpu1: Empty OPP table
[ 3.148961] cpu cpu1: OPP table empty
[ 3.158193] cpu cpu1: EM: created perf domain
[ 3.164325] cpu cpu2: cpumask weight(opp_shared_cpus)=2 weight
policy->cpus=1
[ 3.173430] cpu cpu3: cpumask weight(opp_shared_cpus)=4 weight
policy->cpus=1
[ 3.181947] cpu cpu4: cpumask weight(opp_shared_cpus)=4 weight
policy->cpus=1
[ 3.190620] cpu cpu5: cpumask weight(opp_shared_cpus)=4 weight
policy->cpus=1
root@sqwt-ubuntu:~# grep . /sys/kernel/debug/energy_model/cpu0/ps\:*/*
/sys/kernel/debug/energy_model/cpu0/ps:450000/cost:79
/sys/kernel/debug/energy_model/cpu0/ps:450000/frequency:450000
/sys/kernel/debug/energy_model/cpu0/ps:450000/power:42
/sys/kernel/debug/energy_model/cpu0/ps:575000/cost:85
/sys/kernel/debug/energy_model/cpu0/ps:575000/frequency:575000
/sys/kernel/debug/energy_model/cpu0/ps:575000/power:58
/sys/kernel/debug/energy_model/cpu0/ps:700000/cost:95
/sys/kernel/debug/energy_model/cpu0/ps:700000/frequency:700000
/sys/kernel/debug/energy_model/cpu0/ps:700000/power:79
/sys/kernel/debug/energy_model/cpu0/ps:775000/cost:106
/sys/kernel/debug/energy_model/cpu0/ps:775000/frequency:775000
/sys/kernel/debug/energy_model/cpu0/ps:775000/power:97
/sys/kernel/debug/energy_model/cpu0/ps:850000/cost:119
/sys/kernel/debug/energy_model/cpu0/ps:850000/frequency:850000
/sys/kernel/debug/energy_model/cpu0/ps:850000/power:119
root@sqwt-ubuntu:~# cat /sys/kernel/debug/energy_model/cpu0/cpus
0,3-5
root@sqwt-ubuntu:~# cat /sys/kernel/debug/energy_model/cpu1/cpus
1-2
root@sqwt-ubuntu:~# grep . /sys/kernel/debug/energy_model/cpu1/ps\:*/*
/sys/kernel/debug/energy_model/cpu1/ps:1100000/cost:583
/sys/kernel/debug/energy_model/cpu1/ps:1100000/frequency:1100000
/sys/kernel/debug/energy_model/cpu1/ps:1100000/power:583
/sys/kernel/debug/energy_model/cpu1/ps:450000/cost:391
/sys/kernel/debug/energy_model/cpu1/ps:450000/frequency:450000
/sys/kernel/debug/energy_model/cpu1/ps:450000/power:160
/sys/kernel/debug/energy_model/cpu1/ps:625000/cost:420
/sys/kernel/debug/energy_model/cpu1/ps:625000/frequency:625000
/sys/kernel/debug/energy_model/cpu1/ps:625000/power:239
/sys/kernel/debug/energy_model/cpu1/ps:800000/cost:471
/sys/kernel/debug/energy_model/cpu1/ps:800000/frequency:800000
/sys/kernel/debug/energy_model/cpu1/ps:800000/power:343
/sys/kernel/debug/energy_model/cpu1/ps:950000/cost:525
/sys/kernel/debug/energy_model/cpu1/ps:950000/frequency:950000
/sys/kernel/debug/energy_model/cpu1/ps:950000/power:454
root@sqwt-ubuntu:~#
Regards,
Lukasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-31 16:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 4:35 [PATCH V3 0/9] Add callback to register with energy model Viresh Kumar
2021-08-12 4:35 ` [PATCH V3 3/9] cpufreq: imx6q: Use .register_em() " Viresh Kumar
2021-08-12 4:35 ` [PATCH V3 4/9] cpufreq: mediatek: " Viresh Kumar
2021-08-12 4:35 ` [PATCH V3 7/9] cpufreq: scpi: " Viresh Kumar
2021-08-26 11:26 ` Sudeep Holla
2021-08-12 4:35 ` [PATCH V3 8/9] cpufreq: vexpress: " Viresh Kumar
2021-08-26 11:28 ` Sudeep Holla
2021-08-12 4:35 ` [PATCH V3 9/9] cpufreq: scmi: " Viresh Kumar
2021-08-26 11:27 ` Sudeep Holla
2021-08-31 16:17 ` Lukasz Luba [this message]
2021-08-31 8:54 ` [PATCH V3 0/9] Add callback " Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d454df8e-9adb-ea97-727e-f182e95707ef@arm.com \
--to=lukasz.luba@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).