From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B28C4338F for ; Thu, 12 Aug 2021 09:24:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7392E60EB9 for ; Thu, 12 Aug 2021 09:24:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7392E60EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:Subject:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=us2VE75I+Z63wZKO60YEp4TFH4Jb00Rh5HdJfW8sBTU=; b=qlQ8ZXS3bJnYnef+MzLD0BX0Mf z1O8Mr3TWvHjyEwokWBjzcPN9q656qb2gkPMTEZjJN3zP6qsMzEGiRta/DEOM7T5a3Zf6LMvmdawq TNVsHhSnr+xwwvUx0U2PHwEqgfxOPrVHi9BY9pc3INTLqm6VKhGNU7HqPbMsC0jFZVs4j+SIpFWX9 a9UCUMZaSQP5VFrKFvH1DFmaI5VHnBMDY1YWG1zou2jBKNZSATLQ3WZ/xxttchFV3IkqDqWfQO2AR 2NbqDkdZqoI+1BXJb6P9BRDbgHypRICa4XbR9kuha/bnj++5jSZhqVeMmOf5jEvfRF77IWdnfZLEK N5ZbJstA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE6vA-009PRx-82; Thu, 12 Aug 2021 09:22:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE6nZ-009M8E-1v for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 09:14:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DEECD6E; Thu, 12 Aug 2021 02:14:48 -0700 (PDT) Received: from [10.163.68.17] (unknown [10.163.68.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C3EB3F718; Thu, 12 Aug 2021 02:14:44 -0700 (PDT) From: Anshuman Khandual Subject: Re: [RFC V2 01/10] mm/mmap: Dynamically initialize protection_map[] To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, suzuki.poulose@arm.com, mark.rutland@arm.com, will@kernel.org, maz@kernel.org, james.morse@arm.com, steven.price@arm.com References: <1627281445-12445-1-git-send-email-anshuman.khandual@arm.com> <1627281445-12445-2-git-send-email-anshuman.khandual@arm.com> <20210805170318.GB6719@arm.com> Message-ID: Date: Thu, 12 Aug 2021 14:45:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210805170318.GB6719@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_021449_237924_64C8EEF7 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/5/21 10:33 PM, Catalin Marinas wrote: > On Mon, Jul 26, 2021 at 12:07:16PM +0530, Anshuman Khandual wrote: >> The protection_map[] elements (__PXXX and __SXXX) might sometimes contain >> runtime variables in certain platforms like arm64 preventing a successful >> build because of the current static initialization. So it just defers the >> initialization until mmmap_init() via a new helper init_protection_map(). >> >> Signed-off-by: Anshuman Khandual >> --- >> mm/mmap.c | 26 ++++++++++++++++++++++---- >> 1 file changed, 22 insertions(+), 4 deletions(-) >> >> diff --git a/mm/mmap.c b/mm/mmap.c >> index ca54d36..a95b078 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -100,10 +100,7 @@ static void unmap_region(struct mm_struct *mm, >> * w: (no) no >> * x: (yes) yes >> */ >> -pgprot_t protection_map[16] __ro_after_init = { >> - __P000, __P001, __P010, __P011, __P100, __P101, __P110, __P111, >> - __S000, __S001, __S010, __S011, __S100, __S101, __S110, __S111 >> -}; >> +pgprot_t protection_map[16] __ro_after_init; > > Mips, x86, sparc, arm32, m68k all adjust protection_map[] during boot. > Could we do something similar here and avoid changing the generic code? If __P[000..111] and __S[000..111] be made dummy values (e.g 0 or something standard prot temporarily), hence the compilation problem could be avoided. Later in the platform code, protection_map[] could be adjusted with actual prot values which would involve variable. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel