From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6178AC4332F for ; Thu, 22 Dec 2022 10:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ScdD4dgqrdS6n5rU4fwlr3Xnsk80MQe9tqODtOMlBP8=; b=lVgfSPiJAdCEHm Qm7IxZ3HTS60c/nX7a9krsYKV+lyIXeIO0+U9VOXCeTcOnDDH/xeSb05BmU5MPZePEYPO6Er7JHGw DM5LcvWEKjby1KwETbAeM3FPP8awcJZE1yM+LRvyX1plwYhwHSB3+R3gnSz5ABmX5ylsMZLnp/j0S QHtPkclJizc9l3qyq9QOkTQaTsp9Y7R9YxEk2R81tXsYB0pQQsY0zjE+HG8WtUHexiKXAwaAPg0K+ uGl6+FfPvkNn8KH4dtq5tbn7ZKo0PbJnhMZynleoBgJFY1b8wuG6vGNMEVVWJIvnq8QDEaBkd6J2f yOiDhNswrRyFJKN2h2nQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8Imf-00AJ25-DW; Thu, 22 Dec 2022 10:26:41 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8Il8-00AIKv-JZ for linux-arm-kernel@lists.infradead.org; Thu, 22 Dec 2022 10:25:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8051B81CFA; Thu, 22 Dec 2022 10:25:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84004C433D2; Thu, 22 Dec 2022 10:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671704703; bh=HjWsEui9j49BqsSquLS1N64hkFZnyG+wvor5Mw3io4g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EVwCaOLSGrczB2AB53z9KEZJGsQGAIMS367LMi+ZJrwt4o7mwRmZZrs+CWzeN78xr XU9zTTrX/hiZyCXJjOx9aUMfEn5G7mi7xQ/IG05UXQq/2c3jyal8W1cBtn6g+zjbLS NDi9ENra7WjrcnSQsEw6dZLRJJGnaxwFJDKKMEk90UG4TVB2mm34Bm7PUsxv8luurI WN/ATociYxOM3L9OAVuR16WzbVgR5PBkV8v5fBNDCkUU+DG5nArGGaF+6B7/hpNL+9 pu/TgZzwVfKAOfc+7S2VUdkdYmvVUkYWYwcUoo2fT1/CAW9rMFXUZ/xHeINezqPS22 Q/ZU+m4hDl3iA== Message-ID: Date: Thu, 22 Dec 2022 11:24:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH 2/7] dt-bindings: bus: add STM32 System Bus Content-Language: en-US To: Gatien Chevallier , alexandre.torgue@foss.st.com, robh+dt@kernel.org, Oleksii_Moisieiev@epam.com, linus.walleij@linaro.org, gregkh@linuxfoundation.org Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loic.pallardy@st.com, devicetree@vger.kernel.org, mark.rutland@arm.com, arnd@arndb.de References: <20221221173055.11719-1-gatien.chevallier@foss.st.com> <20221221173055.11719-3-gatien.chevallier@foss.st.com> From: Krzysztof Kozlowski In-Reply-To: <20221221173055.11719-3-gatien.chevallier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221222_022507_023541_272A5E4B X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/12/2022 18:30, Gatien Chevallier wrote: > Document STM32 System Bus. This bus is intended to control firewall > access for the peripherals connected to it. > > Signed-off-by: Loic PALLARDY > Signed-off-by: Gatien Chevallier Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. > --- > .../devicetree/bindings/bus/st,sys-bus.yaml | 88 +++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/bus/st,sys-bus.yaml > > diff --git a/Documentation/devicetree/bindings/bus/st,sys-bus.yaml b/Documentation/devicetree/bindings/bus/st,sys-bus.yaml > new file mode 100644 > index 000000000000..9c0e86612695 > --- /dev/null > +++ b/Documentation/devicetree/bindings/bus/st,sys-bus.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bus/stm32,sys-bus.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STM32 System Bus Only one space. > + > +description: | > + The STM32 System Bus is an internal bus to which some internal peripherals > + are connected. STM32 System Bus integrates a firewall controlling access to each > + device. This bus prevents non-accessible devices to be probed. > + > + To see which peripherals are securable, please check the SoC reference manual. > + > +maintainers: > + - Gatien Chevallier > + > +allOf: > + - $ref: /schemas/feature-controllers/feature-domain-controller.yaml# > + > +properties: > + compatible: > + enum: > + - st,stm32mp13-sys-bus > + - st,stm32mp15-sys-bus > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + '#feature-domain-cells': Use consistent quotes, either ' or " > + minItems: 1 No. Cells must be const. This does not match cells at all... > + > + ranges: true > + > + feature-domain-controller: true > + > +patternProperties: > + "^.*@[0-9a-f]+$": > + description: Devices attached to system bus > + type: object > + properties: > + feature-domains: > + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains maxItems > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - feature-domain-controller > + - '#feature-domain-cells' > + - ranges > + > +additionalProperties: false > + > +examples: > + - | > + // In this example, > + // - the foo1 device refers to etzpc as his domain controller. > + // - same goes for foo2. > + // Access rights are verified before creating devices. > + > + etzpc: etzpc@5c007000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "st,stm32mp15-sys-bus"; > + reg = <0x5c007000 0x400>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + feature-domain-controller; > + #feature-domain-cells = <1>; > + > + foo1: foo@1000000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + reg = <0x0 0x1000000>; Missing compatible, missing proper device name. Don't use fake names, but describe real case. > + feature-domains = <&etzpc 0>; > + }; > + > + foo2: foo@2000000 { > + reg = <0x0 0x2000000>; > + feature-domains = <&etzpc 0>; > + }; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel