From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2D1C433ED for ; Fri, 7 May 2021 03:45:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0EA8E613EC for ; Fri, 7 May 2021 03:45:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EA8E613EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References:In-Reply-To: Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n6X09vR3gd/al1azLRjPZoXIZikAbW1TaAbAuwFkk5Y=; b=hbCa5JvNBFbz1vqlJXMXjxwe+ Do25+57EsOxfmuBBDBfpTeZ+er/0jevcMciRu26MnIx9xwPBHOvvC6rHwR/aGzf877oN/VEY9bD5F 8Iy4knQNppXruUDo4gTt/7kB1guFJ6NNy6tRa0zQ/M/QMxPTUmUK5NOjx/tNkOJfnymhtq2nbSmWE LBI9Vu57vXg8Yk/YsYd50/38f+i9a8CYq4speHWhObDnJIA5ynUcaKxur0HFI/LCdkG3PNKp9mcy0 VS0DB5cu68cHkFgTywjdKXG2G1jz1HcagjIkqISuxHBgEc689btsgR1T5TEyaO5rxqEt7zZqCHTgc dl3w2qfqA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lerOQ-0060JN-LH; Fri, 07 May 2021 03:43:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lerOM-0060Iy-Py for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 03:43:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:Mime-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=arDYubqdnTaycuMeD6vidROrSycff0E9LYTfLWtgEeY=; b=cgunAd8fKiQoM7AVWQ9i3awswQ 2PW367DIP2jkl1rUSwofOwZLtXeTCk7jIOyw/7/EFzcoMVuJGIRUVvVX0MI9IAYuUW2W4mvZL9lQL gh8KZncvWpCTCxaBpvFBItAnMWKSaMqjUnWs4PBLxcGLV3068OjxNotSGfhWkVLgkp2Vxkfi0dqWO p7oa/pNDW7JS1GkiGWj7AwcObsjgMqJkeXMRns2aSAekQtF/c+vCCd8cvkg+DPoNf2lby8meDsNN+ PsqQKLv0svg/XESXicBiltyqPIgwR3K4VlDZupE3NMe+17f8flCbj8oCyPM+xetLYvNuM4NqtcOKm UrqXT6sA==; Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lerOK-006YCU-2F for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 03:43:05 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 8B99B580EFD; Thu, 6 May 2021 23:42:57 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Thu, 06 May 2021 23:42:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=arDYubqdnTaycuMeD6vidROrSycff0E 9LYTfLWtgEeY=; b=vUdHaypfY4c34YnKjC3s38glKfC2kan4S8Y3Sn2ZirS1OSy 67ziv2lw5DGr/TW8IAGecuPLAlX9tOIQtl3s3Y/upj9zNy1qjTSRftWlfDcWUr2l 6H3MscnI12kj5PlEQsSMgENVHXbu3boVDCnKd7eKPTYJCkH76xm01m/hjq/Rl/Hz CA6y5K8u1QTTuQ6xA+K4gwNfWb43+8wnzGyCvCP+WGha64jgB8JTgcjQKf8J0gr6 aoXLoXMbeKxTMfr6DSrPx4JqemG9lsNqYTM8S+5SfjqWoBH50F8vTlomf2x3vEY8 4LLf+R6k4sfxenxOBhKmOI1UxqPhyJ4Wtx7P6tQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=arDYub qdnTaycuMeD6vidROrSycff0E9LYTfLWtgEeY=; b=Jotf7hi/FDyVXe12rk8yAh 5AUFEwU+zBRtM+RZLmWbwnSk9Le2M5M9BQY8QGiRM2xOkA+xXH4oH26u1xvEfxGs zoGUsGiy9cvSrwQ2gn6eOtfSYgJXOWGhw1WCAwKriP1Bdq3BMmD//kUAFjT87gBW Vil9ksLVPjWW7M1Vl6QbDc33TBGiiUTOYraBcZDXKkNHzBno9xUBb6j9CR+hWRcp TzEEwhjUchKw3lFMY8A3RFeYg9RSQQ+yA2c1YekYYDBPteCuZW9EnAaTI0kYU8Ik BkAahLwTb6OBB3j0crZr4VC50BKjm7PhN5GPNsmFU4GaZ2zs5tg3xWs6OBZeC4zg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeguddgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepuddttdekueeggedvtddtueekiedutdfguedutdefieeuteefieelteet vddthfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 22FE4A0007A; Thu, 6 May 2021 23:42:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416 Mime-Version: 1.0 Message-Id: In-Reply-To: <20210507033021.GB23749@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-3-steven_lee@aspeedtech.com> <8611c4a7-8c65-4d7d-90d5-37c80faa3142@www.fastmail.com> <20210507033021.GB23749@aspeedtech.com> Date: Fri, 07 May 2021 13:12:33 +0930 From: "Andrew Jeffery" To: "Steven Lee" Cc: "Ulf Hansson" , "Rob Herring" , "Joel Stanley" , "Adrian Hunter" , "Philipp Zabel" , "Ryan Chen" , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" , "Ryan Chen" , "Chin-Ting Kuo" , "Hongwei Zhang" Subject: =?UTF-8?Q?Re:_[PATCH_v3_2/5]_ARM:_dts:_aspeed:_ast2600evb:_Add_comment_f?= =?UTF-8?Q?or_gpio_regulator_of_sdhci?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_204304_196585_85D21465 X-CRM114-Status: GOOD ( 27.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 May 2021, at 13:00, Steven Lee wrote: > The 05/07/2021 09:40, Andrew Jeffery wrote: > > > > > > On Thu, 6 May 2021, at 19:33, Steven Lee wrote: > > > Add the description for describing the AST2600-A2 EVB reference design of > > > GPIO regulators. > > > > > > Signed-off-by: Steven Lee > > > --- > > > arch/arm/boot/dts/aspeed-ast2600-evb.dts | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > > b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > > index 2772796e215e..1ae0facc3d5f 100644 > > > --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > > +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts > > > @@ -104,6 +104,21 @@ > > > status = "okay"; > > > }; > > > > > > +/* > > > + * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be > > > + * toggled by GPIO pins. > > > + * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the > > > + * power load switch that providing 3.3v to sdhci0 vdd, GPIOV1 is connected to > > > + * a 1.8v and a 3.3v power load switch that providing signal voltage to > > > + * sdhci0 bus. > > > + * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled. > > > + * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal > > > + * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled, > > > + * sdhci0 signal voltage becomes 1.8v. > > > + * AST2600-A2 EVB also support toggling signal voltage for sdhci1. > > > + * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3 > > > + * as power-switch-gpio. > > > + */ > > > > Okay, I think the comment is in the right place, but I feel this patch > > should also add the regulator nodes and hook them up to the SDHCIs. > > > > Given Rob isn't super keen on a second example in the binding document > > I think you can just cut the example out and paste it in here. > > > > Hi Andrew, > > Since AST2600-A0 and AST2600-A1 don't have regulators, do you mean cut > the example from dt-binding and paste it to aspeed-ast2600-evb.dts but > comment out the example? If the board design varies with the silicon revision we should probably have devicetrees that are appropriate for each, so an aspeed-ast2600-evb-a2.dts #include "aspeed-ast2600-evb.dts" at the top and go from there. Cheers, Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel