* [PATCH] soc: ti: pruss: fix referenced node in error message
@ 2021-06-21 18:08 Jan Kiszka
2021-06-23 15:51 ` Suman Anna
2021-11-23 2:04 ` Nishanth Menon
0 siblings, 2 replies; 6+ messages in thread
From: Jan Kiszka @ 2021-06-21 18:08 UTC (permalink / raw)
To: Santosh Shilimkar, Linux Kernel Mailing List, linux-arm-kernel,
Grzegorz Jaszczyk
From: Jan Kiszka <jan.kiszka@siemens.com>
So far, "(null)" is reported for the node that is missing clocks.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
drivers/soc/ti/pruss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
index f22ac1edbdd0..afc8aae68035 100644
--- a/drivers/soc/ti/pruss.c
+++ b/drivers/soc/ti/pruss.c
@@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
clks_np = of_get_child_by_name(cfg_node, "clocks");
if (!clks_np) {
- dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
+ dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
return -ENODEV;
}
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: ti: pruss: fix referenced node in error message
2021-06-21 18:08 [PATCH] soc: ti: pruss: fix referenced node in error message Jan Kiszka
@ 2021-06-23 15:51 ` Suman Anna
2021-09-01 15:03 ` Jan Kiszka
2021-11-23 2:04 ` Nishanth Menon
1 sibling, 1 reply; 6+ messages in thread
From: Suman Anna @ 2021-06-23 15:51 UTC (permalink / raw)
To: Jan Kiszka, Santosh Shilimkar, Linux Kernel Mailing List,
linux-arm-kernel, Grzegorz Jaszczyk, Kishon Vijay Abraham
On 6/21/21 1:08 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> So far, "(null)" is reported for the node that is missing clocks.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Suman Anna <s-anna@ti.com>
> ---
> drivers/soc/ti/pruss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
> index f22ac1edbdd0..afc8aae68035 100644
> --- a/drivers/soc/ti/pruss.c
> +++ b/drivers/soc/ti/pruss.c
> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>
> clks_np = of_get_child_by_name(cfg_node, "clocks");
> if (!clks_np) {
> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
> return -ENODEV;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: ti: pruss: fix referenced node in error message
2021-06-23 15:51 ` Suman Anna
@ 2021-09-01 15:03 ` Jan Kiszka
2021-11-20 7:53 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2021-09-01 15:03 UTC (permalink / raw)
To: Suman Anna, Santosh Shilimkar, Linux Kernel Mailing List,
linux-arm-kernel, Grzegorz Jaszczyk, Kishon Vijay Abraham
On 23.06.21 17:51, Suman Anna wrote:
> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> So far, "(null)" is reported for the node that is missing clocks.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Acked-by: Suman Anna <s-anna@ti.com>
>
>> ---
>> drivers/soc/ti/pruss.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>> index f22ac1edbdd0..afc8aae68035 100644
>> --- a/drivers/soc/ti/pruss.c
>> +++ b/drivers/soc/ti/pruss.c
>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>
>> clks_np = of_get_child_by_name(cfg_node, "clocks");
>> if (!clks_np) {
>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>> return -ENODEV;
>> }
>>
>>
>
This was not merged yet. Is it queued somewhere?
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: ti: pruss: fix referenced node in error message
2021-09-01 15:03 ` Jan Kiszka
@ 2021-11-20 7:53 ` Jan Kiszka
2021-11-22 15:30 ` Suman Anna
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2021-11-20 7:53 UTC (permalink / raw)
To: Suman Anna, Santosh Shilimkar, Linux Kernel Mailing List,
linux-arm-kernel, Grzegorz Jaszczyk, Kishon Vijay Abraham
On 01.09.21 17:03, Jan Kiszka wrote:
> On 23.06.21 17:51, Suman Anna wrote:
>> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> So far, "(null)" is reported for the node that is missing clocks.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Acked-by: Suman Anna <s-anna@ti.com>
>>
>>> ---
>>> drivers/soc/ti/pruss.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>>> index f22ac1edbdd0..afc8aae68035 100644
>>> --- a/drivers/soc/ti/pruss.c
>>> +++ b/drivers/soc/ti/pruss.c
>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>>
>>> clks_np = of_get_child_by_name(cfg_node, "clocks");
>>> if (!clks_np) {
>>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>>> return -ENODEV;
>>> }
>>>
>>>
>>
>
> This was not merged yet. Is it queued somewhere?
>
> Jan
>
Second reminder - still not seeing this in upstream.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: ti: pruss: fix referenced node in error message
2021-11-20 7:53 ` Jan Kiszka
@ 2021-11-22 15:30 ` Suman Anna
0 siblings, 0 replies; 6+ messages in thread
From: Suman Anna @ 2021-11-22 15:30 UTC (permalink / raw)
To: Jan Kiszka, Santosh Shilimkar, Linux Kernel Mailing List,
linux-arm-kernel, Grzegorz Jaszczyk, Kishon Vijay Abraham,
Nishanth Menon
+ Nishanth
On 11/20/21 1:53 AM, Jan Kiszka wrote:
> On 01.09.21 17:03, Jan Kiszka wrote:
>> On 23.06.21 17:51, Suman Anna wrote:
>>> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> So far, "(null)" is reported for the node that is missing clocks.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Acked-by: Suman Anna <s-anna@ti.com>
>>>
>>>> ---
>>>> drivers/soc/ti/pruss.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>>>> index f22ac1edbdd0..afc8aae68035 100644
>>>> --- a/drivers/soc/ti/pruss.c
>>>> +++ b/drivers/soc/ti/pruss.c
>>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>>>
>>>> clks_np = of_get_child_by_name(cfg_node, "clocks");
>>>> if (!clks_np) {
>>>> - dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>>>> + dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>>>> return -ENODEV;
>>>> }
>>>>
>>>>
>>>
>>
>> This was not merged yet. Is it queued somewhere?
>>
>> Jan
>>
>
> Second reminder - still not seeing this in upstream.
Nishanth,
Can you pick this up?
regards
Suman
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] soc: ti: pruss: fix referenced node in error message
2021-06-21 18:08 [PATCH] soc: ti: pruss: fix referenced node in error message Jan Kiszka
2021-06-23 15:51 ` Suman Anna
@ 2021-11-23 2:04 ` Nishanth Menon
1 sibling, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2021-11-23 2:04 UTC (permalink / raw)
To: Jan Kiszka, Linux Kernel Mailing List, linux-arm-kernel,
Santosh Shilimkar, Grzegorz Jaszczyk
Cc: Nishanth Menon
Hi Jan Kiszka,
On Mon, 21 Jun 2021 20:08:28 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> So far, "(null)" is reported for the node that is missing clocks.
>
>
I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!
[1/1] soc: ti: pruss: fix referenced node in error message
commit: 8aa35e0bb5eaa42bac415ad0847985daa7b4890c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-23 2:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-21 18:08 [PATCH] soc: ti: pruss: fix referenced node in error message Jan Kiszka
2021-06-23 15:51 ` Suman Anna
2021-09-01 15:03 ` Jan Kiszka
2021-11-20 7:53 ` Jan Kiszka
2021-11-22 15:30 ` Suman Anna
2021-11-23 2:04 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).