From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB0B5C47088 for ; Wed, 26 May 2021 14:14:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B43C61026 for ; Wed, 26 May 2021 14:14:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B43C61026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=in074Hnp79mcHZKAaqXwUeIhyznmTchLTw6RxM8vHV8=; b=3jBE7T27Pn2EnhLIkjbxnq05Lk /ZLxEDYZ+lNKruNeSXIWosjaSPiI0ecwHTporUEanVhsxsZzWmKBd96LBIuPHDIF+oRoKQDEbuqGP XnUF3qPclyRZHmfg7ml+EXILASMNnn/TdUpzkm8ZPOCTRv3RydMa29D83U1XW9/QBzQDsvPuHfDD+ ACfpGJNLbkvlPqWWQNBh50+741sTFw0O0GK4t83gjAhZusPlDpakVmpvixPzWV7R3/5ORCWlONfDH ZVGBgvoG6RTSk9g/tJn1DlcU4NXKNzEHFMpsOPNHDGQYLClWbSmhiPqyHryjd9WuSlEvqE9GMJuZy XJsyhiXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lluGS-00EkbY-PV; Wed, 26 May 2021 14:12:05 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llsmB-00E2u2-PK for linux-arm-kernel@lists.infradead.org; Wed, 26 May 2021 12:36:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622032602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vo3CFjgMiVFpDxJLQuQQeOIXjZuz9Jnetz8hQXS67No=; b=Yy2iOPvOQPOuCUbADZ8BLSpoEZ1Ylrystpzutw1Uo21w8pb2cksBGqBEKTViFzJY02VbV9 L0wpJD5S4mDh9UiDSfyY0EJR8m5jc5od2nvETuqdaUrkFYMZtxxN721SWcBZwqqElpZLiF ELcONW10UgPJmYy1NhStOoxG2gVJYE4= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-WX3iVpzVNsKP1cd4mAbzBg-1; Wed, 26 May 2021 08:36:40 -0400 X-MC-Unique: WX3iVpzVNsKP1cd4mAbzBg-1 Received: by mail-ej1-f71.google.com with SMTP id p18-20020a1709067852b02903dab2a3e1easo343713ejm.17 for ; Wed, 26 May 2021 05:36:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vo3CFjgMiVFpDxJLQuQQeOIXjZuz9Jnetz8hQXS67No=; b=WodiQ250eJDSSNuHHBow3GlJE+UsctPwP0600i+L91b4IYTfvyDxKXhpdAbwjXYuv9 hQaVXepbxkFHWvKNw5QKLxL7Kldg7T1aioMDLi9RxnJpkiN06f8d4Nv+O9ondBtuuwxe DrUp6qeuixygSzzGKnu4R6wjspuv1pI9gMRJqhCm9So0gu/pkJHPIiRHw4YkshbsBMKh /JVaUVPxDQvCifVCrWSD9jhRGdIz9Q0t2KkxyYQoU9ecqhfHQQKiSLq9nkXsfg8E7eQ6 9u4zFguMO9H+0Q7CFOgMXowspOZWG7dPRmW0Spxd38cReMqy6wAo9YkpsnIFNzsP/j9w sV9w== X-Gm-Message-State: AOAM531oqjfHemeEQjW87TYBzkcJ/gZasmZWBdxAEGXIEZ0nmP0ktOt4 nvF5xZcnAd8OLlMfL2pBVSJ/7IlfINdcJNWgbobFTIono87MZabLwfpnMyKfxsAeZ3GK7lqa7pT uMEi7T3oPeSk/OzZRhmhnu8lEG9lFVQ9tFA4= X-Received: by 2002:a17:906:351a:: with SMTP id r26mr2036963eja.389.1622032599352; Wed, 26 May 2021 05:36:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCzSG2YLjcyhKgm8r3o/LZqPgFxUK6ylJOFe2YCzql+M/THNIC19JLVSjVDkUJ82LC9sNhuQ== X-Received: by 2002:a17:906:351a:: with SMTP id r26mr2036951eja.389.1622032599157; Wed, 26 May 2021 05:36:39 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id y15sm284014ejc.48.2021.05.26.05.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 05:36:38 -0700 (PDT) Subject: Re: [PATCH v4 0/8] Introduce intel_skl_int3472 module To: Daniel Scally , "Rafael J . Wysocki" , Andy Shevchenko , Wolfram Sang , Lee Jones , Maximilian Luz , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@acpica.org Cc: Len Brown , Mika Westerberg , Russell King , Linus Walleij , Bartosz Golaszewski , Mark Gross , Robert Moore , Erik Kaneda , laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20210520140928.3252671-1-djrscally@gmail.com> From: Hans de Goede Message-ID: Date: Wed, 26 May 2021 14:36:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210526_053643_980365_B0270E68 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 5/26/21 1:03 AM, Daniel Scally wrote: >> 3/8 and 5/8 seem to be nice cleanups, but not really necessary. IMHO it >> would be best to park these cleanups for later and for 3/8 add the following >> where necessary for now: >> >> /* FIXME drop this once the I2C_DEV_NAME_FORMAT macro has been added to include/linux/i2c.h */ >> #ifndef I2C_DEV_NAME_FORMAT >> #define I2C_DEV_NAME_FORMAT "i2c-%s" >> #endif >> >> This is not the prettiest but it reduces all the subsys cross-deps and things >> like this have been done before for similar reasons. >> >> Likewise it would be good if you can add if (foo) as condition before any >> clkdev_drop(foo) calls in this patch-set and then merge >> 5/8 "clkdev: Make clkdev_drop() null aware" independently of this and then >> once both are in Linux tree follow-up with a cleanup patch dropping the if (foo) >> guards. > > > This is fine by me if people are happy for it to go in like that; I'll > just fix it up later. I don't expect anyone to object against these 2 small fixes going in later, if you can drop these 2 for v5 that would greatly help with untangling all the subsys dependencies. Then I can just merge an ACPI + a gpiolib-acpi immutable branch and then merge the big drivers/platform/x86 patch. Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel