From: Neil Armstrong <narmstrong@baylibre.com>
To: Guillaume La Roque <glaroque@baylibre.com>,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
khilman@baylibre.com, devicetree@vger.kernel.org
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 3/3] media: platform: meson-ao-cec-g12a: add wakeup support
Date: Mon, 6 Jan 2020 14:18:33 +0100 [thread overview]
Message-ID: <d86fe5f8-31c8-d600-8be7-75dfeb0bb45a@baylibre.com> (raw)
In-Reply-To: <20191213132956.11074-4-glaroque@baylibre.com>
On 13/12/2019 14:29, Guillaume La Roque wrote:
> add register configuration to activate wakeup feature in bl301
>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> drivers/media/platform/meson/ao-cec-g12a.c | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/drivers/media/platform/meson/ao-cec-g12a.c b/drivers/media/platform/meson/ao-cec-g12a.c
> index 891533060d49..85850b974126 100644
> --- a/drivers/media/platform/meson/ao-cec-g12a.c
> +++ b/drivers/media/platform/meson/ao-cec-g12a.c
> @@ -25,6 +25,7 @@
> #include <media/cec.h>
> #include <media/cec-notifier.h>
> #include <linux/clk-provider.h>
> +#include <linux/mfd/syscon.h>
>
> /* CEC Registers */
>
> @@ -168,6 +169,18 @@
>
> #define CECB_WAKEUPCTRL 0x31
>
> +#define CECB_FUNC_CFG_REG 0xA0
> +#define CECB_FUNC_CFG_MASK GENMASK(6, 0)
> +#define CECB_FUNC_CFG_CEC_ON 0x01
> +#define CECB_FUNC_CFG_OTP_ON 0x02
> +#define CECB_FUNC_CFG_AUTO_STANDBY 0x04
> +#define CECB_FUNC_CFG_AUTO_POWER_ON 0x08
> +#define CECB_FUNC_CFG_ALL 0x2f
> +#define CECB_FUNC_CFG_NONE 0x0
> +
> +#define CECB_LOG_ADDR_REG 0xA4
> +#define CECB_LOG_ADDR_MASK GENMASK(22, 16)
> +
> struct meson_ao_cec_g12a_data {
> /* Setup the internal CECB_CTRL2 register */
> bool ctrl2_setup;
> @@ -177,6 +190,7 @@ struct meson_ao_cec_g12a_device {
> struct platform_device *pdev;
> struct regmap *regmap;
> struct regmap *regmap_cec;
> + struct regmap *regmap_ao_sysctrl;
> spinlock_t cec_reg_lock;
> struct cec_notifier *notify;
> struct cec_adapter *adap;
> @@ -518,6 +532,13 @@ meson_ao_cec_g12a_set_log_addr(struct cec_adapter *adap, u8 logical_addr)
> BIT(logical_addr - 8));
> }
>
> + if (ao_cec->regmap_ao_sysctrl)
> + ret |= regmap_update_bits(ao_cec->regmap_ao_sysctrl,
> + CECB_LOG_ADDR_REG,
> + CECB_LOG_ADDR_MASK,
> + FIELD_PREP(CECB_LOG_ADDR_MASK,
> + logical_addr));
> +
> /* Always set Broadcast/Unregistered 15 address */
> ret |= regmap_update_bits(ao_cec->regmap_cec, CECB_LADD_HIGH,
> BIT(CEC_LOG_ADDR_UNREGISTERED - 8),
> @@ -618,6 +639,13 @@ static int meson_ao_cec_g12a_adap_enable(struct cec_adapter *adap, bool enable)
> regmap_write(ao_cec->regmap_cec, CECB_CTRL2,
> FIELD_PREP(CECB_CTRL2_RISE_DEL_MAX, 2));
>
> + if (ao_cec->regmap_ao_sysctrl) {
> + regmap_update_bits(ao_cec->regmap_ao_sysctrl,
> + CECB_FUNC_CFG_REG,
> + CECB_FUNC_CFG_MASK,
> + CECB_FUNC_CFG_ALL);
> + }
> +
> meson_ao_cec_g12a_irq_setup(ao_cec, true);
>
> return 0;
> @@ -685,6 +713,11 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
> goto out_probe_adapter;
> }
>
> + ao_cec->regmap_ao_sysctrl = syscon_regmap_lookup_by_phandle
> + (pdev->dev.of_node, "amlogic,ao-sysctrl");
> + if (IS_ERR(ao_cec->regmap_ao_sysctrl))
> + dev_warn(&pdev->dev, "ao-sysctrl syscon regmap lookup failed.\n");
> +
> irq = platform_get_irq(pdev, 0);
> ret = devm_request_threaded_irq(&pdev->dev, irq,
> meson_ao_cec_g12a_irq,
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-06 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 13:29 [PATCH v2 0/3] Add support of CEC wakeup on Amlogic G12 and SM1 SoCs Guillaume La Roque
2019-12-13 13:29 ` [PATCH v2 1/3] media: dt-bindings: media: meson-ao-cec: Add support of ao-sysctrl syscon Guillaume La Roque
2019-12-19 23:39 ` Rob Herring
2019-12-13 13:29 ` [PATCH v2 2/3] arm64: dts: meson-g12g12: add syscon phandle in cec node Guillaume La Roque
2019-12-13 13:29 ` [PATCH v2 3/3] media: platform: meson-ao-cec-g12a: add wakeup support Guillaume La Roque
2020-01-06 13:18 ` Neil Armstrong [this message]
2020-01-07 14:36 ` Hans Verkuil
2020-01-10 15:06 ` guillaume La Roque
2020-01-13 13:30 ` Hans Verkuil
2020-01-13 15:19 ` guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d86fe5f8-31c8-d600-8be7-75dfeb0bb45a@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).