From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E79FC7618A for ; Fri, 17 Mar 2023 08:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Di+SDmtA9OeokPEpVGVF6QD2V+VOlGtA3JbHu9s2nWU=; b=Sa0G4G8MeMLnKa HTDY+t4Y0fvXZlUJ+og2T9QRf7Z00A9E+8mrW29OHKYWMA6SKmJ+RYDzmH/Xp2u3cKBc69u5ohJ4M atPDFX682zirRrZVGo9moojEZdl8pJql+rNScD66Q/VhX0sv1bXpiJuqQd3pzGchm+OEpzITQKnN0 DgzTSmA4gwWZ/VaEXutbXFzNU8sCn37qiCXUTuWEUelSSKRDBA/ne0PvY9V2/AMHzVz6p/zUzdtAt qoxeiIjgTIFlNlqJvjChWm0yOQwggHI303jtSnyFcXxO/lZ80+ttGibYL7irgZY2ZJqGeZAMAiRJ/ omMKg5IMRXRIvQvi9rAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd5VK-001VAv-1z; Fri, 17 Mar 2023 08:32:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd5VI-001V9p-1B for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 08:32:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D54B62232; Fri, 17 Mar 2023 08:31:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F06C8C433D2; Fri, 17 Mar 2023 08:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679041919; bh=oomZDnVxdHZtUJnlVWXEtuwr3xT++1ZZD4/CrL6Q6KA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oZHAbvzuggGsV0kFkw//uH222iU6B2cdqfqqS+WMOBSAcPPZ36sGeR6ZWQlBe5V5/ xl53mRL8CXa4lKX89H74MVRR9BjfRDJtyYG/+/PL25S8TSBvJyPEMBleVfkNdCZt4U 7WcHsxKsMVkZokb42IE2Jfg1uM7+9/PFPN6V1mDeOcB5PRS8A43l1ETq53+1phO3ZG 7dFzutQO3OEq4gbTBoSjGIDsAgjDqwdN++zZ4fE8RlGRbKo+hEQM2tVOBLKgld7biN OkAD9y39ug72oyhRCzeCg8lf2mnXmAAI52tvlcrlffTnCfuTuw6MUYlTDYmxenVx2s LCn2hfN6fFrCg== Message-ID: Date: Fri, 17 Mar 2023 10:31:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Content-Language: en-US To: Md Danish Anwar , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org> <20718115-7606-a77b-7e4d-511ca9c1d798@ti.com> <468f85ad-e4b0-54e1-a5b9-4692ae8a1445@ti.com> <455440f4-7f2b-366e-53ec-700c3bb98534@kernel.org> <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com> From: Roger Quadros In-Reply-To: <22b8860c-12bd-384d-41af-93f1dde9a0fd@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_013200_486703_4E253782 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/03/2023 07:02, Md Danish Anwar wrote: > > > On 16/03/23 19:34, Roger Quadros wrote: >> >> Hi, >> >> On 16/03/2023 15:11, Md Danish Anwar wrote: >>> >>> >>> On 16/03/23 17:49, Roger Quadros wrote: >>>> >>>> >>>> On 16/03/2023 13:44, Md Danish Anwar wrote: >>>>> >>>>> On 16/03/23 17:06, Roger Quadros wrote: >>>>>> Hi, >>>>>> >>>>>> On 16/03/2023 13:05, Md Danish Anwar wrote: >>>>>>> Hi Roger, >>>>>>> >>>>>>> On 15/03/23 17:52, Roger Quadros wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 13/03/2023 13:11, MD Danish Anwar wrote: >>>>>>>>> From: Suman Anna >> > > [..] > >>> Sure, then I will use the existing enum pru_type. >>> >>> The enum pru_type is currently in drivers/remoteproc/pruss.c I will move this >>> enum definition from there to include/linux/remoteproc/pruss.h >> >> There are 2 public pruss.h files. >> include/linux/remoteproc/pruss.h >> and >> include/linux/pruss_driver.h >> >> Why is that and when to use what? >> > > The include/linux/remoteproc/pruss.h file was introduced in series [1] as a > public header file for PRU_RPROC driver (drivers/remoteproc/pru_rproc.c) > > The second header file include/linux/pruss_driver.h was introduced much earlier > as part of [2] , "soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs". > > As far as I can see, seems like pruss_driver.h was added as a public header > file for PRUSS platform driver (drivers/soc/ti/pruss.c) > > [1] https://lore.kernel.org/all/20230106121046.886863-1-danishanwar@ti.com/ > [2] https://lore.kernel.org/all/1542886753-17625-7-git-send-email-rogerq@ti.com/ Thanks. "include/linux/remoteproc/pruss.h" seems appropriate for enum pru_type. cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel