From: Marc Zyngier <maz@kernel.org>
To: Makarand Pawagi <makarand.pawagi@nxp.com>
Cc: calvin.johnson@nxp.com, stuyoder@gmail.com,
nleeder@codeaurora.org, ioana.ciornei@nxp.com,
cristian.sovaiala@nxp.com, guohanjun@huawei.com, will@kernel.org,
lorenzo.pieralisi@arm.com, pankaj.bansal@nxp.com,
jon@solid-run.com, linux@armlinux.org.uk,
linux-acpi@vger.kernel.org, lenb@kernel.org,
jason@lakedaemon.net, V.Sethi@nxp.com, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, laurentiu.tudor@nxp.com,
netdev@vger.kernel.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org,
shameerali.kolothum.thodi@huawei.com, sudeep.holla@arm.com,
robin.murphy@arm.com
Subject: Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc
Date: Tue, 28 Jan 2020 10:58:29 +0000 [thread overview]
Message-ID: <d8aa6658f8f3763e28bb5d4884b9b686@kernel.org> (raw)
In-Reply-To: <1580198925-50411-1-git-send-email-makarand.pawagi@nxp.com>
On 2020-01-28 08:08, Makarand Pawagi wrote:
> ACPI support is added in the fsl-mc driver. Driver will parse
> MC DSDT table to extract memory and other resorces.
>
> Interrupt (GIC ITS) information will be extracted from MADT table
> by drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c.
>
> IORT table will be parsed to configure DMA.
>
> Signed-off-by: Makarand Pawagi <makarand.pawagi@nxp.com>
> ---
> drivers/acpi/arm64/iort.c | 53 +++++++++++++++++++++
> drivers/bus/fsl-mc/dprc-driver.c | 3 +-
> drivers/bus/fsl-mc/fsl-mc-bus.c | 48 +++++++++++++------
> drivers/bus/fsl-mc/fsl-mc-msi.c | 10 +++-
> drivers/bus/fsl-mc/fsl-mc-private.h | 4 +-
> drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 71
> ++++++++++++++++++++++++++++-
> include/linux/acpi_iort.h | 5 ++
> 7 files changed, 174 insertions(+), 20 deletions(-)
A general comment when you do this kind of work:
Do not write a single patch that impacts at least three different
subsystems. As it is, it is unmergeable.
Now the real question is *WHY* we need this kind of monstruosity?
ACPI deals with PCI, not with exotic busses and whatnot. If you want
to be creative, DT is your space. ACPI is designed to be plain and
boring, and that's how we like it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-28 10:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 8:08 [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc Makarand Pawagi
2020-01-28 10:58 ` Marc Zyngier [this message]
2020-01-28 11:09 ` Lorenzo Pieralisi
2020-01-31 10:35 ` [EXT] " Makarand Pawagi
2020-01-31 11:06 ` Lorenzo Pieralisi
2020-01-31 11:06 ` Marc Zyngier
2020-01-31 12:01 ` Ard Biesheuvel
2020-01-31 12:28 ` Jon Nettleton
2020-01-31 12:48 ` Robin Murphy
2020-01-31 13:11 ` Jon Nettleton
2020-01-31 13:29 ` Ard Biesheuvel
2020-01-31 13:39 ` Robin Murphy
2020-01-31 14:29 ` Andrew Lunn
2020-01-31 14:47 ` Will Deacon
2020-01-31 15:09 ` Andrew Lunn
2020-01-31 15:14 ` Jon Nettleton
2020-01-31 15:41 ` Andrew Lunn
2020-01-31 15:39 ` Russell King - ARM Linux admin
2020-01-31 15:15 ` Russell King - ARM Linux admin
2020-01-31 15:40 ` Jakub Kicinski
2020-02-01 11:49 ` Russell King - ARM Linux admin
2020-02-01 17:36 ` Jakub Kicinski
2020-02-14 15:05 ` Pankaj Bansal
2020-02-14 15:54 ` Marc Zyngier
2020-02-14 15:58 ` Pankaj Bansal
2020-02-14 16:19 ` Lorenzo Pieralisi
2020-02-14 16:35 ` Pankaj Bansal
2020-02-14 17:49 ` Lorenzo Pieralisi
2020-02-17 12:35 ` Pankaj Bansal
2020-02-17 15:25 ` Lorenzo Pieralisi
2020-02-17 15:35 ` Marc Zyngier
2020-02-17 16:26 ` Lorenzo Pieralisi
2020-02-18 8:02 ` Pankaj Bansal (OSS)
2020-02-14 16:29 ` Robin Murphy
[not found] <VI1PR04MB5135D7D8597D33DB76DA05BDB0110@VI1PR04MB5135.eurprd04.prod.outlook.com>
2020-02-18 12:24 ` Hanjun Guo
2020-02-18 12:48 ` Pankaj Bansal (OSS)
2020-02-18 14:46 ` Lorenzo Pieralisi
2020-02-18 15:15 ` Robin Murphy
2020-02-19 3:33 ` Pankaj Bansal (OSS)
2020-02-18 15:24 ` Diana Craciun OSS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8aa6658f8f3763e28bb5d4884b9b686@kernel.org \
--to=maz@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=calvin.johnson@nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=guohanjun@huawei.com \
--cc=ioana.ciornei@nxp.com \
--cc=jason@lakedaemon.net \
--cc=jon@solid-run.com \
--cc=laurentiu.tudor@nxp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=makarand.pawagi@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=nleeder@codeaurora.org \
--cc=pankaj.bansal@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=stuyoder@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).