From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03B4CC433EF for ; Tue, 19 Apr 2022 14:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D/G7dgY0pkD9a7LRe0MKzOj8VpJjfwQhLRXV3cpXC7I=; b=Ws0/sgrx85Y3pP kxukeOmn/hyYGrdCjrtMg3Xu26WnPdbHzoSBhUNVJSe43w3pjXq1X8G9q5lZCVXQMRHyPXKnwHpm8 uf51fPljBOOVL4+vbkeMlv4dTZsNY2N6M2a6IUDFsG9G4bfZOyLE1vSP1CCOvYJYrMgrlOSKORC3b 2srBuKSkUexV4Wof/vw3SB9o+4MbfBYCDY5ChhvgFnJirluU4rhQ7QPwy8CRqj7x9mHHfZtjNevz7 0lVrPPUMCN0JCMkVFacTYA6+rqaABPTGBzJDaqt2IYoRcZh5P2wB7C7waaHQhbmdBtV2G82GjM439 NnZgvPFGqt4wP2ajickQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpE7-004QNF-Bg; Tue, 19 Apr 2022 14:53:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngoKc-00435v-6a for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 13:55:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4E88E1063; Tue, 19 Apr 2022 06:55:47 -0700 (PDT) Received: from [10.32.36.25] (e121896.Emea.Arm.com [10.32.36.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F03B83F766; Tue, 19 Apr 2022 06:55:43 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 14:55:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH V5 1/8] perf: Add system error and not in transaction branch types Content-Language: en-US To: Anshuman Khandual , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, peterz@infradead.org, acme@kernel.org Cc: Robin Murphy , Suzuki Poulose , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org References: <20220404045046.634522-1-anshuman.khandual@arm.com> <20220404045046.634522-2-anshuman.khandual@arm.com> From: James Clark In-Reply-To: <20220404045046.634522-2-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_065550_385059_F7E5CF3D X-CRM114-Status: GOOD ( 24.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/04/2022 05:50, Anshuman Khandual wrote: > This expands generic branch type classification by adding two more entries > there in i.e system error and not in transaction. This also updates the x86 > implementation to process X86_BR_NO_TX records as appropriate. This changes > branch types reported to user space on x86 platform but it should not be a > problem. The possible scenarios and impacts are enumerated here. > > -------------------------------------------------------------------------- > | kernel | perf tool | Impact | > -------------------------------------------------------------------------- > | old | old | Works as before | > -------------------------------------------------------------------------- > | old | new | PERF_BR_UNKNOWN is processed | > -------------------------------------------------------------------------- > | new | old | PERF_BR_NO_TX are blocked via old PERF_BR_MAX | > -------------------------------------------------------------------------- > | new | new | NO_TX are recognized | > -------------------------------------------------------------------------- > > When PERF_BR_NO_TX is blocked via old PERF_BR_MAX (new kernel with old perf > tool) the user space might throw up an warning complaining about an > unrecognized branch types being reported, but it's expected. PERF_BR_SERROR > & PERF_BR_NO_TX branch types will be used for BRBE implementation on arm64 > platform. > > PERF_BR_NO_TX complements 'abort' and 'in_tx' elements in perf_branch_entry > which represent other transaction states for a given branch record. Because > this completes the transaction state classification. > > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Thomas Gleixner > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-perf-users@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Reviewed-by: James Clark > --- > arch/x86/events/intel/lbr.c | 2 +- > include/uapi/linux/perf_event.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c > index fe1742c4ca49..30dcd18936d5 100644 > --- a/arch/x86/events/intel/lbr.c > +++ b/arch/x86/events/intel/lbr.c > @@ -1336,7 +1336,7 @@ static int branch_map[X86_BR_TYPE_MAP_MAX] = { > PERF_BR_IND_CALL, /* X86_BR_IND_CALL */ > PERF_BR_UNKNOWN, /* X86_BR_ABORT */ > PERF_BR_UNKNOWN, /* X86_BR_IN_TX */ > - PERF_BR_UNKNOWN, /* X86_BR_NO_TX */ > + PERF_BR_NO_TX, /* X86_BR_NO_TX */ > PERF_BR_CALL, /* X86_BR_ZERO_CALL */ > PERF_BR_UNKNOWN, /* X86_BR_CALL_STACK */ > PERF_BR_IND, /* X86_BR_IND_JMP */ > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index d37629dbad72..26d8f0b5ac0d 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -253,6 +253,8 @@ enum { > PERF_BR_COND_RET = 10, /* conditional function return */ > PERF_BR_ERET = 11, /* exception return */ > PERF_BR_IRQ = 12, /* irq */ > + PERF_BR_SERROR = 13, /* system error */ > + PERF_BR_NO_TX = 14, /* not in transaction */ > PERF_BR_MAX, > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel