From: Keisuke Nishimura <keisuke.nishimura@inria.fr>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Julia Lawall" <Julia.Lawall@inria.fr>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jani Nikula" <jani.nikula@intel.com>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Viresh Kumar" <vireshk@kernel.org>,
"Shiraz Hashim" <shiraz.linux.kernel@gmail.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"SoC Team" <soc@kernel.org>
Subject: Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")
Date: Thu, 2 Jun 2022 07:28:29 +0900 [thread overview]
Message-ID: <d971a684-ccd9-3839-1e30-c166fd55cf49@inria.fr> (raw)
In-Reply-To: <CAHk-=wgO0V9OdY+DFm-f0qZYMyFSm0ptReO+_qgSTEpBLtFV7Q@mail.gmail.com>
On 2022/06/01 1:41, Linus Torvalds wrote:
> On Tue, May 31, 2022 at 1:04 AM Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> As an experiment: what kind of results would we get when looking
>> for packed structures and unions that contain any of these:
>
> I don't think we have that. Not only because it would already cause
> breakage, but simply because the kinds of structures that people pack
> aren't generally the kind that contain these kinds of things.
>
> That said, you might have a struct that is packed, but that
> intentionally aligns parts of itself, so it *could* be valid.
>
> But it would probably not be a bad idea to check that packed
> structures/unions don't have atomic types or locks in them. I _think_
> we're all good, but who knows..
I am Julia's student at INRIA and I heard from her that there is an
opportunity to use Coccinelle to find specific types in packed struct or
enum.
I found 13 definitions of packed structure that contains:
> - spinlock_t
> - atomic_t
> - dma_addr_t
> - phys_addr_t
> - size_t
> - struct mutex
> - struct device
- raw_spinlock_t
== Results ==
security/tomoyo/common.h: atomic_t in tomoyo_shared_acl_head
drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h: spinlock_t in
key_map
include/linux/ti-emif-sram.h: phys_addr_t in ti_emif_pm_data
drivers/scsi/wd719x.h: dma_addr_t in wd719x_scb
drivers/net/wireless/intel/ipw2x00/ipw2200.h: dma_addr_t in clx2_queue
drivers/infiniband/hw/irdma/osdep.h: dma_addr_t in irdma_dma_mem
drivers/infiniband/core/mad_priv.h: size_t in ib_mad_private
drivers/crypto/qat/qat_common/qat_asym_algs.c:
- dma_addr_t in qat_rsa_ctx
- dma_addr_t in qat_dh_ctx
drivers/atm/idt77252.h: dma_addr_t in idt77252_skb_prv
arch/s390/include/asm/kvm_host.h: atomic_t in kvm_s390_sie_block
drivers/net/wireless/ath/ath10k/core.h: dma_addr_t in ath10k_skb_cb
drivers/net/wireless/ath/ath11k/core.h: dma_addr_t in ath10k_skb_cb
drivers/crypto/ccp/ccp-dev.h: dma_addr_t in ccp_dma_info
The last 3 structures have a dma_adddr_t member defined as the first
member variable. Most of the others also seems valid.
I used this SmPL script to find them:
@e1@
type T;
identifier i;
position p;
attribute name __packed;
@@
T@p {
...
(
atomic_t i;
|
raw_spinlock_t i;
|
struct mutex i;
|
spinlock_t i;
|
dma_addr_t i;
|
phys_addr_t i;
|
size_t i;
|
struct device i;
)
...
}
__packed;
@e2@
type T;
identifier i;
position p;
@@
T@p {
...
(
atomic_t i;
|
raw_spinlock_t i;
|
struct mutex i;
|
spinlock_t i;
|
dma_addr_t i;
|
phys_addr_t i;
|
size_t i;
|
struct device i;
)
...
}
__attribute__((
(
pack
|
__pack__
)
,... ));
@script:python@
ps <<e1.p;
@@
for p in ps:
print p.file, p.line
@script:python@
ps <<e2.p;
@@
for p in ps:
print p.file, p.line
Keisuke
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-01 22:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YpCUzStDnSgQLNFN@debian>
[not found] ` <CAHk-=wg0uGAX5DYZq+tY2KeUAR8DtR91YE1y9CkPMKkKOyE4jg@mail.gmail.com>
[not found] ` <CADVatmNGPbSdRNQuwJEWAaPtqb3vBYRjvsuBpoRUnhEHj=X5GQ@mail.gmail.com>
[not found] ` <CAHk-=wisQd8yiPX=SsK3eFiakKo713hq4SyqPWsJ-oyAmLFefQ@mail.gmail.com>
[not found] ` <YpIR67FMtTGCwARZ@debian>
[not found] ` <CAHk-=wjuyHE=1wLgHncub8FfgeyYqfWYsy4-YrhAvq9991h_Aw@mail.gmail.com>
2022-05-28 18:08 ` mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers") Linus Torvalds
2022-05-28 18:58 ` Arnd Bergmann
2022-05-28 20:31 ` Linus Torvalds
2022-05-28 21:08 ` Arnd Bergmann
2022-05-30 9:31 ` Jani Nikula
2022-05-30 9:33 ` Jani Nikula
2022-05-30 12:43 ` Arnd Bergmann
2022-05-30 13:10 ` Jani Nikula
2022-05-30 13:35 ` Arnd Bergmann
2022-05-30 14:08 ` Jani Nikula
2022-05-30 14:26 ` Arnd Bergmann
2022-05-31 6:26 ` Julia Lawall
2022-05-31 8:04 ` Arnd Bergmann
2022-05-31 16:41 ` Linus Torvalds
2022-06-01 22:28 ` Keisuke Nishimura [this message]
2022-06-02 1:08 ` Linus Torvalds
2022-06-02 7:38 ` Arnd Bergmann
2022-06-02 11:21 ` Tetsuo Handa
2022-06-02 12:11 ` Arnd Bergmann
2022-06-02 13:18 ` Ard Biesheuvel
2022-06-02 12:19 ` Christoph Hellwig
2022-06-06 10:51 ` Keisuke Nishimura
2022-05-30 16:56 ` Russell King (Oracle)
2022-05-30 16:54 ` Russell King (Oracle)
2022-05-30 16:53 ` Russell King (Oracle)
2022-05-28 20:32 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d971a684-ccd9-3839-1e30-c166fd55cf49@inria.fr \
--to=keisuke.nishimura@inria.fr \
--cc=Julia.Lawall@inria.fr \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).