From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: zynq: DT: Add CAN node
Date: Thu, 24 Jul 2014 08:55:21 -0700 [thread overview]
Message-ID: <d973d7c8-30e7-458e-9d57-15da917cde04@BL2FFO11FD030.protection.gbl> (raw)
In-Reply-To: <2fe3a869-d17c-4521-a5c1-7c347ae34726@BN1BFFO11FD060.protection.gbl>
On Thu, 2014-07-24 at 08:44AM +0200, Michal Simek wrote:
> On 07/23/2014 06:07 PM, S?ren Brinkmann wrote:
> > On Wed, 2014-07-23 at 03:05PM +0200, Michal Simek wrote:
> >> Add node describing Zynq's CAN controller.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >> arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
> >> 1 file changed, 12 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> >> index 366ca6434f54..2287d9b4ed1a 100644
> >> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> >> @@ -71,7 +71,18 @@
> >> interrupts = <0 7 4>;
> >> interrupt-parent = <&intc>;
> >> clocks = <&clkc 12>;
> >> - };
> >> + };
> >> +
> >> + can0: can at e0008000 {
> >> + compatible = "xlnx,zynq-can-1.0";
> >> + clocks = <&clkc 19>, <&clkc 36>;
> >> + clock-names = "can_clk", "pclk";
> >> + reg = <0xe0008000 0x1000>;
> >> + interrupts = <0 28 4>;
> >> + interrupt-parent = <&intc>;
> >> + tx-fifo-depth = <0x40>;
> >> + rx-fifo-depth = <0x40>;
> >> + };
> >
> > What about the second CAN core? You also probably want to add
> > 'status = "disabled"' in the dtsi.
>
> Second can core - yes.
>
> I can add status = "disabled" but then question is if make
> sense to change status for any zynq dts file. Or just
> keep enable both.
>
> In our repo is enabled can0 on zc702.
>
> What do you think?
Well, it should be enabled on boards that have CAN pinned out. Does any
of our boards have that?
S?ren
next prev parent reply other threads:[~2014-07-24 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 13:05 [PATCH] ARM: zynq: DT: Add CAN node Michal Simek
2014-07-23 16:07 ` Sören Brinkmann
[not found] ` <20140723160702.GA14564@xsjandreislx>
2014-07-24 6:44 ` Michal Simek
2014-07-24 15:55 ` Sören Brinkmann [this message]
2014-07-25 6:47 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d973d7c8-30e7-458e-9d57-15da917cde04@BL2FFO11FD030.protection.gbl \
--to=soren.brinkmann@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).