From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4EEFC433F5 for ; Mon, 10 Oct 2022 16:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BxkeFbb37vfgD8w2HxL0D+SkPLCg25ctSnBtauU+H+g=; b=ZQ0D2PwwhidXYL 6ZTI3Q1gMEB70cyEuohoJyj4hBOMNLnjcKw7YLpbvRnslJny62FkbAM7wB/gWyusHcOKf41RjR72P ZjaD4SBadFCnaEN6GtvxmbImRIKX2xqV5dreprMVUpDQE/ionRXqGbs7ZOBiYdCzAfIIWCIgQ2yeq Oc1YSWP9VxzGOUaIkEMtUT8bYlBP1hVns7KKpwm34xqh2egBnE2RyWw76SW0i3ec8Snrs4wEyO8oC 9uBDkwbG/msODIBNCNcbjkvTt8VFTxh8Jrs/EewxmORcojuIVr942RFAPfO54GThKJikgLVVcCF+n TqYjk8j+5bqoNoKxkveQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohw1Y-001Zo1-VI; Mon, 10 Oct 2022 16:53:05 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohw1W-001Zm8-92; Mon, 10 Oct 2022 16:53:04 +0000 Received: from [192.168.1.138] ([37.4.248.18]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MWiUg-1ofi0u2rqS-00X4lf; Mon, 10 Oct 2022 18:52:40 +0200 Message-ID: Date: Mon, 10 Oct 2022 18:52:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate Content-Language: en-US To: Maxime Ripard , Daniel Vetter , Florian Fainelli , David Airlie , Broadcom internal kernel review list , Michael Turquette , Scott Branden , Stephen Boyd , Emma Anholt , Ray Jui , Maxime Ripard Cc: linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Dom Cobley , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org References: <20220815-rpi-fix-4k-60-v2-0-983276b83f62@cerno.tech> <20220815-rpi-fix-4k-60-v2-3-983276b83f62@cerno.tech> From: Stefan Wahren In-Reply-To: <20220815-rpi-fix-4k-60-v2-3-983276b83f62@cerno.tech> X-Provags-ID: V03:K1:xVuX/w3ngCM1Xs7bP8l36ga2yBUkRfiC5SZVOLDFVuhbEbaUOi8 Ht7lb7ZE0v89ORFIUFBR3EcZ9hByi6Wj9zTVx7WihMoqFLggY4vIEi3SRcUo5lzctKBWVDl L8Gov+ZguoxDyaPpHg1BGnNdtyuV4Hhzy7JnX503K6i9Kqtpfv8Rh3VcY1VLf7i3vxUW7kD FfUhE94nGdfGvl/vyyTZg== X-UI-Out-Filterresults: notjunk:1;V03:K0:5jfDTjv99BA=:IqmBkuyekdtld/M89dBtQF Re7hifvYF4SBrKs+GlGnEcCgnpAL27uhTcZxU6FwVTA1Atb1kKb3c6KYguBswF3V+LHTMFIE8 iKC/Z25dkIn6jUSZcg+W8T5FLEat5RkJbiUpFM/YyWHDc1hG4ujgoLK9LuurOH7uiFdwIw2bw HizfQ8BBCHTJlpBNxhLDv9igdI3GKH3En7g6MXgd0q0Dtb+xFFS8luEGgozvqQXgIa1Yxufpr 3RV8WkouAR7J1uqEDaJrPGHPxFIsmvn3PYzaL0DZQr04PCKdFHq9nZWDWv+atNLguhDzPY4Ox Q8/P4OhVfdSuAVD2dKtPVB+RHOK3PbeQX5PXUTnd5c8oZueCeG9AFZeblw/9S6xX0yecvr1Zn NsfpxZTGks4bNSTtS49ngIgIVvCa8VBTVG7N/QRNNVmJof5lLPQoxzpPneg8zr+1cPql7B/Xe 3pBjaefrK4IfV+omLR/Y5WM7u0AtLKTjsKPFcR5J/CtBQGnoQ1NOjIXdWLVrHZ2lhdCaSFUzD a0eWFkkh5fsYlNdY3em51JWS0ZpllGLqZlFCiBHsonj53esckRkG/xtXWrSoCRPBJwrpYjO/Q 6QW3BLaXZNvNd7eXY7+jMAOwxF+sh5qEJo8xdixvnvwki7jZqmXfTJASGhjVi7NrQg85mDKge Dj7HStZnsIgmNFYivHIjF5zCbnNkwk2qoEO7AmJ5EuoAd7ti9p3t6TuFcwr8B4aupReULQszC yp/oR6C1WX6AzW6Lco3hq4duehQwPdrVXCIntIJALv9JkZs3IfSXbeDD5mYKnC9z5eDzf4t9d 0Z/ASLcbS5dnvytm4o+eTp6AuRPqw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_095302_633878_502A4EB5 X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, Am 20.09.22 um 14:50 schrieb Maxime Ripard: > The firmware allows to query for its clocks the operating range of a > given clock. We'll need this for some drivers (KMS, in particular) to > infer the state of some configuration options, so let's create a > function to do so. > > Signed-off-by: Maxime Ripard > > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c > index b916e1e171f8..c4b9ea70f5a7 100644 > --- a/drivers/firmware/raspberrypi.c > +++ b/drivers/firmware/raspberrypi.c > @@ -228,6 +228,21 @@ static void rpi_register_clk_driver(struct device *dev) > -1, NULL, 0); > } > > +unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, unsigned int id) > +{ > + struct rpi_firmware_clk_rate_request msg = > + RPI_FIRMWARE_CLK_RATE_REQUEST(id); > + int ret; > + > + ret = rpi_firmware_property(fw, RPI_FIRMWARE_GET_MAX_CLOCK_RATE, > + &msg, sizeof(msg)); > + if (ret) > + return 0; > + > + return le32_to_cpu(msg.rate); > +} > +EXPORT_SYMBOL_GPL(rpi_firmware_clk_get_max_rate); > + > static void rpi_firmware_delete(struct kref *kref) > { > struct rpi_firmware *fw = container_of(kref, struct rpi_firmware, > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h > index 74c7bcc1ac2a..10248c370229 100644 > --- a/include/soc/bcm2835/raspberrypi-firmware.h > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > @@ -154,12 +154,32 @@ enum rpi_firmware_clk_id { > RPI_FIRMWARE_NUM_CLK_ID, > }; > > +/** > + * struct rpi_firmware_clk_rate_request - Firmware Request for a rate > + * @id: ID of the clock being queried > + * @rate: Rate in Hertz. Set by the firmware. > + * > + * Used by @RPI_FIRMWARE_GET_CLOCK_RATE, @RPI_FIRMWARE_GET_CLOCK_MEASURED, > + * @RPI_FIRMWARE_GET_MAX_CLOCK_RATE and @RPI_FIRMWARE_GET_MIN_CLOCK_RATE. > + */ > +struct rpi_firmware_clk_rate_request { > + __le32 id; > + __le32 rate; > +} __packed; > + > +#define RPI_FIRMWARE_CLK_RATE_REQUEST(_id) \ > + { \ > + .id = _id, \ > + } > + > #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE) > int rpi_firmware_property(struct rpi_firmware *fw, > u32 tag, void *data, size_t len); > int rpi_firmware_property_list(struct rpi_firmware *fw, > void *data, size_t tag_size); > void rpi_firmware_put(struct rpi_firmware *fw); > +unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, > + unsigned int id); > struct device_node *rpi_firmware_find_node(void); > struct rpi_firmware *rpi_firmware_get(struct device_node *firmware_node); > struct rpi_firmware *devm_rpi_firmware_get(struct device *dev, > @@ -179,6 +199,12 @@ static inline int rpi_firmware_property_list(struct rpi_firmware *fw, > > static inline void rpi_firmware_put(struct rpi_firmware *fw) { } > > +static inline unsigned int rpi_firmware_clk_get_max_rate(struct rpi_firmware *fw, > + unsigned int id) > +{ > + return UINT_MAX; In case the driver is disabled the function return UINT_MAX, but in case the firmware doesn't support RPI_FIRMWARE_GET_MAX_CLOCK_RATE it returns 0. This looks a little bit inconsistent to me. > +} > + > static inline struct device_node *rpi_firmware_find_node(void) > { > return NULL; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel