From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28223C433E0 for ; Mon, 29 Jun 2020 16:59:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBA04255A1 for ; Mon, 29 Jun 2020 16:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RThFEio4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BdCW9dI6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBA04255A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E42bEEZNrlipl1cgIQEA2eGCuRhrPudzkuvmvAUJRA8=; b=RThFEio4P4jO8HGJY7rPAIScO 4mzOsNUEbao5UjK3T0GOz1+TOFEp+aCTmcD0b84p1cw6WTYm977XrGhwjfE55IBaQavGNqxfxltu/ akXD5AzfAPOmuaMdiWjB8pHd5d+pRMQcEZus2vKYMiYsI9yFTWcBTo8uE/AuvnFLIM0bbk1qf86SQ 6Z28Ni+G+T+VgmlR2DGyCgv7caNTlhasYcpzQQ5kKXNazS3rgqf3tXob3tbQtMBpcsia70hqVOdf+ ZaiSMJBJ9JsN0WoMFdKH0ZXuKK/Dv3Eym6yIQpGs+In7Yz/4YZEIyBrmFIYikUM7MgymZb3IxglrU V/OyplaWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpx76-000897-8O; Mon, 29 Jun 2020 16:58:36 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpx73-00088F-8q; Mon, 29 Jun 2020 16:58:34 +0000 Received: by mail-wr1-x442.google.com with SMTP id z13so17248779wrw.5; Mon, 29 Jun 2020 09:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EXieR2sKCVcuynFXj2Dp91Rx/LX+vZuPzCYIluYGYqw=; b=BdCW9dI6O2ID3uqf56vYmvG7S+fdM8QNerUMd1X2JionIRz+qIPUlM5rWCSvL/+UCt zvwMhhwE/TXKbCYG9ID7I9ygUQH+8T9k9KYMvWu+JHNlTbJIFYwJIgVJs5BgGjKU86gf kXrJckQyt3K2z59k0OFjRJxmE0ADLVeSmMYS17m3Rhvdan9zDd7VM8GaaUTAw9fApXHP PE+lFtfE8xP6ROi7X2UXlG6lttCibWZW/LgUXkH+Sm/g9OgnJAeD57hVdtUg2iLX/Egu W9ZG/B64qi8wc2xkGhqiFdCxoPVcr1rpqZi1VS2u4Kt5v/33rcpSfb2H78HjL/acb7KJ 4j8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EXieR2sKCVcuynFXj2Dp91Rx/LX+vZuPzCYIluYGYqw=; b=WtAxtj7sDi8k5OKQl6qbDqGoB2sG9dY1u6ZIR1FgZsabvrv8ZCJL5+0zF7rG1WYYvF ar0QbL8sa5Vvx6GYIPZNb+AoMeJFx7kP/Ua4j6sH89pbO4YLKE1QMsSLZ2roIwfGZVUS paidRIOg+NlsZf2NG2OPL/iQUWcbiPESQWH87uUnvHt8IS3QfVVM3QKUv47RkhzDxDKv bTxIergl151uxhdBDX9d+jy4OX03YY+F++jXZVv++1iHBkv4iTQ4zDz7kwAVouGD2Kc4 HIfQ6HNj0c7iZOXX5PL20ySk8Y1urbblpWslFaiY3lrFuuiStOhz118RGROoODRwvh8i cIaw== X-Gm-Message-State: AOAM531RmmcOnReyxSnNiNYNdh8wsfUZu5x8iZtN+he52D64UunOjqqc wfsj/ZyFZvqgBBZRkQNcfI2CAyjI X-Google-Smtp-Source: ABdhPJyJ5w3YtAo+uLmhSmj4foLwUKDf1M6Afay3gViElI8XhO8rG9IkHCGg5/fyGiENO61wD6cZDw== X-Received: by 2002:a5d:6802:: with SMTP id w2mr17172707wru.88.1593449912197; Mon, 29 Jun 2020 09:58:32 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c20sm460651wrb.65.2020.06.29.09.58.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 09:58:31 -0700 (PDT) Subject: Re: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free() To: Bartosz Golaszewski , Jeff Kirsher , "David S . Miller" , Jakub Kicinski , John Crispin , Sean Wang , Mark Lee , Matthias Brugger , Heiner Kallweit , Andrew Lunn , Russell King , Rob Herring , Frank Rowand References: <20200629120346.4382-1-brgl@bgdev.pl> <20200629120346.4382-3-brgl@bgdev.pl> From: Florian Fainelli Message-ID: Date: Mon, 29 Jun 2020 09:58:26 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200629120346.4382-3-brgl@bgdev.pl> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/29/2020 5:03 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The idea behind devres is that the release callbacks are called if > probe fails. As we now check the return value of ixgbe_mii_bus_init(), > we can drop the call devm_mdiobus_free() in error path as the release > callback will be called automatically. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel