From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DAAC433E3 for ; Tue, 28 Jul 2020 15:01:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0367E206D8 for ; Tue, 28 Jul 2020 15:01:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R/cqCh2J"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Gy0qVxQM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0367E206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=880j7aPzRtppd5L7NtQNC+YOn/Up7a+AXZZR1YuNWMw=; b=R/cqCh2JTUk3efjUfNjCSdGcJ 7aISbvjChhSYGevlli2K1kyWxjWHVMVItVvukhzugb1tBIIiaD955S+F45qvyCfFXbbRWKlaFn/gB kmZ6p38AyT+eiFz9mdA0ly1nohjite42VGtRNyIRisgrvJ2RhqDkbQlV+/L6PWRioteZtCqRWqiAR bee9BXYkYqUEvj9hOMaHKcnPS+z0ZWkuPu/g51BeFC0pCK1CU2HaogRuqW3kLrSKK06pD65q1ab5J Sr3M+tvtRijmLZOtZ6oa4nAthJfzx0A7luqmeZRuO1K47aGJGuYkwNTl8MXi69kYjDTCHULLCmipv ratc+kZUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0R4o-00058C-CS; Tue, 28 Jul 2020 14:59:34 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0R4C-000555-F3 for linux-arm-kernel@lists.infradead.org; Tue, 28 Jul 2020 14:59:00 +0000 Received: from [192.168.254.32] (unknown [47.187.206.220]) by linux.microsoft.com (Postfix) with ESMTPSA id ADCF720B4908; Tue, 28 Jul 2020 07:58:53 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ADCF720B4908 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1595948334; bh=flkKl1tOpheQSP4WOnmrqgHroHnRne5MuepSoCZsgK0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Gy0qVxQM4lbk87aNiGP/UQJRoHbBkHY8gEBUc9LVHq/JBTxqOXbHBPRz/CbPhTddU WUFnsrL5KmEIrg/s5uke5Hfo8z21XAplUP+QdHA3P0SR/cp8ACNVes2cfOeGq1ux6M Pg8UVJmBdVVeaMAdNOiCJj8wDe04E7A1iipg0+LM= Subject: Re: [PATCH v1 1/4] [RFC] fs/trampfd: Implement the trampoline file descriptor API To: Oleg Nesterov References: <20200728131050.24443-1-madvenka@linux.microsoft.com> <20200728131050.24443-2-madvenka@linux.microsoft.com> <20200728145013.GA9972@redhat.com> From: "Madhavan T. Venkataraman" Message-ID: Date: Tue, 28 Jul 2020 09:58:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728145013.GA9972@redhat.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200728_105857_131846_BCA3C406 X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks. See inline.. On 7/28/20 9:50 AM, Oleg Nesterov wrote: > On 07/28, madvenka@linux.microsoft.com wrote: >> +bool is_trampfd_vma(struct vm_area_struct *vma) >> +{ >> + struct file *file = vma->vm_file; >> + >> + if (!file) >> + return false; >> + return !strcmp(file->f_path.dentry->d_name.name, trampfd_name); > Hmm, this looks obviously wrong or I am totally confused. A user can > create a file named "[trampfd]", mmap it, and fool trampfd_fault() ? > > Why not > > return file->f_op == trampfd_fops; This is definitely the correct check. I will fix it. > > ? > >> +EXPORT_SYMBOL_GPL(is_trampfd_vma); > why is it exported? This is in common code and is called by arch code. Should I not export it? I guess since the symbol is not used by any modules, I don't need to export it. Please confirm and I will fix this. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel