From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A811FC3A59E for ; Wed, 4 Sep 2019 23:18:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EBE321881 for ; Wed, 4 Sep 2019 23:18:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="af57DYD+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AKGsaHbL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EBE321881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1mSVH0nZZbL3fPKyB6rRO//yKDUqh72m7LAvX150C6Q=; b=af57DYD+NumoQh iHeNEdNTyGKpo9rnJ8gsbI4ovVWZzh4wbRT8mWuwADfVzivD+GcTqRf/6IqDDmd+t92JblhF7uhz8 XMQoTGfgOEBmToaahkj5sF28sRxersfJI7xZEsv1L+Hh4mYuDn0yLAXtJhA1Ljcdw1XNomUWv52Dc sZ9FcUWO8MZPJgEKW4K97VYxJfECg9p05MwgG5cLMSsk2NCq562sw9cjsf7GgMuvgzm4QC7hdocXW Cl2gxGh5T96Sz39ssCd4ZrkqWsG+2rY2av+JPpXW04pJ03XZb74dJIG9vRmOh9TiMrN1eNIs+/ui9 XU4csmrMEBiUsMFuOfVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5eXD-0007nC-1O; Wed, 04 Sep 2019 23:17:55 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5eX8-0007iy-89 for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2019 23:17:52 +0000 Received: by mail-pf1-x443.google.com with SMTP id h195so417564pfe.5 for ; Wed, 04 Sep 2019 16:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=9R72raBBWXijV+vBxS2q3Hmwuxv9Ffre6Ti1aTb9Nhs=; b=AKGsaHbLbruRWWZut5eEkFINbN1RAtp5Gc5P4ly1St6QoLFKbCCPMk1sCW6yIOJmU8 tgKoh4yl45sNzYiOglayAY5CL082kzY1Wz8BajqyKCYe1j0o1iBp/BhUdx4PkdtJovlo gddskujNDf7UReyFhrKEXjpli2ejZeidxVi5sNsASu+MTUwt9s+GokTa7o04VKCCSNdO iSW3KLaJcTPQwfTyiUfH3u2uJFmwy2eDCGEbwP3ASCSTqzfC6REQqGAEyEVeGHMcL673 sknyKtVLzla3A9W1v0ng4vS31x4w609YoumtFD6i0+aCcpwFyboKpck83kPrsJKNAGOV mJ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=9R72raBBWXijV+vBxS2q3Hmwuxv9Ffre6Ti1aTb9Nhs=; b=KQXleQFXpKWZrN7d1l46r/q/sUsQ0Ci6SBFvaXmGIRyBz5TXW+T4sCzDhRJssZLSal k2Qu5AU6BFyEGiKVFTqnAC77+gW9zAkLr9jITEzJlJNj/zjXyAzYXsSNpilloO+EH0SO h0uVBYKDx0Iv97X314OaaqteAXwdORvbqzIrp75p+jBNra8cx1/bmJciIQ5Y+ufzCtRu XYAjHgEjqdrJVMjLIldgEC1dZUacJQ6MlQxWipbChvkfpZK6w7viZA/xO+anCJOf4aBd TGu3fP//6khDp/BXnGb+8nGvZ60m8sNsnSFroGp8jrkpaBDhyId0VWL1CnjtTbzF8VjD nyBw== X-Gm-Message-State: APjAAAVlFqUuTDxUyYjDyREgOeuTtJiu0A5QiVRwFNV/NglMEPN1ZUgr +oQJflkmVXryOYfxz0dbWb0= X-Google-Smtp-Source: APXvYqxL8pWcjEkEVw7JhxurqlWcxCeyoZCsxf01cpuezRH1sJw82JW4DIXFjVgtu+WiHE3w/hwa3A== X-Received: by 2002:a62:168e:: with SMTP id 136mr232320pfw.144.1567639069538; Wed, 04 Sep 2019 16:17:49 -0700 (PDT) Received: from rashmica.ozlabs.ibm.com ([122.99.82.10]) by smtp.googlemail.com with ESMTPSA id r1sm177579pgv.70.2019.09.04.16.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 16:17:48 -0700 (PDT) Message-ID: Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks From: Rashmica Gupta To: Andy Shevchenko Date: Thu, 05 Sep 2019 09:17:43 +1000 In-Reply-To: References: <20190904061245.30770-1-rashmica.g@gmail.com> User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_161750_339405_9C965EEA X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Bartosz Golaszewski , Andrew Jeffery , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Joel Stanley , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2019-09-04 at 19:27 +0300, Andy Shevchenko wrote: > On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta > wrote: > > Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') > > > > Signed-off-by: Rashmica Gupta > > /* Allocate a cache of the output registers */ > > - banks = gpio->config->nr_gpios >> 5; > > + banks = (gpio->config->nr_gpios >> 5) + 1; > > Shouldn't be rather DIV_ROUND_UP(nr_gpios, sizeof(u32)) ? I agree that DIV_ROUND_UP is the right thing to use here, but wouldn't it be DIV_ROUND_UP(nr_gpios, 32)? > > > gpio->dcache = devm_kcalloc(&pdev->dev, > > banks, sizeof(u32), > > GFP_KERNEL); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel