From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D07C48BE0 for ; Fri, 11 Jun 2021 09:58:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83FD9613D0 for ; Fri, 11 Jun 2021 09:58:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83FD9613D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=SB+kQEejuImFJHUE9ONJJ9Iav3OxrrqbG3FWcMqcP2A=; b=BzH43CrNhJnydECO9K7MCMQfGY mbV4AFOuogbsCJnInfqP3pvPS3tYwDuAejCBI9xSwrwpar5vmO91/enH7WgynB5tjoapHGNDLxaSW 5GQ6xy/t51zYKQoGfVMxiIkRCNJXZJZaFMrYXAwSQSt6UHwFjEzVEiNTVXbCJuJzP0e2/ol7Gr0Lj YaG3rSKGw4gMNIxUOF/Oba7tDKuYGEEfT2JCBcICmnSM6qgsboDBjE5XK/NCyHBkz14wJwhNRVcxa 7E2RDtfXniFRdmFCZ0QQcS2UYbe4pVoDg44htVS+4T8V8vho10XLVefqhrIsCrO8+nnssSCaple+8 TwWQpdJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrduJ-004dPG-7c; Fri, 11 Jun 2021 09:56:55 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrduE-004dOU-G1; Fri, 11 Jun 2021 09:56:51 +0000 Received: by mail-wm1-x331.google.com with SMTP id l9so7771256wms.1; Fri, 11 Jun 2021 02:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2aS2aKAnK8HRnoLMpd4OzBFgPhNdvccv1jLgYOp9O1Q=; b=Vyj4vp+WQf3MX0A/ykECp07yDpSb+a2MxyYqRr080tcVKfgDf8tI640rL1QeMrCyK/ KSxsuph4wUrjqR0LqLMf107xy6m80NsuUZ8qw6qGK49pLXNKXBzwlBA4xfcYuohcPlEd DJtrZ9Myk0J4eOPUqnBaXEUy2QwJsPSoyG1OhkYwAOaDqsL0I3/Eix5GjJdvYu8EyKRO YYmkuL/aB3Hyq9eGmrBD0f6jkV82JH2iQUnLbF7c77tbekcZIxtmu/FAiwa2nkgomV6w uMbwDw5ag+Ficnl5rBF6lagRTWz89/ntlx8XIrYzFsOiybdWQWTxRv6g45A13YaAw609 OiJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2aS2aKAnK8HRnoLMpd4OzBFgPhNdvccv1jLgYOp9O1Q=; b=XdgkMY39A8GbBKGSLLJwzb5NGIog+LUFhFfloJvPgWgXOTG5z1TxfF05J5NS/SlErr 9qIFqnbkvPv2g6iZmHPIXe64l+B+md1ldx6V9jcmS+k/B0rlBZeXy6AZ/Up3hbxm8Eyk H8vt7BSBJeJWRzjbYfvQIRm+Xgh9WUwo+p5un9NTIGMqC9fbi97usJ314CmMQqEZWnLp YtpT+gzrwkeN8seJLb8SzWTd/G+bfk6jb1U52M/mIt3rvlFliQUnsNIMs+BdvI34z4Pj 8GDNU5nw+pc1mImpurybqPRD9KRbeFHC6dJ5DYLb6nD8gPYSsF/4/IiRlGM+xgFaCINh lPXw== X-Gm-Message-State: AOAM533Ijhgfkt/RsCtGHShWJF+O5WVrgwnV0RmC/J/256yn3DSQwBsE tBq0x3q7+SitrUS7g/0+wgU= X-Google-Smtp-Source: ABdhPJzRO51Kgr6iMGfZOZyQH08p7CKPYr70cepTRwtpjrGRVpTlK4qEzZS/X+xskoGy1H8iq7qkGw== X-Received: by 2002:a05:600c:2e43:: with SMTP id q3mr3096187wmf.11.1623405409129; Fri, 11 Jun 2021 02:56:49 -0700 (PDT) Received: from ziggy.stardust ([213.195.126.134]) by smtp.gmail.com with ESMTPSA id 73sm6955489wrk.17.2021.06.11.02.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 02:56:48 -0700 (PDT) Subject: Re: [PATCH v9 01/22] dt-bindings: ARM: Mediatek: Add new document bindings of imp i2c wrapper controller To: Stephen Boyd , Chun-Jie Chen , Rob Herring Cc: Nicolas Boichat , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, Weiyi Lu References: <20210524122053.17155-1-chun-jie.chen@mediatek.com> <20210524122053.17155-2-chun-jie.chen@mediatek.com> <20210602171201.GA3566462@robh.at.kernel.org> <66e017401ab93aa02c5d2bbf11be9589b36649ac.camel@mediatek.com> <1f59ed31-4a0e-9719-bf84-1fe4cdd6c57d@gmail.com> <162334689784.9598.2709970788186333494@swboyd.mtv.corp.google.com> From: Matthias Brugger Message-ID: Date: Fri, 11 Jun 2021 11:56:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <162334689784.9598.2709970788186333494@swboyd.mtv.corp.google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_025650_567627_7F770379 X-CRM114-Status: GOOD ( 26.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/06/2021 19:41, Stephen Boyd wrote: > Quoting Matthias Brugger (2021-06-08 07:45:49) >> >> >> On 07/06/2021 07:20, Chun-Jie Chen wrote: >>> On Wed, 2021-06-02 at 12:12 -0500, Rob Herring wrote: >>>>> + >>>>> +description: >>>>> + The Mediatek imp i2c wrapper controller provides functional >>>>> configurations and clocks to the system. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + items: >>>>> + - enum: >>>>> + - mediatek,mt8192-imp_iic_wrap_c >>>>> + - mediatek,mt8192-imp_iic_wrap_e >>>>> + - mediatek,mt8192-imp_iic_wrap_s >>>>> + - mediatek,mt8192-imp_iic_wrap_ws >>>>> + - mediatek,mt8192-imp_iic_wrap_w >>>>> + - mediatek,mt8192-imp_iic_wrap_n >>>> >>>> Looks to me like these are all the same h/w, but just have differing >>>> sets of clocks. That's not really a reason to have different >>>> compatibles. >>>> >>>> If you need to know what clocks are present, you can walk the DT for >>>> all 'clocks' properties matching this clock controller instance. Or >>>> use >>>> 'clock-indices' to define which ones are present. > > Is the idea to use clock-indices and then list all the clock ids in > there and match them up at driver probe time to register the clocks > provided by the IO region? Feels like we'll do a lot of parsing at each > boot to match up structures and register clks with the clk framework. > > If it's like other SoCs then the clk id maps to a hard macro for a type > of clk, and those hard macros have been glued together with other clks > and then partitioned into different IO regions to make up a clock > controller. Or maybe in this case, those clk hard macros have been > scattered into each IP block like SPI, i2c, uart, etc. so that the clock > controller doesn't really exist and merely the gates and rate control > (mux/divider) for the clk that's clocking some particular IP block all > live inside the IP wrapper. If it's this case then I hope there are a > bunch of PLLs that are fixed rate so that the i2c clk doesn't have to go > outside the wrapper to change frequency (of which there should be two > "standard" frequencies anyway). > >>>> >>>> Rob >>> >>> Some module is divided to sub-modules which are designed in different >>> h/w blocks for different usage, and if we want to use the same >>> compatible to present these h/w blocks, we need to move the clock data >>> provided by these h/w blocks to dts, but we usually use different >>> compatible to get the h/w blocks data in >>> Mediatek's clock driver, so do you suggest to register clock provided >>> by different h/w blocks using same compatible? >>> >> >> The mapping of them is as following: >> imp_iic_wrap_c: 11007000 >> imp_iic_wrap_e: 11cb1000 >> imp_iic_wrap_s: 11d03000 >> imp_iic_wrap_ws: 11d23000 >> imp_iic_wrap_w: 11e01000 >> imp_iic_wrap_n: 11f02000 >> > > Sure. What is their purpose though? Are they simply a bunch of different > i2c clks? > That would be need to be answered by MediaTek as I don't have access to any documentation. Regards, Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel