From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90309C33CA2 for ; Fri, 10 Jan 2020 11:38:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62AC92077C for ; Fri, 10 Jan 2020 11:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZNwFApwP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62AC92077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8C/uqxf2RtEPjBC4ChXF+rqVawaJ/km/iLF8X8ST6gg=; b=ZNwFApwPYo3R2g ao2aU/rweyTIpA4V2l018hoiPdgUdBXFvtv8gZOdjqpm0AQZW7Fmd/kB5daIHPfm74mMtKUPEZY6D Cjb+AirHS/Y4iaGn97Iyb9lEmPvFJhc9dmNxQaN1A1npGRVvA8hfaMMMql4L65JDPTyv3yrFbzfeX fjqoGse6OdEXogI9isM0zoMCSdkj1yJGoaQbXidHVWxz4e7SRAVhs8/OQk06HKpTmbo33me0ic4CU ZS02bR+reK2aJHKUmcb32PywfUlxjoDytyf+PI9r8w26bgTzHh4BNlP6bSYi5ttr06W8a+WcDyjDX 8rbwzX7nsfypch46Z+Pg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipscZ-0007z2-CH; Fri, 10 Jan 2020 11:38:31 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipscI-0007vP-H6; Fri, 10 Jan 2020 11:38:16 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 08AD7293976 Subject: Re: [PATCH v2 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana To: Hsin-Yi Wang , linux-arm-kernel@lists.infradead.org References: <20200110073730.213789-1-hsinyi@chromium.org> <20200110073730.213789-2-hsinyi@chromium.org> From: Enric Balletbo i Serra Message-ID: Date: Fri, 10 Jan 2020 12:38:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200110073730.213789-2-hsinyi@chromium.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_033814_699679_7EFCFC06 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Nicolas Boichat , linux-kernel@vger.kernel.org, Daniel Kurtz , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hsin-Yi, Just a nit that is most a decision of the maintainer ... On 10/1/20 8:37, Hsin-Yi Wang wrote: > Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173 > SoC. > > Signed-off-by: Hsin-Yi Wang Tested with patch 2 applied and saw that there is no errors with dtbs_check. Tested-by: Enric Balletbo i Serra > --- > Changes in v2: > - fix dtbs_check errors, use const instead of enum > --- > .../devicetree/bindings/arm/mediatek.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 4043c5046441..5272899b08fa 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -84,6 +84,33 @@ properties: > - enum: > - mediatek,mt8135-evbp1 > - const: mediatek,mt8135 > + - description: Google Elm (Acer Chromebook R13) > + items: > + - const: google,elm-rev8 > + - const: google,elm-rev7 > + - const: google,elm-rev6 > + - const: google,elm-rev5 > + - const: google,elm-rev4 > + - const: google,elm-rev3 > + - const: google,elm-rev2 > + - const: google,elm-rev1 > + - const: google,elm > + - const: mediatek,mt8173 > + - description: Google Hana (Lenovo Chromebook and more) nit: and more? How many? I'd expect the commercial model names here Lenovo Chromebook C330? Thanks, Enric > + items: > + - const: google,hana-rev6 > + - const: google,hana-rev5 > + - const: google,hana-rev4 > + - const: google,hana-rev3 > + - const: google,hana-rev2 > + - const: google,hana-rev1 > + - const: google,hana-rev0 > + - const: google,hana > + - const: mediatek,mt8173 > + - description: Google Hana rev7 (Poin2 Chromebook 11C) > + items: > + - const: google,hana-rev7 > + - const: mediatek,mt8173 > - items: > - enum: > - mediatek,mt8173-evb > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel