From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67ECBC31E5E for ; Wed, 19 Jun 2019 10:44:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 418422064A for ; Wed, 19 Jun 2019 10:44:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="elcpawXQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 418422064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rSRC0CgHL6eqGQzZ8BBnBmHvBPt9Uk+LQp1iA9FDBic=; b=elcpawXQsMbtTwe+DgkD6AimX 5UD8imbzXczIfJq+DDtTzcxE9lZoK0ZtikDMLq8/a+viSiBpxiKyYdgp6/Pe1CZtWrG6cKYIdqJjs THOEnO8f7i+Z7HriyCom3dzukOfJdTnGoamQUyyP+si0NMNdgDxfwmpw1giblmAYZcugk4S8lR6Rc tQfuDxSpYNBj8McjDkw9FUfK+NrI9fqqcO8nKkLuaBEgVSnVn5SVrs0Jz4Z4W5u1QT1IMQlOEPRtI /a3v5Dq/uhoq1I6j0l37UXSy5eFi+skKIb397UKJNfDKn6wjMVk192ZphADwHYGPwt60wtVG+QVcH V0JdKduhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdY4N-0006C7-OL; Wed, 19 Jun 2019 10:43:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdY4K-0006Bn-I0 for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 10:43:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E6B1A360; Wed, 19 Jun 2019 03:43:55 -0700 (PDT) Received: from [10.1.196.93] (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A51393F738; Wed, 19 Jun 2019 03:45:41 -0700 (PDT) Subject: Re: [PATCH v1 3/5] coresight: etm4x: use octal permissions for module_params To: andrew.murray@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com References: <20190618125433.9739-1-andrew.murray@arm.com> <20190618125433.9739-4-andrew.murray@arm.com> From: Suzuki K Poulose Message-ID: Date: Wed, 19 Jun 2019 11:43:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190618125433.9739-4-andrew.murray@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_034356_643903_B6570B3E X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/06/2019 13:54, Andrew Murray wrote: > Checkpatch indicates that octal permissions are preferred for > module parameters. Let's use octal permissions instead. > > Signed-off-by: Andrew Murray > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index ae623415c431..885c4f2c691c 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -34,7 +34,7 @@ > #include "coresight-etm-perf.h" > > static int boot_enable; > -module_param_named(boot_enable, boot_enable, int, S_IRUGO); > +module_param_named(boot_enable, boot_enable, int, 0444); Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel