From: Sameer Pujar <spujar@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
catalin.marinas@arm.com, will@kernel.org, perex@perex.cz,
tiwai@suse.com
Cc: jonathanh@nvidia.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] ASoC: tegra: Add binding doc for OPE module
Date: Mon, 30 May 2022 09:51:23 +0530 [thread overview]
Message-ID: <df57de4e-770d-7331-89e5-a2404fb42f96@nvidia.com> (raw)
In-Reply-To: <149fbcfe-b62c-63a9-6c38-100d493788c3@linaro.org>
On 29-05-2022 19:39, Krzysztof Kozlowski wrote:
> On 27/05/2022 12:26, Sameer Pujar wrote:
>> This patch adds YAML schema for DT bindings of Output Processing
>> Engine (OPE) module. It consists of Parametric Equalizer (PEQ)
>> and Multi Band Dynamic Range Compressor (MBDRC) sub blocks and
>> binding doc for these blocks are added as well. The OPE will be
>> registered as an ASoC component and can be plugged into an audio
>> path as per need via ALSA mixer controls. The DT bindings are
>> applicable on Tegra210 and later SoCs where OPE module is present.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> .../bindings/sound/nvidia,tegra210-ahub.yaml | 4 +
>> .../bindings/sound/nvidia,tegra210-mbdrc.yaml | 47 ++++++++++++
>> .../bindings/sound/nvidia,tegra210-ope.yaml | 87 ++++++++++++++++++++++
>> .../bindings/sound/nvidia,tegra210-peq.yaml | 48 ++++++++++++
>> 4 files changed, 186 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-peq.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
>> index 6df6f85..47b6e71 100644
>> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
>> @@ -110,6 +110,10 @@ patternProperties:
>> type: object
>> $ref: nvidia,tegra186-asrc.yaml#
>>
>> + '^processing-engine@[0-9a-f]+$':
>> + type: object
>> + $ref: nvidia,tegra210-ope.yaml#
>> +
>> required:
>> - compatible
>> - reg
>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml
>> new file mode 100644
>> index 0000000..0d55328
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mbdrc.yaml
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mbdrc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Tegra210 MBDRC Device Tree Bindings
> Previous comments - s/Device Tree Bindings//
> - still applies. Please do not ignore it.
I did not ignore this. There was a comment from Mark on this earlier (v1) and I did not see further reply from you. I thought you were OK with the way it is. So if you are saying acronym part is OK and just to remove "Device Tree Bindings" I can send a v3 for this.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-30 4:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 10:26 [PATCH v2 0/6] OPE support on Tegra210 and later Sameer Pujar
2022-05-27 10:26 ` [PATCH v2 1/6] ASoC: tegra: Add binding doc for OPE module Sameer Pujar
2022-05-29 14:09 ` Krzysztof Kozlowski
2022-05-30 4:21 ` Sameer Pujar [this message]
2022-05-30 6:47 ` Krzysztof Kozlowski
2022-05-27 10:26 ` [PATCH v2 2/6] ASoC: tegra: Add Tegra210 based OPE driver Sameer Pujar
2022-05-27 10:26 ` [PATCH v2 3/6] ASoC: tegra: AHUB routes for OPE module Sameer Pujar
2022-05-27 10:26 ` [PATCH v2 4/6] arm64: defconfig: Build Tegra " Sameer Pujar
2022-05-27 10:26 ` [PATCH v2 5/6] arm64: tegra: Add OPE device on Tegra210 and later Sameer Pujar
2022-05-27 10:26 ` [PATCH v2 6/6] arm64: tegra: Enable OPE on various platforms Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df57de4e-770d-7331-89e5-a2404fb42f96@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).