From: shangxiaojing <shangxiaojing@huawei.com>
To: James Clark <james.clark@arm.com>
Cc: <john.garry@huawei.com>, <will@kernel.org>,
<mike.leach@linaro.org>, <leo.yan@linaro.org>,
<peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <namhyung@kernel.org>, <kjain@linux.ibm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 3/3] perf vendor events arm64: Use event name instead of event code
Date: Fri, 21 Oct 2022 18:31:28 +0800 [thread overview]
Message-ID: <df6b61dc-aeff-7602-d5d9-6d8b8f52541d@huawei.com> (raw)
In-Reply-To: <bf6205a7-8d72-fabe-2633-a0d2282ce299@arm.com>
On 2022/10/21 17:09, James Clark wrote:
>
>
>> {
>> - "MetricExpr": "armv8_pmuv3_0@event\\=0x7002@ / CPU_CYCLES",
>> + "MetricExpr": "EXE_STALL_DIV / CPU_CYCLES",
>> "PublicDescription": "Divider L3 topdown metric",
>> "BriefDescription": "Divider L3 topdown metric",
>> "MetricGroup": "TopDownL3",
>> "MetricName": "divider"
>> },
>> {
>> - "MetricExpr": "armv8_pmuv3_0@event\\=0x7003@ / CPU_CYCLES",
>> + "MetricExpr": "FSU_STALL / CPU_CYCLES",
>> "PublicDescription": "FSU stall L3 topdown metric",
>> - "BriefDescription": "FSU stall L3 topdown metric",
>> + "BriefDescription": "FSU stall L3 topdown metric",
>
> There is a tab here, but it's probably not worth resubmitting over.
>
> Otherwise for the whole set:
>
> Acked-by: James Clark <james.clark@arm.com>
Thanks for the review, will fix in v2.
Thanks,
--
Shang XiaoJing
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-10-21 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 8:53 [PATCH 0/3] perf vendor events arm64: Fix incorrect metrics and improve readability Shang XiaoJing
2022-10-21 8:53 ` [PATCH 1/3] perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics Shang XiaoJing
2022-10-21 9:59 ` John Garry
2022-10-21 10:32 ` shangxiaojing
2022-10-21 8:53 ` [PATCH 2/3] perf vendor events arm64: Add HiSilicon hip08 core events Shang XiaoJing
2022-10-21 8:53 ` [PATCH 3/3] perf vendor events arm64: Use event name instead of event code Shang XiaoJing
2022-10-21 9:09 ` James Clark
2022-10-21 10:31 ` shangxiaojing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df6b61dc-aeff-7602-d5d9-6d8b8f52541d@huawei.com \
--to=shangxiaojing@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).