From: Matthias Brugger <matthias.bgg@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Stephen Boyd <swboyd@chromium.org>,
Benson Leung <bleung@chromium.org>
Cc: devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA
Date: Wed, 30 Sep 2020 12:44:34 +0200 [thread overview]
Message-ID: <dffd01f9-9c81-080a-9470-4bdd5a857408@gmail.com> (raw)
In-Reply-To: <16ec2003-462e-326b-8b3c-51d8b9ae9829@collabora.com>
On 29/09/2020 10:04, Enric Balletbo i Serra wrote:
> Hi Stephen,
>
> Thank you for your patch.
>
> cc'ing Heiko and Matthias
>
> On 25/9/20 18:26, Stephen Boyd wrote:
>> On newer keyboards this key is in a different place. Add both options to
>> the keymap so that both new and old keyboards work.
>>
>> Cc: Douglas Anderson <dianders@chromium.org>
>> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Usually the DT changes go through the Rockchip dts or Mediatek dts tree, this is
> not a specific Rockchip/Mediatek change but for both. Are you fine If I pick the
> patch through the chrome-platform tree? I don't think there is any conflict.
>
Please go ahead and take the patch through your tree.
Regards,
Matthias
> Thanks,
> Enric
>
>> ---
>> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> index 4a0c1037fbc0..165c5bcd510e 100644
>> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> @@ -46,6 +46,7 @@ MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
>> MATRIX_KEY(0x02, 0x09, KEY_F8)
>> MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>>
>> + MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
>> MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
>> MATRIX_KEY(0x03, 0x02, KEY_F2)
>> MATRIX_KEY(0x03, 0x03, KEY_5)
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-30 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:26 [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA Stephen Boyd
2020-09-25 17:50 ` Doug Anderson
2020-09-29 8:04 ` Enric Balletbo i Serra
2020-09-29 13:09 ` Heiko Stübner
2020-09-30 10:44 ` Matthias Brugger [this message]
2020-10-06 14:35 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dffd01f9-9c81-080a-9470-4bdd5a857408@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).