From: Gabriel FERNANDEZ <gabriel.fernandez@st.com>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Alexandre TORGUE" <alexandre.torgue@st.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] Input: st-keyscan - fix potential zalloc NULL dereference
Date: Tue, 12 Feb 2019 15:28:22 +0000 [thread overview]
Message-ID: <e0967983-cab2-3c18-6c8a-a0333dc087ff@st.com> (raw)
In-Reply-To: <20190212152429.1936-1-gabriel.fernandez@st.com>
Sorry ignore this patch (bad mailing list)
Best Regard
Gabriel
On 2/12/19 4:24 PM, gabriel.fernandez@st.com wrote:
> From: Gabriel Fernandez <gabriel.fernandez@st.com>
>
> This patch fixes the following static checker warning:
>
> drivers/input/keyboard/st-keyscan.c:156 keyscan_probe()
> error: potential zalloc NULL dereference: 'keypad_data->input_dev'
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@st.com>
> ---
> drivers/input/keyboard/st-keyscan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c
> index babcfb165e4f..3b85631fde91 100644
> --- a/drivers/input/keyboard/st-keyscan.c
> +++ b/drivers/input/keyboard/st-keyscan.c
> @@ -153,6 +153,8 @@ static int keyscan_probe(struct platform_device *pdev)
>
> input_dev->id.bustype = BUS_HOST;
>
> + keypad_data->input_dev = input_dev;
> +
> error = keypad_matrix_key_parse_dt(keypad_data);
> if (error)
> return error;
> @@ -168,8 +170,6 @@ static int keyscan_probe(struct platform_device *pdev)
>
> input_set_drvdata(input_dev, keypad_data);
>
> - keypad_data->input_dev = input_dev;
> -
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(keypad_data->base))
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-12 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 15:24 [PATCH] Input: st-keyscan - fix potential zalloc NULL dereference gabriel.fernandez
2019-02-12 15:28 ` Gabriel FERNANDEZ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0967983-cab2-3c18-6c8a-a0333dc087ff@st.com \
--to=gabriel.fernandez@st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).