From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11796C433E7 for ; Fri, 9 Oct 2020 11:43:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B454C22268 for ; Fri, 9 Oct 2020 11:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NncA5QYU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B454C22268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxgFzF2DzqUW7gH4Qx3tipjgwOqltHyxa0rK9caLo0w=; b=NncA5QYUo2oEtVWtn/Mc0f+Da jklsSaG5me2OeQJpQg1h27XZpkKNJMcnByl/vHaKo7/IMRLQNbp2+B6jtI9Q2kC0+JtD2Cs8AbKnj vJVUbW1MiVh5OXmiVTiIY588eTbNPEpJ09hsL32G83AxrrK+KlX45QI5rfVYEthiPFTegRb9olFih vOsoBCCLiXhmE1/nZaBUSKvNJj+/rtr6o5E8bxUoZoehgumMHC6qcaOs/hP9cHN3evpXb9LiThrKO eVAwtGWCDhf24pBJ925QmbUCaVwZipW3dOIOXyqYhvklHI3TOvhJI4VCHK9tii6Y8qiMba9esM+Dr 8DaIxzORQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQqmP-00030P-Ih; Fri, 09 Oct 2020 11:41:45 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQqmL-0002zo-J3 for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 11:41:42 +0000 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 90C49EF1BB54D9D31778; Fri, 9 Oct 2020 12:41:37 +0100 (IST) Received: from [127.0.0.1] (10.47.0.88) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 9 Oct 2020 12:41:36 +0100 Subject: Re: [PATCH] perf jevents: Fix event code for events referencing std arch events To: kajoljain , , , , , , , , , , References: <1602170368-11892-1-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: Date: Fri, 9 Oct 2020 12:38:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.47.0.88] X-ClientProxiedBy: lhreml735-chm.china.huawei.com (10.201.108.86) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_074141_726034_76C295A3 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/10/2020 12:26, kajoljain wrote: > > On 10/8/20 8:49 PM, John Garry wrote: >> The event code for events referencing std arch events is incorrectly >> evaluated in json_events(). >> >> The issue is that je.event is evaluated properly from try_fixup(), but >> later NULLified from the real_event() call, as "event" may be NULL. >> >> Fix by setting "event" same je.event in try_fixup(). >> >> Also remove support for overwriting event code for events using std arch >> events, as it is not used. > Patch looks good to me. Not sure if any adding any example with this issue > is helpful. So we get something like this in pmu-events.c: { .name = "l1d_cache_wb_victim", .event = "event=0x0", [...] }, But event should "event=0x46". I can add this if Arnaldo wants a v2. > > Reviewed-By: Kajol Jain thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel