From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>,
f.fainelli@gmail.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
tim.gover@raspberrypi.org, helgaas@kernel.org, wahrenst@gmx.net,
linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk
Date: Wed, 13 May 2020 13:26:00 +0200 [thread overview]
Message-ID: <e3f5ea8acdeee14571f77060b5711fce46d86bd1.camel@suse.de> (raw)
In-Reply-To: <20200513111717.GA32365@e121166-lin.cambridge.arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 3755 bytes --]
On Wed, 2020-05-13 at 12:17 +0100, Lorenzo Pieralisi wrote:
> On Tue, May 05, 2020 at 06:13:13PM +0200, Nicolas Saenz Julienne wrote:
> > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
> > loaded directly from an EEPROM or, if not present, by the SoC's
> > co-processor, VideoCore. This series adds support for the later.
> >
> > Note that there are a set of constraints we have to consider:
> > - We need to make sure the VideoCore firmware interface is up and
> > running before running the VL805 firmware load call.
> >
> > - There is no way to discern RPi4's VL805 chip from other platforms',
> > so we need the firmware load to happen *before* running
> > quirk_usb_handoff_xhci(). Failure to do so results in an unwarranted
> > 5 second wait while the fixup code polls xHC's non-existing state.
> >
> > By Florian's suggestion I've been spending some time exploring the device
> > link[1] API in order to see if that could save us from explicitly creating
> > probe dependencies between pcie-brcmstb and firmware/raspberrypi (patch #3).
> > Technically these dependencies could be inferred from DT. It turns out
> > Saravana
> > Kannan has been looking at this already. A new boot mechanism, activated
> > with
> > fw_devlink=on takes care of the device probe ordering on devices with
> > consumer/supplier relationships. For now this relationship is created based
> > on
> > the usage of generic DT properties, but has no support for vendor-specifc DT
> > properties, which we'd be forced to use in order to create a relationship
> > between our two devices since our setup is highly non generic. There will
> > probably be at some point support for such properties, and we will then be
> > able
> > to revisit some of this code.
> >
> > All this is based on the work by Tim Gover in RPi's downstream
> > kernel[2].
> >
> > [1] https://www.kernel.org/doc/html/v4.13/driver-api/device_link.html
> > [2]
> >
https://github.com/raspberrypi/linux/commit/9935b4c7e360b4494b4cb6e3ce797238a1ab78bd
> >
> > ---
> >
> > Changes since v7:
> > - Address Stefan's comments
> >
> > Changes since v6:
> > - Make rpi_firmware_init_vl805() more robust
> > - Rewrite comments and patch descriptions to be more accessible to non RPi
> > fluent people
> > - Removed Florian's Reviewed-by in patch #2 as function changed
> > substantially
> > - Tested with/witout u-boot
> >
> > Changes since v5:
> > - Fix issues reported by Kbuild test robot
> >
> > Changes since v4:
> > - Addressed Sergei's comments
> > - Fix potential warning in patch #2
> >
> > Changes since v3:
> > - Addressed Greg's comments
> >
> > There was no v2, my bad.
> >
> > Changes since v1:
> > - Addressed Floarians comments
> >
> > Nicolas Saenz Julienne (4):
> > soc: bcm2835: Add notify xHCI reset property
> > firmware: raspberrypi: Introduce vl805 init routine
> > PCI: brcmstb: Wait for Raspberry Pi's firmware when present
> > USB: pci-quirks: Add Raspberry Pi 4 quirk
> >
> > drivers/firmware/Kconfig | 3 +-
> > drivers/firmware/raspberrypi.c | 61 ++++++++++++++++++++++
> > drivers/pci/controller/pcie-brcmstb.c | 17 ++++++
> > drivers/usb/host/pci-quirks.c | 16 ++++++
> > include/soc/bcm2835/raspberrypi-firmware.h | 9 +++-
> > 5 files changed, 104 insertions(+), 2 deletions(-)
>
> Hi Nicolas,
>
> should I queue this series via the PCI tree ? Just let me know, most of
> the changes are not in the PCI tree, asking in order to
> minimize/simplify conflicts handling if possible.
Yes, I agree, it's better if you take the whole thing.
Thanks,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-13 11:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 16:13 [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Nicolas Saenz Julienne
2020-05-05 16:13 ` [PATCH v8 1/4] soc: bcm2835: Add notify xHCI reset property Nicolas Saenz Julienne
2020-05-07 21:48 ` Rob Herring
2020-05-05 16:13 ` [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine Nicolas Saenz Julienne
2020-05-07 21:48 ` Rob Herring
2020-05-09 10:02 ` Stefan Wahren
2020-05-09 10:09 ` Stefan Wahren
2020-05-09 19:20 ` Nicolas Saenz Julienne
2020-05-05 16:13 ` [PATCH v8 3/4] PCI: brcmstb: Wait for Raspberry Pi's firmware when present Nicolas Saenz Julienne
2020-05-07 21:49 ` Rob Herring
2020-05-05 16:13 ` [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Nicolas Saenz Julienne
2020-05-07 21:52 ` Rob Herring
2020-05-11 14:25 ` Lorenzo Pieralisi
2020-05-13 7:05 ` Mathias Nyman
2020-06-02 10:05 ` Nicolas Saenz Julienne
2020-06-02 21:57 ` Florian Fainelli
2020-05-13 11:17 ` [PATCH v8 0/4] " Lorenzo Pieralisi
2020-05-13 11:26 ` Nicolas Saenz Julienne [this message]
2020-05-13 15:47 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f5ea8acdeee14571f77060b5711fce46d86bd1.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=tim.gover@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).