From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E8E5ECE587 for ; Tue, 1 Oct 2019 16:03:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BD482168B for ; Tue, 1 Oct 2019 16:03:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rrGudvaU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BD482168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rrBtWt9GEqQhxe/sGUZLFdxB/U2JRWdE7Z1W1mX3LU8=; b=rrGudvaUGO030uewUaoHjXwco ZzNtEoKXp1DQVtQEGjh/Pik1UGEn3YBDvR2r+LXAh2tjnNRJgZbkryNRZyD1wSNiPen9ppMlVnEbd Ehy/1yxf//hoyUaQIgDtAEBA6Uqx8ISaSux9TC/nxj00f/g5TNvjEzWemz3BIkd+TGJg+1L5e8c5k GkNVK/yiRhYB7+sMPqrh8737DZZ+17bscrZTHevasrC3ccbhjJ8n6Oy5u0PdVYdplyVOQYBPMGxMX WuH47cwlsH6STKXLc5o0NYe3ZOkA9KSNg8Ob9aqywFqd7Snnmo+aLmh6DNVQFupPeKe7trbHf0X87 PZ3qX5Hug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFKcy-0006ct-BF; Tue, 01 Oct 2019 16:03:52 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFKcv-0006cE-7Y for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 16:03:50 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 09:03:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,571,1559545200"; d="scan'208";a="216117152" Received: from linux.intel.com ([10.54.29.200]) by fmsmga004.fm.intel.com with ESMTP; 01 Oct 2019 09:03:46 -0700 Received: from abapat-mobl1.amr.corp.intel.com (unknown [10.251.1.101]) by linux.intel.com (Postfix) with ESMTP id 1AC725803FA; Tue, 1 Oct 2019 09:03:46 -0700 (PDT) Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: imx: fix reverse CONFIG_SND_SOC_SOF_OF dependency To: Arnd Bergmann References: <20191001142026.1124917-1-arnd@arndb.de> From: Pierre-Louis Bossart Message-ID: Date: Tue, 1 Oct 2019 11:03:45 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_090349_285006_50A00CB3 X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA Development Mailing List , Fabio Estevam , "linux-kernel@vger.kernel.org" , Shawn Guo , Sascha Hauer , Takashi Iwai , YueHaibing , Liam Girdwood , Jaroslav Kysela , Hulk Robot , Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Daniel Baluta , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/1/19 10:41 AM, Arnd Bergmann wrote: > On Tue, Oct 1, 2019 at 5:32 PM Pierre-Louis Bossart > wrote: >> On 10/1/19 9:20 AM, Arnd Bergmann wrote: >>> CONFIG_SND_SOC_SOF_IMX depends on CONFIG_SND_SOC_SOF, but is in >>> turn referenced by the sof-of-dev driver. This creates a reverse >>> dependency that manifests in a link error when CONFIG_SND_SOC_SOF_OF >>> is built-in but CONFIG_SND_SOC_SOF_IMX=m: >>> >>> sound/soc/sof/sof-of-dev.o:(.data+0x118): undefined reference to `sof_imx8_ops' >>> >>> Make the latter a 'bool' symbol and change the Makefile so the imx8 >>> driver is compiled the same way as the driver using it. >>> >>> A nicer way would be to reverse the layering and move all >>> the imx specific bits of sof-of-dev.c into the imx driver >>> itself, which can then call into the common code. Doing this >>> would need more testing and can be done if we add another >>> driver like the first one. >> >> Or use something like >> >> config SND_SOC_SOF_IMX8_SUPPORT >> bool "SOF support for i.MX8" >> depends on IMX_SCU >> depends on IMX_DSP >> >> config SND_SOC_SOF_IMX8 >> tristate >> >> >> config SND_SOC_SOF_OF >> depends on OF >> select SND_SOC_SOF_IMX8 if SND_SOC_SOF_IMX8_SUPPORT >> >> That way you propagate the module/built-in information. That's how we >> fixed those issues for the Intel parts. > > Yes, I think that would work here as well, but it keeps even more > information about the specific drivers in the generic code. It also > requires adding more 'select' statements that tend to cause more > problems. > > The same could be done with a Kconfig-only solution avoiding > 'select' such as: > > config SND_SOC_SOF_IMX8_SUPPORT > bool "SOF support for i.MX8" > depends on IMX_SCU > depends on IMX_DSP > > config SND_SOC_SOF_IMX8 > def_tristate SND_SOC_SOF_OF > depends on SND_SOC_SOF_IMX8_SUPPORT Ah, nice, thanks for the suggestion! That would be my preference, we have a similar select for PCI and ACPI parts in sound/soc/sof/Kconfig and I was looking for a means to do this more elegantly. I can submit a new fix or let you sent a v2, whatever is more convenient. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel