From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25664C31E4B for ; Fri, 14 Jun 2019 14:02:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F18F92063F for ; Fri, 14 Jun 2019 14:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iS+AUf5s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F18F92063F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kuugeEJfMUq632D+TGSHAWx9WeptB+n2/zttblQC908=; b=iS+AUf5sWaI37CNi04sgUt/kj CU9AEUfiOByQtlVXLXx+iJ00C0o6WnJ8JRxMnlorn6GW6NITQSSr9j4V9Z64UPM0Ws1deFW0Tf7U7 ztaz3VY23q7aXKv7uD2VoztvsiJIKwE/DWHjmdv9y57xrNAsm8X2hxYnADIr+r6yADLU27nLAi3vX vBkh86sVHedXOeScFcOH3gtjvB99ZmPQnyrfr+8Xlmg8ZEB5wRMgEPl/tzlmk5xAZH5dMvO/BUd9e Co9YRIS/hr+xxppmhlzzsrPUZFkGF2lT2t82qNE4Jif1kTvK5vHQ3/HTeE5RlB/xt+ZIcSo3EW1ej +jgKT/sHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbmme-0006vk-TT; Fri, 14 Jun 2019 14:02:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbmmb-0006uS-O5; Fri, 14 Jun 2019 14:02:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59C9728; Fri, 14 Jun 2019 07:02:20 -0700 (PDT) Received: from [10.1.197.57] (e110467-lin.cambridge.arm.com [10.1.197.57]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C8EFF3F718; Fri, 14 Jun 2019 07:02:17 -0700 (PDT) Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi To: Daniel Lezcano , Heiko Stuebner References: <20190604165802.7338-1-daniel.lezcano@linaro.org> <5188064.YWmxIpmbGp@phil> <55b9018e-672e-522b-d0a0-c5655be0f353@linaro.org> From: Robin Murphy Message-ID: Date: Fri, 14 Jun 2019 15:02:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <55b9018e-672e-522b-d0a0-c5655be0f353@linaro.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_070221_881037_7F701E78 X-CRM114-Status: GOOD ( 22.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Emil Renner Berthing , "open list:ARM/Rockchip SoC support" , Tony Xie , Viresh Kumar , Randy Li , linux-kernel@vger.kernel.org, Vicente Bergas , dianders@chromium.org, edubezval@gmail.com, Enric Balletbo i Serra , Rob Herring , Klaus Goger , manivannan.sadhasivam@linaro.org, Matthias Brugger , Philipp Tomsich , "moderated list:ARM/Rockchip SoC support" , Christoph Muellner Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/06/2019 14:03, Daniel Lezcano wrote: > On 14/06/2019 11:35, Heiko Stuebner wrote: >> Hi Daniel, >> >> Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano: >>> Currently the common thermal zones definitions for the rk3399 assumes >>> multiple thermal zones are supported by the governors. This is not the >>> case and each thermal zone has its own governor instance acting >>> individually without collaboration with other governors. >>> >>> As the cooling device for the CPU and the GPU thermal zones is the >>> same, each governors take different decisions for the same cooling >>> device leading to conflicting instructions and an erratic behavior. >>> >>> As the cooling-maps is about to become an optional property, let's >>> remove the cpu cooling device map from the GPU thermal zone. >>> >>> Signed-off-by: Daniel Lezcano >>> --- >>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 9 --------- >>> 1 file changed, 9 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >>> index 196ac9b78076..e1357e0f60f7 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >>> @@ -821,15 +821,6 @@ >>> type = "critical"; >>> }; >>> }; >>> - >>> - cooling-maps { >>> - map0 { >>> - trip = <&gpu_alert0>; >>> - cooling-device = >>> - <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, >>> - <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; >>> - }; >>> - }; >>> }; >>> }; >> >> my knowledge of the thermal framework is not that big, but what about the >> rk3399-devices which further detail the cooling-maps like rk3399-gru-kevin >> and the rk3399-nanopc-t4 with its fan-handling in the cooling-maps? > > The rk3399-gru-kevin is correct. > > The rk3399-nanopc-t4 is not correct because the cpu and the gpu are > sharing the same cooling device (the fan). There are different > configurations: > > 1. The cpu cooling device for the CPU and the fan for the GPU > > 2. Different trip points on the CPU thermal zone, eg. one to for the CPU > cooling device and another one for the fan. > > There are some variant for the above. If this board is not on battery, > you may want to give priority to the throughput, so activate the fan > first and then cool down the CPU. Or if you are on battery, you may want > to invert the trip points. > > In any case, it is not possible to share the same cooling device for > different thermal zones. OK, thanks for the clarification. I'll get my board set up again to figure out the best fix for rk3399-nanopc-t4 (FWIW most users are probably just using passive cooling or a plain DC fan anyway). You might want to raise this issue with the maintainers of arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi, since the everything-shared-by-everything approach in there was what I used as a reference. Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel