From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31384C433FE for ; Mon, 3 Oct 2022 07:01:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FfyAi+jNsGS9XalQGBbzDH54HjVbJA9pLbDCD0ZXgz4=; b=HhZY5MPZkrgTIs OhePdayTjm48Nvrv1X0QBYrQgWhhgX3plNyMMrU/JIBRoLBsmlrZ1nc0Tt/oPso4+kTxSlE3Nwto2 vJedqsmC0NL9kQmW+QwOSPbC7fMLfQtxYCgZRFKFqso64K5HwdhGNu443SPbm3OX7WT2bXPaitER/ phybgnLbTbRzzUGXCg2QrddOXV4rfGYL0G6d/NyL/V8NowaNtJCGRz/IfhHbg+7CsrSY3ySC26j2W LSwsk/Eihh+DMYioITuO2URrg2YZMVLuQcYGZKSVNrO4HTx/IvJfVB6r50U4dVDKhMvBPvye/7nKt n0YT7sILcs+L8qAiKf9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofFR6-004HO9-4u; Mon, 03 Oct 2022 07:00:20 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofFR3-004HMa-CX for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 07:00:18 +0000 Received: by mail-lf1-x12d.google.com with SMTP id g1so15213101lfu.12 for ; Mon, 03 Oct 2022 00:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=vmX/+5akulDOCofIBHD+M8QnLzZXAedqVxnThx38IY4=; b=fuX9+4t9ZGOXAgE6XMgw+mjIIdS5blIto35t4y0d84ktX+02fOHMFdAsQE6pP9w9I1 pXHgYsIX20ykr/GklszG1CNTIbTp40KPdGHVvnAT1n0rCHPop0u76Ntg0TMjP1qMlVK2 +ZY/fi9hWQ50YC5MxhDntNcMXwFxhUuY4izI6oZiEfoMDfflkkhaaShINj1autH5R3ka tl9nTkMT/u2cvU5Ozxu2k7/mtzyGz9BTnfZP+d+7SIFW6XXL1e6hA/VUZUB1pDQxU/hf PTehFFKs2SUtsWBH49kcN47E/Wga0In87bsJGN64EhcNmi+nAj8r0bGkQ5FUSiyW15tG QDsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=vmX/+5akulDOCofIBHD+M8QnLzZXAedqVxnThx38IY4=; b=5mVfAM8TDKnaLJT8xAUYcVrIZr6fbE2aqIowAv1WeOHy9ShqKS85biw6auNwN+y5ec QePnjjCcQHUwHHbrQ1CVqO+pVr5DatP3//BwugDfybHqc8H0hgew9iUbBDxj/12pVYRw piYBiRTzsM3WugyZj/QhHaR09yjMNW5pskzpYVNvJs4T+2IfBH1BhBTa+tQJqjoscygM iTjLVAchN6H8F1mEb2UmfqtVl3K/oN1OUPi0I0SAZ2yv+kb0sHS+KaMb5ySwcnb92/Fn lagDUCIEekvb+E+owenNkb/0b81YgjuiXxlKT+qspyFx5lhGzGIePQCKolk1M5NiMUhk AoVg== X-Gm-Message-State: ACrzQf1WWHvcar7fIz6HDQGrIpId+Hfmdh4AFuCxFtO4zlwW+6Wz3rLY Ajss0k/qA14ivxd6J2w74I3V5w== X-Google-Smtp-Source: AMsMyM71h9ZWNt7tTqHQed1PvCu17KvvZrSjQpebtCZ580Hiifm5oPbO/Jdo2t2/bUxgw6iNZDFY+g== X-Received: by 2002:a05:6512:3a89:b0:4a2:fbe:5573 with SMTP id q9-20020a0565123a8900b004a20fbe5573mr5038065lfu.546.1664780412454; Mon, 03 Oct 2022 00:00:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id z13-20020a056512308d00b00499b57032c1sm1334433lfd.144.2022.10.03.00.00.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 00:00:12 -0700 (PDT) Message-ID: Date: Mon, 3 Oct 2022 09:00:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/3] watchdog: xilinx_wwdt: Add Versal window watchdog support Content-Language: en-US To: Guenter Roeck , Srinivas Neeli , wim@linux-watchdog.org, shubhrajyoti.datta@amd.com, michal.simek@amd.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, git@amd.com References: <20220927110257.41963-1-srinivas.neeli@amd.com> <20220927110257.41963-3-srinivas.neeli@amd.com> <1cb7fdb7-ebad-a61e-490c-80e6c9feab2b@roeck-us.net> From: Krzysztof Kozlowski In-Reply-To: <1cb7fdb7-ebad-a61e-490c-80e6c9feab2b@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_000017_460124_051FC44A X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/10/2022 18:29, Guenter Roeck wrote: > On 9/30/22 03:35, Krzysztof Kozlowski wrote: >> On 27/09/2022 13:02, Srinivas Neeli wrote: >>> + >>> +static void xwwdt_clk_disable_unprepare(void *data) >>> +{ >>> + clk_disable_unprepare(data); >> >> If watchdog is stopped and then device unbound, don't you have double >> disable? IOW, where is matching clk_enable? >> > > After looking into the entire driver code, I see the problem: > clk_disable() is called in the stop function. That is wrong; > if the clock is disabled in the stop function, it needs to be Yep. clk_disable and clk_enable are always paired. In probe they are pared with remove() or reset-action. This one is in stop(), so it does not have its pair. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel