* Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak [not found] ` <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn> @ 2020-07-01 9:42 ` Markus Elfring 2020-07-01 9:58 ` Tiezhu Yang 0 siblings, 1 reply; 2+ messages in thread From: Markus Elfring @ 2020-07-01 9:42 UTC (permalink / raw) To: Tiezhu Yang, Thomas Gleixner, Jason Cooper, Marc Zyngier, Michal Simek, linux-arm-kernel Cc: kernel-janitors, linux-kernel > In the function xilinx_intc_of_init(), system resource "irqc->root_domain" > was not released in the error case. Thus add jump target for the completion > of the desired exception handling. Another small wording adjustment: … Thus add a jump target … … > +++ b/drivers/irqchip/irq-xilinx-intc.c … > @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, > > return 0; > > +error_domain_remove: > + irq_domain_remove(irqc->root_domain); > error: > iounmap(irqc->base); … Can labels like “remove_irq_domain” and “unmap_io” be nicer? Regards, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak 2020-07-01 9:42 ` [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Markus Elfring @ 2020-07-01 9:58 ` Tiezhu Yang 0 siblings, 0 replies; 2+ messages in thread From: Tiezhu Yang @ 2020-07-01 9:58 UTC (permalink / raw) To: Markus Elfring, Thomas Gleixner, Jason Cooper, Marc Zyngier, Michal Simek, linux-arm-kernel Cc: kernel-janitors, linux-kernel On 07/01/2020 05:42 PM, Markus Elfring wrote: >> In the function xilinx_intc_of_init(), system resource "irqc->root_domain" >> was not released in the error case. Thus add jump target for the completion >> of the desired exception handling. > Another small wording adjustment: > … Thus add a jump target … OK > > > … >> +++ b/drivers/irqchip/irq-xilinx-intc.c > … >> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, >> >> return 0; >> >> +error_domain_remove: >> + irq_domain_remove(irqc->root_domain); >> error: >> iounmap(irqc->base); > … > > Can labels like “remove_irq_domain” and “unmap_io” be nicer? Thank you, I will use "err_domain_remove" and "err_iounmap" to keep consistence with other patches. > > Regards, > Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn>
[not found] ` <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 9:42 ` [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Markus Elfring
2020-07-01 9:58 ` Tiezhu Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).