From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C67E9C433EF for ; Mon, 21 Mar 2022 15:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oy5z49c3xowsdpjnqcc/fSTvBBwpensnfPAjfdAg12M=; b=2GzPv2SB3B508y nN7Cq+J4+fJUMwyhv3kQr5svE7MhRIth3LR4ij+i1KKeskouR/2QCW6tKYQvnn4UKJrFq7s8Ebkkb U95ertJVB/I/B0zV3nVWMCSybhjwu2wWYeS8A1XVmbvwyoB6sKnUaGitW63Z/G30zEytf1Q9iuHjU 89/1+3EgXWS96XVguMkaNefpU5CaBXvbiXKzGFZIMCW0IsYXsesHT2hL5ih6t51KhTxmPZdf7eD7p mVECrXHGSzz/TfQfynt5oreDExbNKzMBaNBx59Hz/g8fFD196n8iY2AcDOAb+b2RbOW+MjAz/XYKI RPPKTGeVDwBdn5hCKvjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJdZ-0086oe-QW; Mon, 21 Mar 2022 15:08:02 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJdW-0086nd-FP for linux-arm-kernel@lists.infradead.org; Mon, 21 Mar 2022 15:07:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647875276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZFVfxmzhaFPMubA718aiLUSwyIk5+iMjz6qfYM1xb4A=; b=Y9d1GeB1ikL7K23mfJ8pybHaLISLTyF1gN+WQe/C/Eu1pBa8k1bsPGBz/5chG4sxUOwTFw 0u+vIFhphhHV/vVXeUpaGtm1bM/D665M8NOBioWVK5o0OppfYiHYj5fPel2PXDOUUuBKN6 dcLyRQXghx6E6ukP55WWVBcXoEOj86k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-16-GCXDFXNjMVaT-jPNsIvJCw-1; Mon, 21 Mar 2022 11:07:52 -0400 X-MC-Unique: GCXDFXNjMVaT-jPNsIvJCw-1 Received: by mail-wr1-f70.google.com with SMTP id h11-20020a5d430b000000b001f01a35a86fso3177359wrq.4 for ; Mon, 21 Mar 2022 08:07:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=ZFVfxmzhaFPMubA718aiLUSwyIk5+iMjz6qfYM1xb4A=; b=wntpmANINQ7qjc7fbmgUF6wQxUtEmnYIfj7RdUz5HN7+Bwd2H+X8/s8kDVxhdSdoz7 5oj/hHPo9e5XMEvPPhtSdzjlH8JTHJBVMyDXFJ4zCsQSoHQMvdtngxpj8sz2uXWKcr5V OTK2Sh+L6FTpC/YTHZFJVT14UAVzTWOdAaatBp+4P4GXPPvUdNqXrR6b+rWXo2zUujbu dSXCHYPyLjgvrbLWwLf9DIVsmQlULOrwGyw3auo7BbX9Nc92oN/HAXVZ8ZBxtPd74D3c vvjQ797ZJYtCw7U5Hz/a/yVGIOtum/d3a5rQN+uRKfBPMwshc16fMxAbsiGsrY05tVsQ TSfQ== X-Gm-Message-State: AOAM533EG3tYgBrNkmFc++7Hd1/Pj7mQQWME3dR2Ns11Cx6GH+M8T9pK tsNcpGbx3rxDuNEYhi5v71vUEgOHczKgWyKHxyu4kxHmd2BaLxi7wtcWLqHo7UKpo1/CUDyoFsb /YYy2d/lna5/3og837GXq1fyxsLV1zEnsXnU= X-Received: by 2002:a05:600c:4ed2:b0:38c:93ad:4825 with SMTP id g18-20020a05600c4ed200b0038c93ad4825mr11133385wmq.181.1647875271720; Mon, 21 Mar 2022 08:07:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKoU0nGg0p5jibfOm4Ew1arWHbW+SRBIfaAS1QHWKwXAqgZDqMtY1m9j1jU9wOkm317ZDDsQ== X-Received: by 2002:a05:600c:4ed2:b0:38c:93ad:4825 with SMTP id g18-20020a05600c4ed200b0038c93ad4825mr11133335wmq.181.1647875271332; Mon, 21 Mar 2022 08:07:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:4900:849b:f76e:5e1f:ff95? (p200300cbc7044900849bf76e5e1fff95.dip0.t-ipconnect.de. [2003:cb:c704:4900:849b:f76e:5e1f:ff95]) by smtp.gmail.com with ESMTPSA id g10-20020a5d46ca000000b00203fd86e198sm7209759wrs.96.2022.03.21.08.07.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 08:07:50 -0700 (PDT) Message-ID: Date: Mon, 21 Mar 2022 16:07:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v1 4/7] arm64/pgtable: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE To: Will Deacon , Catalin Marinas Cc: linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , linux-mm@kvack.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20220315141837.137118-1-david@redhat.com> <20220315141837.137118-5-david@redhat.com> <20220321143802.GC11145@willie-the-truck> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220321143802.GC11145@willie-the-truck> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_080758_644876_72E22D21 X-CRM114-Status: GOOD ( 22.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.03.22 15:38, Will Deacon wrote: > On Wed, Mar 16, 2022 at 06:27:01PM +0000, Catalin Marinas wrote: >> On Tue, Mar 15, 2022 at 03:18:34PM +0100, David Hildenbrand wrote: >>> diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h >>> index b1e1b74d993c..62e0ebeed720 100644 >>> --- a/arch/arm64/include/asm/pgtable-prot.h >>> +++ b/arch/arm64/include/asm/pgtable-prot.h >>> @@ -14,6 +14,7 @@ >>> * Software defined PTE bits definition. >>> */ >>> #define PTE_WRITE (PTE_DBM) /* same as DBM (51) */ >>> +#define PTE_SWP_EXCLUSIVE (_AT(pteval_t, 1) << 2) /* only for swp ptes */ >> >> I think we can use bit 1 here. >> >>> @@ -909,12 +925,13 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, >>> /* >>> * Encode and decode a swap entry: >>> * bits 0-1: present (must be zero) >>> - * bits 2-7: swap type >>> + * bits 2: remember PG_anon_exclusive >>> + * bits 3-7: swap type >>> * bits 8-57: swap offset >>> * bit 58: PTE_PROT_NONE (must be zero) >> >> I don't remember exactly why we reserved bits 0 and 1 when, from the >> hardware perspective, it's sufficient for bit 0 to be 0 and the whole >> pte becomes invalid. We use bit 1 as the 'table' bit (when 0 at pmd >> level, it's a huge page) but we shouldn't check for this on a swap >> entry. > > I'm a little worried that when we're dealing with huge mappings at the > PMD level we might lose the ability to distinguish them from a pte-level > mapping with this new flag set if we use bit 1. A similar issue to this > was fixed a long time ago by 59911ca4325d ("ARM64: mm: Move PTE_PROT_NONE > bit") when we used to use bit 1 for PTE_PROT_NONE. > > Is something like: > > pmd_to_swp_entry(swp_entry_to_pmd(pmd)); Note that __HAVE_ARCH_PTE_SWP_EXCLUSIVE currently only applies to actual swap entries, not non-swap entries (migration, hwpoison, ...). So it really only applies to PTEs -- PMDs are not applicable. So the example you gave cannot possibly have that bit set. From what I understand, it should be fine. But I have no real preference: I can also just stick to the original patch, whatever you prefer. Thanks! -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel