From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E823AC282C2 for ; Wed, 13 Feb 2019 13:48:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5CE8222C1 for ; Wed, 13 Feb 2019 13:48:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oUqr9z9T"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tZX5/Zkp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5CE8222C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xtIFJhRoiXvLEIsFasV6uwo0HvzoRfxyQ2jEyzg+fC4=; b=oUqr9z9TWtCOTb Gw3TCcR4+pApUPQodDvS1TJxyxmTXuxnlTMwIu5AKk4WP8AaFU0AfJAKMk4Gl8s3NdxNRfiS4h6JJ QI7tVLwc+rgNTaCCVgh4AdYCTSTU/EcUfyKIxJusv9dRMQTNuXz+L+m/aHmGJSX69/4+QVE1Uq0S8 Hg3Q6I70+qrXxEcY3A9pza8wCN+yZijteJYVNZnnd6gpwIHns98o850DIa7/0PMwe91OzHmH0qf1P ingDaX7Nxzb6Kz9aMGUibMUoLU3FttywvUY8VCnWxeIdhB9ccWN5p4M0K7J1oggCC8AOUl4nlt2r9 uBt05ywFKNNgAJ3hv69A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtutQ-0008Mf-3C; Wed, 13 Feb 2019 13:48:04 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtutL-0008Le-Fu; Wed, 13 Feb 2019 13:48:00 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x1DDlsbd079526; Wed, 13 Feb 2019 07:47:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1550065674; bh=aWdopirzZVESKE/3wZS+ty22uj0ge74IDmupL+yPkhQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=tZX5/ZkpSxMqyjwb+vwtjfRNiDOHgZpYsJtZkYqfxdj6RwcGTFHHcz3X/rqzt60RG SZz4RIASS5YNZbLCU7PWVYIHB2uhGPO2fXADw/yeHYR8xuywLYIM0UpODGQ5tqtyc4 hjRFqmgBZXK4F6MyMCeWlVcPJ2fWYCk4M9ZNPP1Y= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x1DDlsfa040330 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 13 Feb 2019 07:47:54 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 13 Feb 2019 07:47:54 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 13 Feb 2019 07:47:53 -0600 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x1DDlnLS027769; Wed, 13 Feb 2019 07:47:50 -0600 Subject: Re: [PATCH v2 08/15] PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags To: Lorenzo Pieralisi References: <20190114111513.21618-1-kishon@ti.com> <20190114111513.21618-9-kishon@ti.com> <20190211173723.GA31035@e107981-ln.cambridge.arm.com> From: Kishon Vijay Abraham I Message-ID: Date: Wed, 13 Feb 2019 19:17:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190211173723.GA31035@e107981-ln.cambridge.arm.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190213_054759_614768_2ADD307E X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Gustavo Pimentel , Shawn Lin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Alan Douglas , Jingoo Han , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: Hi Lorenzo, On 11/02/19 11:07 PM, Lorenzo Pieralisi wrote: > On Mon, Jan 14, 2019 at 04:45:06PM +0530, Kishon Vijay Abraham I wrote: >> pci_epf_alloc_space() sets the MEM TYPE flags to indicate a 32-bit >> Base Address Register irrespective of the size. Fix it here to indicate >> 64-bit BAR if the size is > 2GB. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/endpoint/pci-epf-core.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > This looks like a fix and should me marked as such. Does it work > as as standalone patch if it gets backported ? Yeah, it should work. But the current users doesn't allocate > 2GB and some EPC drivers configure their registers based on size. So nothing is broken without this patch as such. Thanks Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel