From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_DISCARD,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3277CC433DF for ; Fri, 7 Aug 2020 18:00:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB0972075D for ; Fri, 7 Aug 2020 18:00:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ELHA5Mhk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=mm-sol.com header.i=@mm-sol.com header.b="TZTULKRv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB0972075D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=mm-sol.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jFWXWjJDTsI6FbJZuTvjKaeOLoj2mraiVkR8PyXauls=; b=ELHA5MhkDQN2LP714B7Epk8RV 7VJpHd4B20Y9cT23PrWS/Ynwq/ytscUR702qAXKSzdi33bLjTom0xHFMnAqxLL7wfVUx46H9JaANZ uuO6lMyAQjvfEb0PIzYPvh94KuvrZaeZSi+l9RtzfGtFp+qZ7Gk1RxyRuopO4Z2kRBTJ4nVgfjZe2 wSOAzsW/j4xjNxAx/d/7JSQ/D6eMAcbkEZmBp7hYKOxgp3ZHbfTsKySn1wXE1har/On9ocB8KmlRj IcQpnfdyOcwGp6cVsOox136+xLIvl5MkR8RcW7uNq9FW1/o7uhwTfLmjSRLUbcvqoVGXHNfiIu72y B//gzpr9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k46eD-0005uu-Qv; Fri, 07 Aug 2020 17:59:17 +0000 Received: from ns.mm-sol.com ([37.157.136.199] helo=extserv.mm-sol.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k46eA-0005uM-Jf for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 17:59:15 +0000 Received: from [192.168.1.100] (unknown [195.24.90.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by extserv.mm-sol.com (Postfix) with ESMTPSA id AEA50D02B; Fri, 7 Aug 2020 20:59:09 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mm-sol.com; s=201706; t=1596823150; bh=01HxtO8TjyfJb6k7J+gRA2TnNfEUBHAPhEjgIcuz/u0=; h=Subject:To:Cc:From:Date:From; b=TZTULKRv65g757g49+c8p7aM+O5iyuEpRaLPDmBHhSkHxNabM2L5i5kHksE2vJpS+ tJGzy8V3xpxuF3TVXvPFqiwuM8QwRu2+YDUKV3ldo/yWku8Aop2iTuAkw88XBkrE34 lNVudBFm8xuuiGNDqah5SHeuCyubS+/bZL3d19dgPUxcp+APNEE0rZ+FtMUPLNvfUJ 4m+VQeWLF57npkWczWZ6nl0+Tyh/ETqCEZQABIGJsqiTOSox47SZsbLmH/YRAk6IcL h0/d4nZMkSGeNEaQEX8qTeZ5Hn7ZEzoK9lVUllrDIKvkx5wy0g87CDC9no5PWqz3WW zobGk1feb4Juw== Subject: Re: [PATCH 21/22] crypto: qce - add check for xts input length equal to zero To: Andrei Botila , Herbert Xu , "David S. Miller" References: <20200807162010.18979-1-andrei.botila@oss.nxp.com> <20200807162010.18979-22-andrei.botila@oss.nxp.com> From: Stanimir Varbanov Message-ID: Date: Fri, 7 Aug 2020 20:59:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200807162010.18979-22-andrei.botila@oss.nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_135914_910080_5F2D3B25 X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Andrei Botila , x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Thanks for the patch! On 8/7/20 7:20 PM, Andrei Botila wrote: > From: Andrei Botila > > Standardize the way input lengths equal to 0 are handled in all skcipher > algorithms. All the algorithms return 0 for input lengths equal to zero. > > Signed-off-by: Andrei Botila > --- > drivers/crypto/qce/skcipher.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Stanimir Varbanov > > diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c > index 5630c5addd28..887fd4dc9b43 100644 > --- a/drivers/crypto/qce/skcipher.c > +++ b/drivers/crypto/qce/skcipher.c > @@ -223,6 +223,9 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) > int keylen; > int ret; > > + if (!req->cryptlen && IS_XTS(rctx->flags)) > + return 0; > + > rctx->flags = tmpl->alg_flags; > rctx->flags |= encrypt ? QCE_ENCRYPT : QCE_DECRYPT; > keylen = IS_XTS(rctx->flags) ? ctx->enc_keylen >> 1 : ctx->enc_keylen; > -- regards, Stan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel