From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527B8C4338F for ; Tue, 3 Aug 2021 12:58:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 136E560F38 for ; Tue, 3 Aug 2021 12:58:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 136E560F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=cu4gOQbFBJTr5CqEhWGfgKUMLFge6okO3vVUKIM1bzw=; b=02DPa64O8wOyMHd5r5Vxtl/3ma 3vHpZdKCT7TqgwlT5XvGBQREtJW6dWnDkR76yLGxPFNlePWmIg8HtBnLquK0zrVVBiwLkxQ/ksn/Y Emu1NiSY+X2PMkyambiH9RxsUlU8XV9j07t4pecQ7MJdcDw2rQ9//ARNtKNOpRkkE5gDNcJ956FZJ hKITJ7uYiAW/kSIjTuMbOPqGC1DOFoosHEKHU67U2L/7V41uvBxhp1k1xrqSEZZfPXUpkuJPdY4KE Ah2yri0ix6lkpxosFhBzMllPPOkOh4RNi3n9iM6vpgnFFMN2Rg4ish0kK7I5iOJ/Me0YUt7Tr5G3A s+1GDy9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAtyQ-002mxs-R4; Tue, 03 Aug 2021 12:56:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAteb-002fwG-Ta for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 12:36:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 32DBC11FB; Tue, 3 Aug 2021 05:36:14 -0700 (PDT) Received: from [10.57.36.239] (unknown [10.57.36.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E49413F40C; Tue, 3 Aug 2021 05:36:11 -0700 (PDT) Subject: Re: [PATCH 3/6] perf cs-etm: Save TRCDEVARCH register To: Leo Yan , Mike Leach Cc: Arnaldo Carvalho de Melo , Mathieu Poirier , Coresight ML , Al Grant , "Suzuki K. Poulose" , Anshuman Khandual , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-4-james.clark@arm.com> <20210731063731.GC7437@leoy-ThinkPad-X240s> From: James Clark Message-ID: Date: Tue, 3 Aug 2021 13:36:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210731063731.GC7437@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_053618_100084_90AFDC38 X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/07/2021 07:37, Leo Yan wrote: >>> diff --git a/tools/perf/util/cs-etm.h b/tools/perf/util/cs-etm.h >>> index d65c7b19407d..52d82dce9d59 100644 >>> --- a/tools/perf/util/cs-etm.h >>> +++ b/tools/perf/util/cs-etm.h >>> @@ -59,7 +59,7 @@ enum { >>> /* define fixed version 0 length - allow new format reader to read old files. */ >>> #define CS_ETM_NR_TRC_PARAMS_V0 (CS_ETM_ETMIDR - CS_ETM_ETMCR + 1) >>> >>> -/* ETMv4 metadata */ >>> +/* ETMv4 + ETE metadata */ >>> enum { >>> /* Dynamic, configurable parameters */ >>> CS_ETMV4_TRCCONFIGR = CS_ETM_COMMON_BLK_MAX_V1, >>> @@ -70,7 +70,8 @@ enum { >>> CS_ETMV4_TRCIDR2, >>> CS_ETMV4_TRCIDR8, >>> CS_ETMV4_TRCAUTHSTATUS, >>> - CS_ETMV4_PRIV_MAX, >>> + CS_ETE_TRCDEVARCH, >>> + CS_ETMV4_PRIV_MAX > Spurious change for "CS_ETMV4_PRIV_MAX"? This change will be removed in the next version due to moving it into a new enum. But it wasn't a mistake, CS_ETMV4_PRIV_MAX is used to define the length of the header so it always needs to be at the end if another item is saved. James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel